The latter is easier to read and is the "correct" thing to do.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

This way, we save the overhead for acquiring the tag_pool_lock.

Also, use RemoveAll() instead of directly clearing TagBuilder::items in
most cases, as its elements represent references that must be released.

Closes #1023

This reverts commit 1532983f.  This
optimization was bad because now all strings match if they are a
prefix of another string, and this caused collisions in the tag string
pool, corrupting the database.

This commit adds some tags that are (mostly) interesting for listeners
of classical music.

Ensemble
--------
This is an ensemble that is playing the music, such as Wiener
Philharmoniker. The tag can be used to distinguish the ensemble from the
conductor, composer, soloist, and ensemble, that are generally all in
the "ARTIST" tag.

Movement
-------
The movement number and movement (name) of this track, i.e.  "II" and
"Allegro".

ComposerSort
------------
Allows us to look for Beethoven's 9th under B, for Beethoven, not L for
Ludwig.

Location
--------
This is the location of the recording, e.g. "Wiener Musikverein".

Shorter.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Conductor was incorrectly saved to Performer tag in MPD database

Shorter.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

The ones in std have overloads for const char/char.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Fixes breakage of non-ASCII characters, regression from commit
cc72ceb3

Fixes https://github.com/MusicPlayerDaemon/MPD/issues/842

Closes https://github.com/MusicPlayerDaemon/MPD/issues/838

This reduces resource waste for resizing the std::vector in most
cases.