1. 04 Sep, 2007 1 commit
    • Eric Wong's avatar
      log: better bug avoidance for libraries incorrectly handling fd=0 · 146485d0
      Eric Wong authored
      We redirect stdin to /dev/null to work around a libao bug, but
      this bug has been fixed in libao since 2003 (according to jat).
      
      However, there are likely other bugs in other libraries (and
      even our code!) that handle fd=0 incorrectly and I'd rather not
      take the risk[1].  So So it's easiest to just keep
      fd=0==/dev/null for now...
      
      [1] - I've seen several of these myself...
      
      git-svn-id: https://svn.musicpd.org/mpd/trunk@6849 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      146485d0
  2. 02 Sep, 2007 2 commits
    • Eric Wong's avatar
      zeroconf: avoid passing NULLs to Avahi *_free() routines · 203a5ed2
      Eric Wong authored
      This should fix Debian bug #428551
      (mpd crashes when restarting the dbus daemon)
      
      git-svn-id: https://svn.musicpd.org/mpd/trunk@6844 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      203a5ed2
    • Eric Wong's avatar
      Fix endless loop when mpd is launched from a non-interactive shell. · bbe8b0ef
      Eric Wong authored
      Thanks to _noth_ for the patch, this fixes Mantis bug #1534
      
      _noth_ wrote:
      > When MPD is launched from a non-interactive shell, it enters an endless
      > loop, filling up its error log file with "error accept()'ing" messages.
      > This is caused by the fact that stdin is already closed when mpd starts
      > up.  listenOnPort() opens up the first of its sockets as fd 0 (the first
      > empty fd table position). Then, setup_log_output()->redirect_stdin()
      > overwrites fd0 (fd=open("/dev/null",...); dup2(fd, STDIN_FILENO);)
      > without checking if it corresponds to the actual standard input (or if
      > it is open in the first place).  This means that listenSockets[0].fd now
      > is a fd for /dev/null, thus doIOForInterfaces()->getConnections() can't
      > accept(2) on it and fails with the above error. The attached patch fixes
      > this for me.
      
      git-svn-id: https://svn.musicpd.org/mpd/trunk@6843 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      bbe8b0ef
  3. 01 Sep, 2007 1 commit
  4. 28 Aug, 2007 2 commits
  5. 27 Aug, 2007 5 commits
  6. 25 Aug, 2007 1 commit
  7. 22 Aug, 2007 1 commit
    • J. Alexander Treuman's avatar
      inputPlugins/mp3_plugin: parse LAME tags for ReplayGain info · fe4b16ed
      J. Alexander Treuman authored
      Parse ReplayGain info in LAME tags and use it if no ID3v2 ReplayGain tags
      are found.  This is currently a bit unsafe, as apparently some LAME tags
      have bogus ReplayGain values.  But I'm finding a lot of MP3s with valid
      LAME tags that fail the LAME tag CRC check.  So until I figure out why
      that's happening, it's an unreliable method for checking if the LAME tag is
      valid.
      
      A big thanks to tmz for writing the original patch.
      
      git-svn-id: https://svn.musicpd.org/mpd/trunk@6798 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      fe4b16ed
  8. 12 Aug, 2007 2 commits
  9. 11 Aug, 2007 2 commits
  10. 16 Jul, 2007 1 commit
  11. 29 Jun, 2007 1 commit
  12. 25 Jun, 2007 5 commits
  13. 24 Jun, 2007 3 commits
  14. 13 Jun, 2007 3 commits
  15. 12 Jun, 2007 5 commits
  16. 10 Jun, 2007 1 commit
  17. 09 Jun, 2007 4 commits