- 28 Apr, 2009 2 commits
-
-
Max Kellermann authored
strcasecmp() is locale dependent, making it a bad choice for internal string comparisons.
-
Daniel Kahn Gillmor authored
This allows you to select controls with duplicate names.
-
- 21 Apr, 2009 1 commit
-
-
Max Kellermann authored
snd_config_update_free_global() frees cached ALSA configuration. This keeps valgrind a little bit more quiet. This patch moves the call from the open() method into the finish() method, which seems more natural: it allows the use of the config cache, and improves the cleanup phase.
-
- 27 Mar, 2009 1 commit
-
-
Max Kellermann authored
Added an assertion in mixer_set_volume(). Removed the range checks from the ALSA and OSS plugins.
-
- 26 Mar, 2009 6 commits
-
-
Max Kellermann authored
"volume_set" is an attribute which becomes undefined when the mixer is closed. That means, it must be initialized each time the mixer is opened.
-
Max Kellermann authored
The MPD core guarantees that methods are always invoked in a consistent state. This means we can remove lots of checks from the volume methods.
-
Max Kellermann authored
Instead of replacing NULL with the default device in the open() method, pass the default device to config_get_block_string().
-
Max Kellermann authored
Use config_get_block_string() instead of config_dup_block_string().
-
Max Kellermann authored
When getting or setting the volume fails, the MPD core close the mixer. Moved the duplicated code from the mixer plugins.
-
Max Kellermann authored
Remember if a mixer object is open or closed. Don't call open() again if it is already open. This guarantees that the mixer plugin is always called in a consistent state, and we will be able to remove lots of checks from the implementations. To support mixers which are automatically opened even if the audio output is still closed (to set the volume before playback starts), this patch also adds the "global" flag to the mixer_plugin struct. Both ALSA and OSS set this flag, while PULSE does not.
-
- 13 Mar, 2009 1 commit
-
-
Avuton Olrich authored
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
-
- 16 Feb, 2009 1 commit
-
-
Max Kellermann authored
The method control() is too complicated, and overengineered. Replace it with two trivial functions: get_volume() and set_volume().
-
- 25 Jan, 2009 7 commits
-
-
Max Kellermann authored
The mixer plugins should re-use the mixer struct and incorporate it in their object class.
-
Max Kellermann authored
Both methods are always called together. There is no point in having them separate. This simplifies the code, because the old configure() method could be called more than once, and had to free old allocations.
-
Max Kellermann authored
Those have been superseded by the new legacy configuration code.
-
Max Kellermann authored
The plugin structures must never be modified.
-
Max Kellermann authored
-
Max Kellermann authored
Return the default value in the conf_get_block_*() functions when param==NULL was passed. This simplifies a lot of code, because all initialization can be done in one code path, regardless whether configuration is present.
-
Max Kellermann authored
All config_get_block_*() functions should accept constant config_param pointers.
-
- 18 Jan, 2009 2 commits
-
-
Max Kellermann authored
This replaces lots of getBlockParam() invocations.
-
Max Kellermann authored
The g_free() function includes a NULL check. We don't have to do it twice.
-
- 17 Jan, 2009 1 commit
-
-
Max Kellermann authored
Renamed functions, types, variables.
-
- 16 Jan, 2009 1 commit
-
-
Max Kellermann authored
When MPD starts without audio output configuration, the "param" variable is NULL. This triggers a segmentation fault in both mixer plugins.
-
- 11 Jan, 2009 1 commit
-
-
Viliam Mateicka authored
removing mixer_reconfigure memmory leak, fixing configure of alsa and oss mixer (passing parameters)
-
- 10 Jan, 2009 1 commit
-
-
Viliam Mateicka authored
This patch tryes to introduce pluggable mixer (struct mixer_plugin) along with some basic infrastructure (mixer_* functions). Instance of mixer (struct mixer) is used in alsa and oss output plugin
-
- 04 Jan, 2009 1 commit
-
-
Viliam Mateicka authored
-
- 01 Jan, 2009 1 commit
-
-
Max Kellermann authored
There is no reason to use the shortcut "mix" instead of "mixer".
-
- 31 Dec, 2008 1 commit
-
-
Viliam Mateicka authored
-