shorter
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Fixes https://github.com/MusicPlayerDaemon/MPD/discussions/1281

The problem occurred when there was libfmt-dev installed, but it was
too old (e.g. on Debian Buster), and Meson used the wrap fallback.
Those internal MPD libraries where the libfmt dependency was not
declared were still using the old system libfmt headers, which are not
ABI-compatible with MPD's own libfmt build.

These should be equivalent anyway.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with readability-const-return-type
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with cppcoreguidelines-special-member-functions
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Enables the "Format" row in "playlistinfo" responses.

https://github.com/MusicPlayerDaemon/MPD/issues/1094

Found with cppcoreguidelines-interfaces-global-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>

This is the same as GetMimeTypeBase(), which has already been applied.

No need to copy it to a buffer.

This allows users to disable the "CUE files as directories" feature
without having to disable the CUE playlist plugin completely.  This
feature has been annoying some users.

On Windows, there is an IsWhitespaceOrNull() overload with TCHAR, and
the compiler doesn't know which one to pass to std::find_if().

Don't copy the input StringView.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/974

cue_next_word() can return a pointer one past the end of the string if
the word is followed by the terminating null byte.

The ones in std have overloads for const char/char.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

This makes ccache more efficient when recompiling with different
plugins.

Found with modernize-use-default-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with readability-redundant-access-specifiers
Signed-off-by: Rosen Penev <rosenp@gmail.com>

[[maybe_unused]] (introduced in C++17) is standard C++.

https://clang.llvm.org/docs/AttributeReference.html#maybe-unused-unused
says that this is equivalent to the GNU unused attribute.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

The former was deprecated with C++14.

According to the C++11 and C++17 standards, both files are identical.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Similar to c45f1138

Closes https://github.com/MusicPlayerDaemon/MPD/issues/781