Skip to content

M
mpd
Switch branch/tag
  1. 24 Sep, 2008 4 commits
    • Max Kellermann's avatar
      output: make "struct audio_output" opaque for output plugins · acc4a0ba
      Max Kellermann authored 
      We have eliminated direct accesses to the audio_output struct from
the all output plugins.  Make it opaque for them, and move its real
declaration to output_internal.h, similar to decoder_internal.h.

Pass the opaque structure to plugin.init() only, which will return the
plugin's data pointer on success, and NULL on failure.  This data
pointer will be passed to all other methods instead of the
audio_output struct.
      acc4a0ba
    • Max Kellermann's avatar
      output: added audio_output_closed() · 63fb1efb
      Max Kellermann authored 
      The JACK output plugin needs to reset its "opened" flag when the JACK
server fails.  To prevent it from accessing the audio_output struct
directly introduce the API function audio_output_closed().
      63fb1efb
    • Max Kellermann's avatar
      output: set audio_output->open=1 in audio_output_task() · 2403d32a
      Max Kellermann authored 
      Since the output plugin returns a value indicating success or error,
we can have the output core code assign the "open" flag.
      2403d32a
    • Max Kellermann's avatar
      output: pass audio_format to plugin.init() and plugin.open() · 3cae6856
      Max Kellermann authored 
      Pass the globally configured audio_format as a const pointer to
plugin.init().  plugin.open() gets a writable pointer which contains
the audio_format requested by the plugin.  Its initial value is either
the configured audio_format or the input file's audio_format.
      3cae6856
  3. 08 Sep, 2008 1 commit
  5. 07 Sep, 2008 4 commits
  7. 26 Aug, 2008 9 commits
    • Max Kellermann's avatar
      made "sample_size" static const · 8a510948
      Max Kellermann authored 
      sample_size is a variable which is computed at compile time.  Declare
it "static const", so the compiler can optimize it away.
      8a510948
    • Max Kellermann's avatar
      moved jack configuration to the JackData struct · e056ff2b
      Max Kellermann authored 
      Storing local configuration in global (static) variables is obviously
a bad idea.  Move all those variables into the JackData struct,
including the locks.
      e056ff2b
    • Max Kellermann's avatar
      jack: removed unused macros · 479d02da
      Max Kellermann authored
      479d02da
    • Max Kellermann's avatar
      jack: don't set audioOutput->data=NULL · edd7e2f9
      Max Kellermann authored 
      There is only one caller of freeJackData() left: jack_finishDriver().
This function is called by the mpd core, and is called exactly once
for every successful jack_initDriver().  We do not need to clear
audioOutput->data, since this variable is invalidated anyway.
      edd7e2f9
    • Max Kellermann's avatar
      jack: initialize JackData in jack_initDriver() · 806a9f02
      Max Kellermann authored 
      Over the lifetime of the jack AudioOutput object, we want a single
valid JackData object, so we can persistently store data there
(configuration etc.).  Allocate JackData in jack_initDriver().  After
that, we can safely remove all audioOutput->data==NULL checks (and
replace them with assertions).
      806a9f02
    • Max Kellermann's avatar
      jack: added freeJackClient() · 83215bf9
      Max Kellermann authored 
      No need to destroy the JackData object when an error occurs, since
jack_finishDriver() already frees it.  Only deinitialize the jack
library, introduce freeJackClient() for that, and move code from
freeJackData().
      83215bf9
    • Max Kellermann's avatar
      jack: initialize jd->client after !jd check · dc989987
      Max Kellermann authored 
      Prepare the next patch: make the "!jd" check independent of the
jd->client initialization.  This way we can change the "jd"
initialization semantics later.
      dc989987
    • Max Kellermann's avatar
      jack: eliminate superfluous freeJackData() calls · 23832311
      Max Kellermann authored 
      connect_jack() invokes freeJackData() in every error handler, although
its caller also invokes this function after a failure.  We can save a
lot of lines in connect_jack() by removing these redundant
freeJackData() invocations.
      23832311
    • Max Kellermann's avatar
      enable -Wpointer-arith, -Wstrict-prototypes · a383f451
      Max Kellermann authored 
      Also enable -Wunused-parameter - this forces us to add the gcc
"unused" attribute to a lot of parameters (mostly library callback
functions), but it's worth it during code refactorizations.
      a383f451
  9. 13 Jun, 2008 1 commit
  11. 12 Apr, 2008 2 commits
  13. 03 Jan, 2008 1 commit
    • Eric Wong's avatar
      Cleanup #includes of standard system headers and put them in one place · cb8f1af3
      Eric Wong authored 
      This will make refactoring features easier, especially now that
pthreads support and larger refactorings are on the horizon.

Hopefully, this will make porting to other platforms (even
non-UNIX-like ones for masochists) easier, too.

os_compat.h will house all the #includes for system headers
considered to be the "core" of MPD.  Headers for optional
features will be left to individual source files.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7130 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      cb8f1af3
  15. 27 Aug, 2007 1 commit
  17. 23 May, 2007 1 commit
  19. 11 Apr, 2007 1 commit
  21. 09 Apr, 2007 1 commit
  23. 05 Apr, 2007 1 commit
  25. 23 Mar, 2007 2 commits
  27. 20 Jan, 2007 1 commit
  29. 14 Jan, 2007 6 commits
  31. 30 Dec, 2006 2 commits
  33. 18 Oct, 2006 2 commits