- 02 Nov, 2014 2 commits
-
-
Max Kellermann authored
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround!
-
Steven OBrien authored
-
- 01 Nov, 2014 1 commit
-
-
Max Kellermann authored
Use the new uri_get_suffix() overload that removes the query string.
-
- 28 Oct, 2014 1 commit
-
-
Max Kellermann authored
Negating an unsigned integer does not work.
-
- 25 Oct, 2014 1 commit
-
-
Max Kellermann authored
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround!
-
- 24 Oct, 2014 1 commit
-
-
Steven OBrien authored
-
- 02 Oct, 2014 2 commits
-
-
Max Kellermann authored
Make the "open" method of plugins "file" and "archive" dummy methods that always fail. Instead, let InputStream::Open() hard-code access to these two plugins by using OpenLocalInputStream(). This allows simplifyin the algorithm for falling back to probing archive plugins.
-
Max Kellermann authored
-
- 24 Sep, 2014 10 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Move code from the Vorbis and FLAC decoder plugins.
-
Max Kellermann authored
-
Max Kellermann authored
-
- 22 Sep, 2014 5 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Eliminates the functions _new() and _free().
-
- 21 Sep, 2014 6 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
- 19 Sep, 2014 7 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Support these PCM formats natively, instead of letting libsndfile convert everything to 32 bit.
-
Max Kellermann authored
-
Max Kellermann authored
Prepare for other sample formats.
-
- 09 Sep, 2014 1 commit
-
-
Max Kellermann authored
-
- 07 Sep, 2014 1 commit
-
-
Max Kellermann authored
That attribute was uninitialized before, which could crash libavformat. See Debian bug 760669
-
- 06 Sep, 2014 1 commit
-
-
Max Kellermann authored
Log call was added to the wrong branch. Fixes regression by commit ca1a1149
-
- 31 Aug, 2014 1 commit
-
-
Max Kellermann authored
-