Found with modernize-use-nodiscard
Signed-off-by: Rosen Penev <rosenp@gmail.com>

This is recommended by Solaris and NetBSD documentation.

Eliminates one strlen() call.

Fixes regression by commit 015cbff9 causing a crash bug because the
iterators of two different temporaries were used.

Eliminates lots of overhead.

Split the string into path segments with StringView::Split().  This
prepares to eliminate all allocations from the method.

std::all_of becomes constexpr in C++20. I'm not sure it results in better
performance.

Found with useStlAlgorithm
Signed-off-by: Rosen Penev <rosenp@gmail.com>

The _GLIBCXX_USE_C99_MATH macro is defined in glibcxx by c++config.h, which
gets included by every header. Which means a header needs to be present.