- 03 Feb, 2009 3 commits
-
-
Max Kellermann authored
The "current" variable is used for calculating the seek destination, and was declared as "int". With very long song files, the 32 bit integer can overflow. ffmpeg expects an int64_t, which is very unlikely to overflow. Switch to int64_t.
-
Max Kellermann authored
When ffmpeg cannot estimate the elapsed time, it sets AVPacket.pts=AV_NOPTS_VALUE. Our ffmpeg decoder plugin did not check for that special value.
-
Max Kellermann authored
If avcodec_decode_audio2() returns no output for an AVPacket, libavcodec may buffer some data, and return a larger chunk of output later. This patch disables a lot of bogus warnings.
-
- 02 Feb, 2009 2 commits
-
-
Max Kellermann authored
The shout_mp3 encoder had two bugs: when no song was ever played, MPD segfaulted during cleanup. Second bug: memory leak, each time the shout device was opened, lame_init() was called again, and lame_close() is only called once during shutdown. Fix this by shutting down LAME each time the clear_encoder() method is called.
-
Max Kellermann authored
When the output device fails to play a chunk, set pc.error to PLAYER_ERROR_AUDIO. This way, the playlist knows that it should not queue the next song.
-
- 30 Jan, 2009 4 commits
-
-
Matthias Drochner authored
Hi - independently of libmikmod's other problems - there seems to be a problem in mpd's wrapper: MikMod_Exit() is called after the first file is decoded, which frees some ressources within the mikmod library. An attempt to play a second file leads to a crash. The appended patch fixes this for me. (I don't know what the "dup" entry is good for - someone who knows should review that too.) best regards Matthias [mk: removed 3 more MikMod_Exit() invocations]
-
Max Kellermann authored
The wavpack library seems to use the .wvc stream even if the OPEN_WVC flag is not set. In this case, pass NULL to be sure libwavpack won't use it.
-
Max Kellermann authored
When the user configures a music_directory with a trailing slash, it may break playlist loading, because MPD expects a double slash. Chop off the trailing slash.
-
David Horn authored
ffmpeg_tag_internal() does not look for a few tags that mpd supports. Most noteably: comment -> TAG_ITEM_COMMENT -> Description genre -> TAG_ITEM_GENRE -> WM/Genre (not WM/GenreID) year -> TAG_ITEM_DATE -> WM/Year I *think* that this is the last of the tags that AVFormatContext() in ffmpeg supports that mpd also uses.
-
- 29 Jan, 2009 5 commits
-
-
Max Kellermann authored
This patch implements the MMS protocol, by using libmms. It is quite experimental: it does not support seeking yet, and it is currently using synchronous I/O, which causes MPD to hang while waiting for the server.
-
Max Kellermann authored
When waiting for free space in the ring buffer, the JACK plugin sleeped 10ms until there is enough space. This delay was too large for low-latency setups (<10ms), and created a lot of xruns. Work around that by reducing the sleep time to 1ms. A proper solution for this would be to use an event based approach, and we will do it, just not now.
-
Max Kellermann authored
When the connection failed once, you had to restart MPD, because it never cleared the jack_data.shutdown flag. Instead, it refused to play anything "because there is no client thread" (which is wrong at that point).
-
Max Kellermann authored
If the ring buffers are allocated after jack_activate(), mpd_jack_process() might segfault because it attempts to access them.
-
Avuton Olrich authored
-
- 24 Jan, 2009 1 commit
-
-
Max Kellermann authored
Added all important id tags from the MusicBrainz wiki: http://musicbrainz.org/doc/MusicBrainzTag This should automatically enable its suport in the vorbis and flac decoder plugins.
-
- 23 Jan, 2009 1 commit
-
-
Max Kellermann authored
When you delete a song from the playlist which was paused, MPD forgot that it was paused and started playing the next song.
-
- 22 Jan, 2009 3 commits
-
-
Max Kellermann authored
When the random mode is toggled, MPD did not clear the queue. Because of this, MPD continued with the next (random or non-random) song according to the previous mode. Clear the queued song to fix that.
-
Max Kellermann authored
The null plugin synchronizes the playback so it will happen in real time. This patch adds a configuration option which disables this: the playback will then be as fast as possible. This can be useful to profile MPD.
-
Max Kellermann authored
-
- 18 Jan, 2009 3 commits
-
-
Max Kellermann authored
Without a music_directory, MPD is an excellent streaming client.
-
Max Kellermann authored
-
Avuton Olrich authored
-
- 17 Jan, 2009 1 commit
-
-
Max Kellermann authored
When libvorbis knows that a song is seekable, it seeks around like crazy in the file before starting to decode it. This is very expensive on remote HTTP resources, and delays MPD for 10 or 20 seconds. This patch disables seeking on remote songs, because the advantages of quickly playing a song seem to weigh more than the theoretical ability of seeking for most MPD users. If users feel this feature is needed, we will make a configuration option for that.
-
- 16 Jan, 2009 1 commit
-
-
Max Kellermann authored
Due to rounding errors, it was possible that the fallback resampler returned partial frames.
-
- 15 Jan, 2009 4 commits
-
-
Max Kellermann authored
When tremor (libvorbisidec) is used, HAVE_OGGVORBIS was not defined.
-
Max Kellermann authored
Set the "ready" flag for empty resources.
-
Max Kellermann authored
To check for early connect failures, call curl_multi_info_read() in the constructor input_curl_open(). This fixes an assertion failure.
-
Max Kellermann authored
Copy changelog items from the upcoming 0.14.1 release.
-
- 14 Jan, 2009 1 commit
-
-
Max Kellermann authored
When a song file is deleted during database update, all pointers to it must be removed from the playlist. The "for" loop in deleteASongFromPlaylist() did not deal with multiple copies of the deleted song properly, and left instances of the (to-be-invalidated) pointer in. Fix this by reversing the loop.
-
- 13 Jan, 2009 1 commit
-
-
Joe Milbourn authored
If http_proxy_{host, port, user, password} are provided in mpd.conf they are not passed on to libcurl. As a result mpd cannot stream from behind an http proxy. The attached patch `http_proxy.patch` makes the relevant calls to curl_easy_setopt(...) for all proxy configuration parameters, but is only tested for host and port.
-
- 04 Jan, 2009 2 commits
-
-
Max Kellermann authored
Start the daemon after --create-db. This makes --create-db a flag which discards the old database and starts with a fresh one.
-
Max Kellermann authored
When the decoder of the new song is not fast enough, the player thread has to wait for it for a moment. However the variable "nextChunk" was reset to -1 during that, making the next loop iteration assume that cross-fading has not begun yet. This patch overwrites it with "0" while waiting.
-
- 03 Jan, 2009 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
This patch fixes a minor memory leak: when decoder_tag() attempted to send a merged tag object (created by tag_add_stream_tags()), and was interrupted by a decoder command, it did not free the temporary merged tag object.
-
Max Kellermann authored
If the state file cannot be read, for whatever reason, don't abort MPD. The state file isn't _that_ important.
-
- 01 Jan, 2009 1 commit
-
-
Max Kellermann authored
If no music_directory is configured, fall back to the XDG music directory, determined by g_get_user_special_dir(G_USER_DIRECTORY_MUSIC).
-
- 31 Dec, 2008 1 commit
-
-
Viliam Mateicka authored
-
- 28 Dec, 2008 3 commits
-
-
Max Kellermann authored
Allow logging to syslog if log_file is configured to "syslog".
-
Max Kellermann authored
Removed the "error_file" option. There is only one log file now. If a user wants to see only the errors, he should configure a log_level.
-
Avuton Olrich authored
-