1. 14 Nov, 2018 2 commits
    • Max Kellermann's avatar
      output/alsa: remove snd_pcm_state() check from DrainInternal() · 6c2a6a65
      Max Kellermann authored
      This check was added 9 years ago in commit
      4dc25d39 to work around a dmix bug
      which I assume has been fixed long ago.
      
      Removing this fixes another corner case: if draining is requested
      before the start threshold is reached, the PCM is still in
      SND_PCM_STATE_PREPARED but not yet SND_PCM_STATE_RUNNING, which means
      the submitted data will never be played.  This corner case is
      realistic when playing songs shorter than the ALSA buffer (if the
      buffer is very large).
      6c2a6a65
    • Max Kellermann's avatar
      output/alsa: call snd_pcm_prepare() if draining is requested early · 4247a757
      Max Kellermann authored
      This fixes a corner case which has probably never occurred and
      probably never will: if Cancel() is called, and then Play() followed
      by Drain(), the plugin should really play that data.  However
      currently, this never happens, because snd_pcm_prepare() is never
      called.
      4247a757
  2. 12 Nov, 2018 16 commits
  3. 11 Nov, 2018 5 commits
  4. 08 Nov, 2018 1 commit
    • Max Kellermann's avatar
      output/httpd: fix nullptr dereference crash bug · 583208db
      Max Kellermann authored
      When `metadata_sent` is `false`, the plugin assumes there is metadata
      which must be sent, even if no metadata page was passed to the plugin.
      Initializing it to `true` avoids dereferencing this `nullptr`.
      
      Fixes #412
      583208db
  5. 07 Nov, 2018 6 commits
  6. 06 Nov, 2018 4 commits
  7. 05 Nov, 2018 1 commit
  8. 04 Nov, 2018 5 commits