Skip to content

M
mpd
Switch branch/tag
  1. 01 Jan, 2008 1 commit
  3. 31 Dec, 2007 3 commits
  5. 28 Dec, 2007 1 commit
    • Eric Wong's avatar
      Merge branches/ew r7104 · b79f6b88
      Eric Wong authored 
      thread-safety work in preparation for rewrite to use pthreads

Expect no regressions against trunk (r7078), possibly minor
performance improvements in update (due to fewer heap
allocations), but increased stack usage.

Applied the following patches:

* maxpath_str for reentrancy (temporary fix, reverted)
* path: start working on thread-safe variants of these methods
* Re-entrancy work on path/character-set conversions
* directory.c: exploreDirectory() use reentrant functions here
* directory/update: more use of reentrant functions + cleanups
* string_toupper: a strdup-less version of strDupToUpper
* get_song_url: a static-variable-free version of getSongUrl()
* Use reentrant/thread-safe get_song_url everywhere
* replace rmp2amp with the reentrant version, rmp2amp_r
* Get rid of the non-reentrant/non-thread-safe rpp2app, too.
* buffer2array: assert strdup() returns a usable value in unit tests
* replace utf8ToFsCharset and fsCharsetToUtf8 with thread-safe variants
* fix storing playlists w/o absolute paths
* parent_path(), a reentrant version of parentPath()
* parentPath => parent_path for reentrancy and thread-safety
* allow "make test" to automatically run embedded unit tests
* remove convStrDup() and maxpath_str()
* use MPD_PATH_MAX everywhere instead of MAXPATHLEN
* path: get rid of appendSlash, pfx_path and just use pfx_dir
* get_song_url: fix the ability to play songs in the top-level music_directory

git-svn-id: https://svn.musicpd.org/mpd/trunk@7106 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      b79f6b88
  7. 27 Dec, 2007 1 commit
  9. 16 Dec, 2007 2 commits
  11. 10 Dec, 2007 1 commit
  13. 06 Dec, 2007 1 commit
  15. 28 Nov, 2007 2 commits
  17. 21 Nov, 2007 3 commits
  19. 18 Nov, 2007 1 commit
  21. 16 Nov, 2007 1 commit
  23. 03 Oct, 2007 1 commit
  25. 26 Sep, 2007 1 commit
  27. 17 Sep, 2007 1 commit
  29. 14 Sep, 2007 1 commit
  31. 10 Sep, 2007 3 commits
  33. 08 Sep, 2007 2 commits
  35. 07 Sep, 2007 2 commits
  37. 06 Sep, 2007 3 commits
  39. 05 Sep, 2007 3 commits
  41. 04 Sep, 2007 2 commits
  43. 02 Sep, 2007 2 commits
    • Eric Wong's avatar
      zeroconf: avoid passing NULLs to Avahi *_free() routines · 203a5ed2
      Eric Wong authored 
      This should fix Debian bug #428551
(mpd crashes when restarting the dbus daemon)

git-svn-id: https://svn.musicpd.org/mpd/trunk@6844 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      203a5ed2
    • Eric Wong's avatar
      Fix endless loop when mpd is launched from a non-interactive shell. · bbe8b0ef
      Eric Wong authored 
      Thanks to _noth_ for the patch, this fixes Mantis bug #1534

_noth_ wrote:
> When MPD is launched from a non-interactive shell, it enters an endless
> loop, filling up its error log file with "error accept()'ing" messages.
> This is caused by the fact that stdin is already closed when mpd starts
> up.  listenOnPort() opens up the first of its sockets as fd 0 (the first
> empty fd table position). Then, setup_log_output()->redirect_stdin()
> overwrites fd0 (fd=open("/dev/null",...); dup2(fd, STDIN_FILENO);)
> without checking if it corresponds to the actual standard input (or if
> it is open in the first place).  This means that listenSockets[0].fd now
> is a fd for /dev/null, thus doIOForInterfaces()->getConnections() can't
> accept(2) on it and fails with the above error. The attached patch fixes
> this for me.

git-svn-id: https://svn.musicpd.org/mpd/trunk@6843 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      bbe8b0ef
  45. 01 Sep, 2007 1 commit
  47. 28 Aug, 2007 1 commit