Skip to content

M
mpd
Switch branch/tag
  1. 07 Nov, 2008 1 commit
    • Tom Servo's avatar
      listen: fix namespace collision on OpenSolaris · ea925762
      Tom Servo authored 
      The listen.c module breaks the build because the variable name used
("sun") for the Unix domain socket part collides with something else
on an OpenSolaris system, likely Sun specific.  Renaming it to _sun
(or something else of choice) fixes the build.

[mk: renamed to "s_un"]
      ea925762
  3. 30 Oct, 2008 1 commit
    • Max Kellermann's avatar
      listen: set file mode 666 on the unix socket · 4d72bda4
      Max Kellermann authored 
      Depending on MPD's umask, the file permissions of the unix socket were
too restrictive, and many clients were not able to connect.  Do a
chmod(0666) on the socket, to allow everybody to connect.
      4d72bda4
  5. 18 Oct, 2008 1 commit
  7. 17 Oct, 2008 1 commit
  9. 16 Oct, 2008 1 commit
  11. 15 Oct, 2008 3 commits
  13. 28 Aug, 2008 2 commits
    • Max Kellermann's avatar
      client: renamed all public functions · c0197c58
      Max Kellermann authored 
      Functions which operate on the whole client list are prefixed with
"client_manager_", and functions which handle just one client just get
"client_".
      c0197c58
    • Max Kellermann's avatar
      renamed interface.c to client.c · deb29e08
      Max Kellermann authored 
      I don't believe "interface" is a good name for something like
"connection by a client to MPD", let's call it "client".  This is the
first patch in the series which changes the name, beginning with the
file name.
      deb29e08
  15. 12 Apr, 2008 7 commits
  17. 26 Mar, 2008 1 commit
    • Eric Wong's avatar
      notify: cleanups · 232c9f6c
      Eric Wong authored 
      * move set_nonblock{,ing}() into utils.c since we use it
elsewhere, too
* add proper error checking to set_nonblocking()
* use os_compat.h instead of individually #includ-ing system headers

git-svn-id: https://svn.musicpd.org/mpd/trunk@7217 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      232c9f6c
  19. 05 Feb, 2008 1 commit
  21. 03 Jan, 2008 1 commit
    • Eric Wong's avatar
      Cleanup #includes of standard system headers and put them in one place · cb8f1af3
      Eric Wong authored 
      This will make refactoring features easier, especially now that
pthreads support and larger refactorings are on the horizon.

Hopefully, this will make porting to other platforms (even
non-UNIX-like ones for masochists) easier, too.

os_compat.h will house all the #includes for system headers
considered to be the "core" of MPD.  Headers for optional
features will be left to individual source files.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7130 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      cb8f1af3
  23. 05 Sep, 2007 1 commit
  25. 27 Aug, 2007 1 commit
    • Eric Wong's avatar
      export FATAL() with noreturn attribute · 0f2e9ee6
      Eric Wong authored 
      This attribute was set in log.c, but not exported to other
modules in log.h

This allows us to remove some unneccessary variable
initializations that were added in r6277.  I did
audioOutput_shout.c a bit differently, to avoid some
jumps.

before:
$ size src/mpd
text    data     bss     dec     hex filename
225546    4040   14600  244186   3b9da src/mpd

after:
$ size src/mpd
text    data     bss     dec     hex filename
224698    4040   14600  243338   3b68a src/mpd

git-svn-id: https://svn.musicpd.org/mpd/trunk@6821 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      0f2e9ee6
  27. 01 Jun, 2007 1 commit
  29. 26 May, 2007 2 commits
  31. 05 Apr, 2007 1 commit
  33. 28 Feb, 2007 1 commit
  35. 14 Jan, 2007 2 commits
  37. 11 Jan, 2007 1 commit
  39. 26 Aug, 2006 1 commit
    • Eric Wong's avatar
      Replace strdup and {c,re,m}alloc with x* variants to check for OOM errors · 90847fc8
      Eric Wong authored 
      I'm checking for zero-size allocations and assert()-ing them,
so we can more easily get backtraces and debug problems, but we'll
also allow -DNDEBUG people to live on the edge if they wish.

We do not rely on errno when checking for OOM errors because
some implementations of malloc do not set it, and malloc
is commonly overridden by userspace wrappers.

I've spent some time looking through the source and didn't find any
obvious places where we would explicitly allocate 0 bytes, so we
shouldn't trip any of those assertions.

We also avoid allocating zero bytes because C libraries don't
handle this consistently (some return NULL, some not); and it's
dangerous either way.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4690 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      90847fc8
  41. 01 Aug, 2006 1 commit
  43. 22 Jul, 2006 2 commits
  45. 20 Jul, 2006 1 commit
  47. 19 Jul, 2006 1 commit
  49. 17 Jul, 2006 1 commit
    • Eric Wong's avatar
      sparse: ANSI-fy function declarations · a234780a
      Eric Wong authored 
      These are just warnings from sparse, but it makes the output
easier to read.  I ran this through a quick perl script, but
of course verified the output by looking at the diff and making
sure the thing still compiles.

here's the quick perl script I wrote to generate this patch:
----------- 8< -----------
use Tie::File;
defined(my $pid = open my $fh, '-|') or die $!;
if (!$pid) {
open STDERR, '>&STDOUT' or die $!;
exec 'sparse', @ARGV or die $!;
}
my $na = 'warning: non-ANSI function declaration of function';
while (<$fh>) {
print STDERR $_;
if (/^(.+?\.[ch]):(\d+):(\d+): $na '(\w+)'/o) {
my ($f, $l, $pos, $func) = ($1, $2, $3, $4);
$l--;
tie my @x, 'Tie::File', $f or die "$!: $f";
print '-', $x[$l], "\n";
$x[$l] =~ s/\b($func\s*)\(\s*\)/$1(void)/;
print '+', $x[$l], "\n";
untie @x;
}
}

git-svn-id: https://svn.musicpd.org/mpd/trunk@4378 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      a234780a
  51. 14 Jul, 2006 2 commits
  53. 13 Jul, 2006 1 commit