To make things simpler, AllocatedString is now a non-template class.

To make things simpler, AllocatedString is now a non-template class.

The ones in std have overloads for const char/char.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Fixes Path::IsNull() checks on Windows.

Reduce I/O overhead.

Reduce I/O overhead.

Move code from ParseCommandLine().

Reduces I/O overhead while reading a compressed database file.

The entire section falls under the else path of #ifdef _WIN32. Checking
for it makes no sense. Probably some refactoring mistake.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with modernize-use-default-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com>

[[maybe_unused]] (introduced in C++17) is standard C++.

https://clang.llvm.org/docs/AttributeReference.html#maybe-unused-unused
says that this is equivalent to the GNU unused attribute.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

The former is deprecated by C++14. The standard says they are the same:

The header defines all types and macros the same as the C standard library
header<stdint.h>.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

The former is deprecated with C++14. The standard says both are the same:

The contents and meaning of the header<cstddef>are the same as the C
standard library header<stddef.h>,except that it does not declare the type
wchar_t, that it also declares the type byte and its associated
operations (21.2.5), and as noted in 21.2.3 and 21.2.4.
Signed-off-by: Rosen Penev <rosenp@gmail.com>