- 04 Mar, 2021 8 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Replaces the static Duplicate() method.
-
Max Kellermann authored
-
Max Kellermann authored
To make things simpler, AllocatedString is now a non-template class.
-
Érico Rolim authored
Per the manual for strptime, %F is equivalent %Y-%m-%d, so use that directly.
-
Érico Rolim authored
ParseTimePoint. %Z is a glibc extension to strptime, and is a no-op there, due to the mapping between timezone names and their definition (especially when the name comes from a different machine) being ambiguous / impossible. Time in HTTP headers is guaranteed to be UTC. Passing an unknown format to strptime() implementations that don't support it will generally cause them to return NULL, which will lead to ParseTimePoint throwing an exception and ParseTimeStamp using an unnecessary fallback. Since the timezone name goes at the end of the string, we don't need to use %Z to skip it (could be an issue in a different time stamp format), so simply removing %Z works best.
-
- 25 Feb, 2021 1 commit
-
-
Max Kellermann authored
Closes https://github.com/MusicPlayerDaemon/MPD/issues/1112
-
- 22 Feb, 2021 2 commits
-
-
Max Kellermann authored
Regression by commit a22d1c88 Closes https://github.com/MusicPlayerDaemon/MPD/issues/1097
-
Max Kellermann authored
-
- 17 Feb, 2021 2 commits
-
-
Max Kellermann authored
-
Florian Schlichting authored
Exmaple -> Example
-
- 16 Feb, 2021 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
If the constructor moves from an ExportedSong instance which refers to somebody else's "Tag" instance, the newly constructed instance will instead refer to its own empty "tag_buffer" field. This broke SimpleDatabase::GetSong(), i.e. all songs on the queue restored from the state file or added using the "addid" command. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1089
-
Max Kellermann authored
-
- 15 Feb, 2021 20 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Needed for `requestLegacyExternalStorage` (commit ca02fb77).
-
Max Kellermann authored
The "move" command doesn't allow open-ended ranges because they don't make a lot of sense; moving an open-ended range is only possible if the destination index is before the range, and in that case, the client should be well aware how many songs there are. Closes https://github.com/MusicPlayerDaemon/MPD/pull/1057
-
Max Kellermann authored
Catch errors like that early, before invalid ranges get passed to internal MPD subsystems.
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Shen-Ta Hsieh authored
-
Shen-Ta Hsieh authored
-
Shen-Ta Hsieh authored
-
Max Kellermann authored
This is a workaround for the new scoped storage design in Android 11: https://developer.android.com/about/versions/11/privacy/storage This needs a proper solution eventually, but this quick fix will do until we change "targetSdkVersion" to 30. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1061
-
Max Kellermann authored
After commit 1afa33c3, an old bug was revealed: SimpleDatabase::GetSong() constructs an ExportedSong instance by moving the return value of Song::Export(), which causes the LightSong::tag field to be dangling on the moved-from ExportedSong::tag_buffer. This broke tags from CUE sheets. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1070
-
Max Kellermann authored
Keep track of whether there is data being played, and don't call AudioOutput::Drain() after Cancel() has been called already.
-
Max Kellermann authored
In this state, we can't make any progress. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1084
-
Max Kellermann authored
Drain only if it was requested explicitly.
-
Max Kellermann authored
It is useless, because we're always checking pa_stream_is_corked().
-
Max Kellermann authored
-
Max Kellermann authored
Closes https://github.com/MusicPlayerDaemon/MPD/issues/1022
-
- 07 Feb, 2021 4 commits
-
-
Max Kellermann authored
Closes https://github.com/MusicPlayerDaemon/MPD/issues/1031
-
Max Kellermann authored
Commit 79b23663 added the field `skip` to support unaligned reads, but set the `offset` field to a wrong value. This resulted in miscalculation of `remaining`, causing an assertion failure. The fix is to assign `offset` the correct value, but consider the `skip` value in the assertion. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1067
-
Max Kellermann authored
After a Seek() to an odd offset, some data needs to be skipped from the start of the block, and reading right into the given buffer doesn't work.
-
Max Kellermann authored
-