- 21 Jan, 2009 9 commits
-
-
Max Kellermann authored
The function player_seek_decoder() starts the decoder, but does not check the return value of player_wait_for_decoder().
-
Max Kellermann authored
Make player_wait_for_decoder() and play_chunk() return a bool instead of 0/-1.
-
Max Kellermann authored
Don't attempt to restart the player if it was stopped, but there were still songs left on the playlist. This looks like it has been a workaround for a bug which has been fixed long time ago.
-
Max Kellermann authored
Don't assign the result of getPlayerError() to an integer.
-
Max Kellermann authored
Use g_free() consistently with g_malloc(). Don't clear the pointers after freeing them.
-
Max Kellermann authored
The player_thread loop requests the next song from the playlist as soon as the decoder finishes the song which is currently being played. This is superfluous, and can lead to synchronization errors and wrong results. The playlist already knows when the player starts playing the next song (player_wait_for_decoder() triggers the PLAYLIST event), and will then trigger the scheduler to provide the next song.
-
Max Kellermann authored
Simplify some code by using config_get_positive(), instead of doing manual parsing and validation each time.
-
Max Kellermann authored
This convenience function parses a configuration value into a positive integer. It aborts if parsing fails.
-
Viliam Mateicka authored
-
- 20 Jan, 2009 3 commits
-
-
Max Kellermann authored
player_wait_for_decoder() emits the PLAYLIST event on success, remove the duplicate PLAYLIST event in its caller.
-
Max Kellermann authored
The "TAG" event is emitted by the player thread when the current song's tag has changed. Split this event from "PLAYLIST" and make it a separate callback, which is more efficient.
-
Qball Cow authored
-
- 19 Jan, 2009 6 commits
-
-
Rasmus Steinke authored
-
Max Kellermann authored
The "sticker" command allows clients to query or manipulate the sticker database. This patch implements the sub-commands "get" and "set"; more will follow soon (enumeration), as well as extended "lsinfo" / "playlistinfo" versions.
-
Max Kellermann authored
When a song is deleted from the database, remove its sticker, too. What's still missing is some sort of garbage collector after a fresh database create (--create-db).
-
Max Kellermann authored
This is a wrapper for the backend sticker library. It provides several glue functions which take a song object instead of type/uri.
-
Max Kellermann authored
"Stickers" are pieces of information attached to existing MPD objects (e.g. song files, directories, albums). Clients can create arbitrary name/value pairs. MPD itself does not assume any special meaning in them.
-
Max Kellermann authored
The plugin queries build-time configuration variables, and should include config.h.
-
- 18 Jan, 2009 22 commits
-
-
Max Kellermann authored
Minimize header dependencies.
-
Max Kellermann authored
Eliminate some more getBlockParam() invocations.
-
Max Kellermann authored
This replaces lots of getBlockParam() invocations.
-
Max Kellermann authored
Don't modify the configured string.
-
Max Kellermann authored
Determine the audio output name with audio_output_get_name() instead of obtaining the name from the configuration again.
-
Max Kellermann authored
Use config_get_path() instead in mapper.c.
-
Max Kellermann authored
The g_free() function includes a NULL check. We don't have to do it twice.
-
Max Kellermann authored
This causes a segmentation fault...
-
Max Kellermann authored
This way, we don't have to pass the full "Options" object to daemonize().
-
Max Kellermann authored
The constructor/destructor functions parse and free the configuration properly. This way, we don't have to load the pid file path more than once.
-
Max Kellermann authored
The state_file library should manage its own regular saves.
-
Max Kellermann authored
The constructor/destructor interface should hide the functions read_state_file() and write_state_file().
-
Max Kellermann authored
-
Max Kellermann authored
config_get_path() is an simpler interface than parseConfigFilePath().
-
Max Kellermann authored
Fetch the configuration variables buffered_chunks and buffered_before_play just when they are needed.
-
Max Kellermann authored
Moved changeToUser(), cleanUpPidFile(), killFromPidFile() to daemon.c. These are daemonization functions.
-
Max Kellermann authored
Without a music_directory, MPD is an excellent streaming client.
-
Max Kellermann authored
-
Max Kellermann authored
Don't include conf.h in database.c.
-
Max Kellermann authored
time(NULL) shows the wrong results when the machine's clock is changed.
-
Max Kellermann authored
Don't use dbUtils.h functions. This reduces 4 full database walks to just one.
-
Max Kellermann authored
Don't recalculate the number of artists and albums each time a client requests statistics. Calculate that once in stats_update().
-