- 11 Nov, 2008 2 commits
-
-
Max Kellermann authored
Renamed functions and variables.
-
Max Kellermann authored
The assertion on dc.state in decoder_read() was too strict: when a decoder tried to call decoder_read() from tag_dup(), the decoder state was NONE. Allow this special case.
-
- 10 Nov, 2008 1 commit
-
-
Max Kellermann authored
Added a lot of assertions checking the state of the decoder plugin.
-
- 03 Nov, 2008 4 commits
-
-
Max Kellermann authored
Renamed variables and functions.
-
Max Kellermann authored
Before passing the first chunk to the audio output device, send the current song's tag.
-
Max Kellermann authored
If an input stream provides tags (e.g. from an icecast server), send them in the decoder_data() and decoder_tag() methods. Removed the according code from the mp3 and oggvorbis plugins - decoders shouldn't have to care about stream tags. This patch also adds the missing decoder_tag() invocation to the mp3 plugin.
-
Max Kellermann authored
Renamed variables.
-
- 02 Nov, 2008 5 commits
-
-
Max Kellermann authored
Provide an API for submitting additional tags from the stream.
-
Max Kellermann authored
Don't pass the "seekable" flag with every decoder_data() invocation. Since that flag won't change within the file, it is enough to pass it to decoder_initialized() once per file.
-
Max Kellermann authored
.. and rename dc.audioFormat to dc.in_audio_format. The music pipe does not need to know the audio format, and its former "audioFormat" property indicated the format of the most recently added chunk, which might be confusing when you are reading the oldest chunks.
-
Max Kellermann authored
Rename all functions to the new prefix.
-
Max Kellermann authored
No CamelCase in the file name. The output_buffer struct is going to be renamed to music_pipe. There are so many buffer levels in MPD, and calling this one "output buffer" is wrong, because it's not the last buffer before the music reaches the output devices.
-
- 01 Nov, 2008 1 commit
-
-
Max Kellermann authored
Currently, there is no way to dynamically load decoder plugins, thus we don't need a dynamic list to manage them.
-
- 30 Oct, 2008 1 commit
-
-
Max Kellermann authored
Don't return 0/-1 on success/error, but true/false. Instead of int, use bool for storing flags.
-
- 29 Oct, 2008 4 commits
-
-
Max Kellermann authored
A decoder_flush() invocation was missing in the FLAC plugin, resulting in casual assertion failures due to a wrong assumption about the last chunk's audio format. It's much easier to remove that decoder_flush() function and make the decoder thread call ob_flush().
-
Max Kellermann authored
There are no callers which pass audio_format==NULL, and it shouldn't be allowed.
-
Max Kellermann authored
Call ob_clear() in decoder_command_finished() instead of implementing that call in every decoder plugin.
-
Max Kellermann authored
need_chunks() returns a decoder_command enum. Store its return value as this type.
-
- 26 Oct, 2008 1 commit
-
-
Max Kellermann authored
Renamed all functions and variables.
-
- 21 Oct, 2008 2 commits
-
-
Max Kellermann authored
Instead of manually calling memset(0) on the pcm_convert_state struct, client code should use a library function from pcm_utils.c. This way, we can change the semantics of the struct easily.
-
Max Kellermann authored
Renamed all functions which were still in CamelCase.
-
- 17 Oct, 2008 2 commits
-
-
Max Kellermann authored
The nmemb argument isn't actually useful, and one of nmemb and size was always passed as 1. Remove it.
-
Max Kellermann authored
Provide a struct type which can be forward-declared. The typedef InputStream is deprecated now.
-
- 08 Oct, 2008 4 commits
-
-
Max Kellermann authored
CamelCase is ugly... rename all functions.
-
Max Kellermann authored
"bool" should be used in C99 programs for boolean values.
-
Max Kellermann authored
When there are standardized headers, use these instead of the bloated os_compat.h.
-
Max Kellermann authored
Again, a data type which can be forward-declared.
-
- 29 Sep, 2008 1 commit
-
-
Max Kellermann authored
Do full C99 integer type conversion in all modules which were not touched by Eric's merged patch.
-
- 09 Sep, 2008 1 commit
-
-
Max Kellermann authored
Rename it to audio_format_equals() and return "true" if they are equal.
-
- 07 Sep, 2008 1 commit
-
-
Max Kellermann authored
Get rid of CamelCase, and don't use a typedef, so we can forward-declare it, and unclutter the include dependencies.
-
- 26 Aug, 2008 10 commits
-
-
Max Kellermann authored
Give player.c a better name, meaning that the code is used to control the player thread.
-
Max Kellermann authored
-
Max Kellermann authored
This is the last of the three variables. Now we don't need playerData.h anymore in most sources.
-
Max Kellermann authored
This releases several include file dependencies. As a side effect, "CHUNK_SIZE" isn't defined by decoder_api.h anymore, so we have to define it directly in the plugins which need it. It just isn't worth it to add it to the decoder plugin API.
-
Max Kellermann authored
Now that "dc" is available here, we don't have to pass it to decoder_is_idle() and decoder_is_starting() anymore.
-
Max Kellermann authored
This flag is used internally; it is set by decoder_seek_where(), and indicates that the decoder plugin has begun the seek process. It is used for the case that the decoder plugin has to read data during the seek process. Before this patch, that was impossible, because decoder_read() would refuse to read data unless dc->command is NONE. This patch is kind of a dirty workaround, and needs to be redesigned later.
-
Max Kellermann authored
On our way to stabilize the decoder API, we will one day remove the input stream functions. The most basic function, read() will be provided by decoder_api.h with this patch. It already contains a loop (still with manual polling), error/eof handling and decoder command checks. This kind of code used to be duplicated in all decoder plugins.
-
Max Kellermann authored
With the functions decoder_plugin_register() and decoder_plugin_unregister(), decoder plugins can register a "secondary" plugin, like the flac input plugin does this for "oggflac".
-
Max Kellermann authored
(Ab)use the decoder_command enumeration, which has nearly the same values and the same meaning.
-
Max Kellermann authored
The wavpack decoder plugin implements a hack, and it needs the song URL for that. This API (and the hack) should be revised later, but add that function for now.
-