- 17 Dec, 2008 1 commit
-
-
Max Kellermann authored
When a (remote) song is deleted from the playlist, there may still be a reference to it in pc.errored_song. Clear this reference.
-
- 16 Dec, 2008 1 commit
-
-
Max Kellermann authored
The function didn't do anything useful, it was just several lines obfuscating that it was only forwarding isRemoteUrl()'s return value.
-
- 12 Nov, 2008 1 commit
-
-
Max Kellermann authored
This patch extends commit 35a16b99, and amends several 2 missing checks. It simplifies 2 more checks by merging "if" conditions.
-
- 11 Nov, 2008 1 commit
-
-
Max Kellermann authored
When the tag of the current song changes (e.g. a new tag was sent in the stream), update the playlist, so clients pick up the new tag.
-
- 31 Oct, 2008 1 commit
-
-
Max Kellermann authored
Added the function map_spl_utf8_to_fs() which replaces utf8_to_fs_playlist_path().
-
- 28 Oct, 2008 1 commit
-
-
Max Kellermann authored
Remove duplicated code from MPD.
-
- 23 Oct, 2008 3 commits
-
-
Max Kellermann authored
The function deletePlaylist() shouldn't be in playlist.c.
-
Max Kellermann authored
Don't use our deprecated linked list library, use GLib's GPtrArray instead.
-
Max Kellermann authored
There are some integers which have a "magic" -1 value which means "undefined" or "nothing". All others can be converted to unsigned, since they must not contain a negative number.
-
- 22 Oct, 2008 3 commits
-
-
Max Kellermann authored
The two functions clearStoredPlaylist() and addToStoredPlaylist() don't belong into playlist.c. clearStoredPlaylist() was a wrapper for spl_clear(), and is converted into a CPP macro for now.
-
Max Kellermann authored
Renamed all public functions, prefix is "spl_".
-
Max Kellermann authored
No CamelCase in file names.
-
- 15 Oct, 2008 5 commits
-
-
Max Kellermann authored
Allow a local user to not only add his own files, but also all world-readable files (mode 0444).
-
Max Kellermann authored
Clients which have authenticated via unix socket may add local files to the MPD playlist, provided that they own the file.
-
Max Kellermann authored
Replace some complicated checks from addToPlaylist() to the simpler function song_by_url().
-
Max Kellermann authored
Some functions assume that a song is not in the database when it is a remote song. Based on that, they decide whether they are responsible for freeing the song struct. Add a special function which checks whether a song is in the database (currently equal to song_is_file()).
-
Max Kellermann authored
string_toupper() and strDupToUpper() were not able to deal with character sets other than US-ASCII. Use GLib's g_utf8_casefold() for strings.
-
- 14 Oct, 2008 3 commits
-
-
Max Kellermann authored
"idle" waits until something noteworthy happens on the server, e.g. song change, playlist modified, database updated. This allows clients to keep up to date without polling.
-
Max Kellermann authored
The mapper library maps directory and song objects to file system paths. With this central library, the code mixture in path.c should be cleaned up, and we will be able to add neat features like aliasing.
-
Max Kellermann authored
playlist_print_song() and playlist_print_uri() handle charset conversion and (optional) music directory prefixing.
-
- 13 Oct, 2008 1 commit
-
-
Max Kellermann authored
The only caller of deletePlaylist() appends PLAYLIST_FILE_SUFFIX, so we can be sure it's already there. We don't need to stat the file, since unlink() does all the checking.
-
- 11 Oct, 2008 2 commits
-
-
Max Kellermann authored
QUEUE adds a new song to the player's queue. CANCEL clears the queue. These two commands replace the old and complex queueState and queueLockState code.
-
Max Kellermann authored
Simplify and merge several if clauses before the clearPlayerQueue() invocation. Call clearPlayerQueue() only if a song is actually queued; add an assertion for that in clearPlayerQueue().
-
- 09 Oct, 2008 1 commit
-
-
Max Kellermann authored
Search'n'replace typo..
-
- 08 Oct, 2008 7 commits
-
-
Max Kellermann authored
Yet another CamelCase removal patch.
-
Max Kellermann authored
Taming the directory.c monster, part II: move the database management stuff to database. directory.c should only contain code which works on directory objects.
-
Max Kellermann authored
CamelCase is ugly... rename all functions.
-
Max Kellermann authored
Provide separate constructors for creating a remote song, a local song, and one for loading data from a song file. This way, we can add more assertions.
-
Max Kellermann authored
Check the old status before assigning. This saves a temporary variable.
-
Max Kellermann authored
"bool" should be used in C99 programs for boolean values.
-
Max Kellermann authored
Again, a data type which can be forward-declared.
-
- 07 Oct, 2008 1 commit
-
-
Eric Wong authored
This make argument order more consistent for iterators. Additionally, these now return ssize_t results for error checking.
-
- 06 Oct, 2008 1 commit
-
-
Eric Wong authored
We already know if a song is a URL or not based on whether it has parentDir defined or not. Hopefully one day in the future we can drop HTTP support from MPD entirely when an HTTP filesystem comes along and we can access streams via open(2).
-
- 29 Sep, 2008 2 commits
-
-
Max Kellermann authored
Do full C99 integer type conversion in all modules which were not touched by Eric's merged patch.
-
Eric Wong authored
We don't change the song pointer there, either.
-
- 23 Sep, 2008 1 commit
-
-
Eric Wong authored
LOC reduction and less noise makes things easier for tired old folks to follow.
-
- 07 Sep, 2008 4 commits
-
-
Max Kellermann authored
Since all callers of song_id_exists() will map it to a song position after the check, introduce a new function called song_id_to_position() which performs both the check and the map lookup, including nice assertions.
-
Max Kellermann authored
Pass the client struct instead of the raw file descriptor.
-
Max Kellermann authored
The shared code in showPlaylist() isn't worth it, because we aim to remove fdprintf(). Duplicate this small function, and enable stdio buffering for saved playlists.
-
Max Kellermann authored
The function loadPlaylist() wants to report incremental errors to the client, for this reason we cannot remove its protocol dependency right now. Instead, make it use the client struct instead of the raw file descriptor.
-