1. 23 Dec, 2019 1 commit
  2. 03 Aug, 2019 1 commit
    • Max Kellermann's avatar
      player/Thread: don't restart unseekable song after failed seek attempt · f2d8fd76
      Max Kellermann authored
      The check IsSeekableCurrentSong() was added by commit
      44b20024 in version 0.20.19, but it
      caused a regression: by doing the branch only if the current song is
      seekable, the player would restart the current song if it was not
      seekable, and later the initial seek would fail; but we already know
      it's not seekable, and so we should fail early.
      f2d8fd76
  3. 31 May, 2019 1 commit
    • Max Kellermann's avatar
      Revert "player/Thread: remove unnecessary "pipe" check" · 304d45b5
      Max Kellermann authored
      This reverts commit ff3e2c05.  The
      check was necessary, after all, because this is what checked whether
      the decoder had finished the current or the next song.
      
      > The "queued" flag can only possibly be set if the decoder is still
      > decoding the current song or if the decoder is stopped.
      
      That was wrong because ProcessCommand() sets `queued=true` and also
      starts the decoder (if it was idle).
      
      > This is also what the following assert() checks.
      
      That was also wrong, because the assert() has two conditions.
      
      Closes https://github.com/MusicPlayerDaemon/MPD/issues/566
      304d45b5
  4. 20 May, 2019 2 commits
    • Max Kellermann's avatar
      player/Thread: fix "single" mode race condition · 923e6673
      Max Kellermann authored
      If the decoder finishes decoding the current song between the two
      IsIdle() checks, MPD stops playback instead of starting the decoder
      for the next song.
      
      This is usually not visible problem, because the main thread restarts
      it via playlist::ResumePlayback(), but that way it, ignores "single"
      mode.
      
      As a workaround, this commit adds another "queued" check which
      re-enters the player loop and checks again whether to start the
      decoder.
      
      Closes https://github.com/MusicPlayerDaemon/MPD/issues/556
      923e6673
    • Max Kellermann's avatar
      player/Thread: remove unnecessary "pipe" check · ff3e2c05
      Max Kellermann authored
      The "queued" flag can only possibly be set if the decoder is still
      decoding the current song or if the decoder is stopped.  This is also
      what the following assert() checks.  This check was not necessary.
      ff3e2c05
  5. 19 Nov, 2018 1 commit
    • Max Kellermann's avatar
      check.h: remove obsolete header · ce49d99c
      Max Kellermann authored
      Since we switched from autotools to Meson in commit
      94592c14, we don't need to include
      `config.h` early to properly enable large file support.  Meson passes
      the required macros on the compiler command line instead of defining
      them in `config.h`.
      
      This means we can include `config.h` at any time, whenever we want to
      check its macros, and there are no ordering constraints.
      ce49d99c
  6. 12 Nov, 2018 1 commit
  7. 06 Nov, 2018 1 commit
  8. 31 Oct, 2018 1 commit
  9. 29 Oct, 2018 1 commit
  10. 23 Sep, 2018 9 commits
  11. 22 Sep, 2018 4 commits
  12. 21 Sep, 2018 11 commits
  13. 20 Aug, 2018 1 commit
  14. 02 Aug, 2018 1 commit
  15. 23 Jun, 2018 3 commits
  16. 22 Jun, 2018 1 commit