- 20 Aug, 2018 1 commit
-
-
Max Kellermann authored
-
- 19 Aug, 2018 2 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
- 18 Aug, 2018 1 commit
-
-
Max Kellermann authored
Eliminate a use of GetGlobalConfig().
-
- 07 Aug, 2018 2 commits
-
-
1848 authored
-
Yue Wang authored
the most notable bugs are 1. osx_output_set_device_format should use the target asbd rather than AudioFormat. This is because asbd's sample rate calculation reflects the real dop target rate of the DAC, white AudioFormat's sample rate is the original DSD format rate. 2. the original code value the highest rate that's the multiple of the target rate. This cause DOP always have the wrong rate chosen. This is also not necessary for PCM playback --- MPD's goal is bit perfect, and it's meaningless to raise to two or four times the PCM sample rate. 3. if sample_rate cannot be synchronized, the test for falling back to PCM is wrong. If the file format is in DSD format such fallback is necessary, whatever the params.dop setting is.
-
- 28 Jul, 2018 1 commit
-
-
Yue Wang authored
the code here tried to guard DSD features behind ENABLE_DSD. However, the sample rate setting should be shared between two scenarios. https://github.com/MusicPlayerDaemon/MPD/commit/40a1ebee295c569521ea17ffdedc641d1aedd9cb#diff-ce7ecec9ea9ca3df90d9c290cb3ef9d4R795 The code runs fine if the dac supports the sample rate, as Mac OS will use the device rate if stream rate is 0. However, when DAC is uncapable of processing the sample rate, a wrong rate (device rate) will be used for the stream rate.
-
- 18 Jul, 2018 1 commit
-
-
Max Kellermann authored
-
- 17 Jul, 2018 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
This fixes an old bug which caused the "unused" warnings to be unreliable; only the first block in the list was marked as being "used", no matter if it was really used, and the rest was never marked as "used", suppressing all warnings for them.
-
- 16 Jul, 2018 4 commits
-
-
Max Kellermann authored
-
Yue Wang authored
-
Max Kellermann authored
This is just the API design; there is no implementation yet, and no caller.
-
Max Kellermann authored
This method was added in Boost 1.58.
-
- 14 Jul, 2018 1 commit
-
-
Yue Wang authored
some device seems to have issue with setting kAudioDevicePropertyVolumeScalar with kAudioObjectPropertyElementMaster. Use AudioToolbox 's kAudioHardwareServiceDeviceProperty_VirtualMasterVolume instead. Ideally, we should get the steoro channels first, and set the kAudioDevicePropertyVolumeScalar for each channel, which is doable as presented in https://github.com/cmus/cmus/blob/master/op/coreaudio.c. I will do a follow up PR after refactor PR.
-
- 13 Jul, 2018 6 commits
-
-
Yue Wang authored
-
Yue Wang authored
1 sec for pause is too long. we wait for the same amount of time as when ring buffer is not available for writing.
-
Yue Wang authored
-
Yue Wang authored
-
Yue Wang authored
-
Yue Wang authored
This PR will fix #271. special thanks to @coroner21 who contributed a nice way to score hardware supported format in #292 Also, The DSD related code are all guarded with ENABLE_DSD flag.
-
- 10 Jul, 2018 1 commit
-
-
Yue Wang authored
- Update the mixer to set on device property instead of audio unit property. When user choose "hardware" as mixer type, they will be able to change the hardware device volume instead of the software (AudioUnit) volume. - We don't use square root scale in volume calculation as previous code did. This will make the volume level in line with system volume meter --- That is, MPD will have the same percentage volume reading compared to System Setting (Either in "System Preference" or in "Audio Midi Setup" app)
-
- 06 Jul, 2018 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
This code was added in 21851c06 but looks completely broken: - the status code is "206 OK" but "206" would be "Partial Content" - the "Content-Length" header has a bogus value - the "Content-RangeX" parameter has different bogus values (why "Content-RangeX" anyway and not "Content-Range"?) Apart from that, there are strange undocumented non-standard headers which are probably there to work around bugs/expectations in one broken proprietary client product. But these days, MPD doesn't bend over to support broken clients. So let's kill this code. Closes #304
-
- 23 Jun, 2018 8 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
AudioOutputControl::WaitForCommand() doesn't need this check.
-
Max Kellermann authored
-
Max Kellermann authored
Prepare for adding another Cond attribute.
-
Max Kellermann authored
-
Max Kellermann authored
This requires re-adding the reference to struct DecoderControl, which was removed recently by commit 9f14e7a9
-
Max Kellermann authored
-
Max Kellermann authored
-
- 22 Jun, 2018 4 commits
-
-
Max Kellermann authored
Make all uses of MusicChunk safe.
-
Max Kellermann authored
We can implement this now that we have a MusicBuffer reference.
-
Max Kellermann authored
This tiny amount of overhead allows omitting the MusicBuffer in Clear().
-
Max Kellermann authored
-
- 02 Jun, 2018 1 commit
-
-
Christian Kröner authored
-
- 03 May, 2018 1 commit
-
-
Max Kellermann authored
-