- 20 Sep, 2017 1 commit
-
-
Max Kellermann authored
-
- 04 Jun, 2017 1 commit
-
-
Max Kellermann authored
-
- 03 Jun, 2017 1 commit
-
-
Max Kellermann authored
This commit is similar to 788e3b31, and removes more "pure" attributes which were placed on functions that could throw exceptions, which is illegal according to clang's understanding of the attribute (but not according to GCC's). GitHub issue #58 was most likely about StorageDirectoryReader::GetInfo() and Storage::GetInfo(), which still had "pure" attributes. Closes #58
-
- 08 May, 2017 2 commits
-
-
Max Kellermann authored
The "pure" and "const" attributes are not so well-defined, and a recent clang version implements an optimization which pushes the definition's boundary beyond what I believed it was. clang now assumes that functions declared "pure" cannot throw exceptions, even if they lack the "noexcept" specification. When compiled with this new clang version, MPD will crash randomly if an exception happens to get thrown by such as "pure" function (https://github.com/MusicPlayerDaemon/MPD/issues/41). This commit removes all such misplaced "pure" and "const" attributes, closing #41.
-
Max Kellermann authored
This eliminates some overhead, because the compiler doesn't need to consider these functions throwing.
-
- 06 Apr, 2017 1 commit
-
-
Max Kellermann authored
An ino_t is usually a 64 bit integer, and some file systems (such as Linux's kernel NFS client) really uses the upper 32 bit. This can lead to false positives in the directory loop detection in FindAncestorLoop(). Increasing these two attributes (in StorageFileInfo and Directory) to 64 bit adds little overhead, but makes the check a lot safer.
-
- 01 Mar, 2017 1 commit
-
-
Max Kellermann authored
-
- 31 Jan, 2017 1 commit
-
-
Thomas Zander authored
-
- 23 Jan, 2017 8 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
If the base class is not accessible, the "catching" the base class won't work. This caused the fatal error: terminate called after throwing an instance of 'LibmpdclientError'
-
- 06 Jan, 2017 1 commit
-
-
Max Kellermann authored
-
- 03 Jan, 2017 2 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
- 28 Dec, 2016 1 commit
-
-
Max Kellermann authored
-
- 23 Nov, 2016 1 commit
-
-
Steven OBrien authored
SimpleDatabase::Visit() always throws exception when visiting a song. Adding a song to the queue always results in a "No such directory" error response, although the song is successfully added. This behaviour was introduced by commit 3ff728ab. This patch fixes this. https://bugs.musicpd.org/view.php?id=4601
-
- 22 Nov, 2016 3 commits
-
-
Max Kellermann authored
Speed up container_scan() again, by eliminating the need to call scan_file() for each item.
-
Max Kellermann authored
-
Max Kellermann authored
-
- 10 Nov, 2016 1 commit
-
-
Max Kellermann authored
-
- 29 Oct, 2016 8 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Implementations shall use exceptions instead.
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
- 28 Oct, 2016 6 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
- 27 Oct, 2016 1 commit
-
-
Max Kellermann authored
-