- 23 Jan, 2009 8 commits
-
-
Max Kellermann authored
Moved protocol printing functions which operate on the queue to queue_print.c.
-
Max Kellermann authored
The LocateTagItem objects are not modified.
-
Max Kellermann authored
swapSongs() is only a wrapper for queue_swap().
-
Max Kellermann authored
When you delete a song from the playlist which was paused, MPD forgot that it was paused and started playing the next song.
-
Max Kellermann authored
The playlist.c source is currently quite hard to understand. I have managed to wrap my head around it, and this patch attempts to explain it to the next guy.
-
Max Kellermann authored
The function playPlaylistIfPlayerStopped() is only called when the player thread is stopped. Converted that runtime check into an assertion, and remove one indent level.
-
Max Kellermann authored
One of the previous patches removed the "random" mode check from nextSongInPlaylist(), which caused a shuffle whenever MPD wrapped to the first song in "repeat" mode. Re-add that "random" check.
-
Max Kellermann authored
In playPlaylist(), the second "song==-1 && playing" check can never be reached, because at this point, the function has already returned (after unpausing).
-
- 22 Jan, 2009 12 commits
-
-
Max Kellermann authored
All callers pass false. Don't bother to collect that parameter.
-
Max Kellermann authored
When a song is deleted, start playing the next song immediately, within deleteFromPlaylist(). This allows us to remove the ugly playlist_noGoToNext flag, and the currentSongInPlaylist() function.
-
Max Kellermann authored
By calling queue_next_order() before playlist.current is invalidated (by the deletion of a song), we get more robust results, and the code becomes a little bit easier. incrPlaylistCurrent() is unused now, and can be removed.
-
Max Kellermann authored
Remove one indent level by returning diretly after the check. This makes the function more readable.
-
Max Kellermann authored
There were only two possible states: STOP and PLAY. The code looks a lot easier if we use a bool instead. Move the variable into the playlist struct.
-
Max Kellermann authored
The function shuffles the virtual order of songs, but does not move them physically. This is used in random mode. The new function replaces playlist.c's randomizeOrder() function, which was aware of playlist.current and playlist.queued. The latter is always -1 anyway, and the former as preserved by the caller, by converting playlist.current to a position, and then back to an order number.
-
Max Kellermann authored
Add a "changed" check to setPlaylistRepeatStatus(): when the new repeat mode is the same as the old one, don't do anything at all. No more checks, no "idle" event.
-
Max Kellermann authored
When the random mode is toggled, MPD did not clear the queue. Because of this, MPD continued with the next (random or non-random) song according to the previous mode. Clear the queued song to fix that.
-
Max Kellermann authored
Merged duplicate code from queueNextSongInPlaylist().
-
Max Kellermann authored
Attempt to untie the playlist.c knot: moved the playlist storage code to queue.c, struct queue.
-
Max Kellermann authored
Check for current>=0, not queued>=0.
-
Max Kellermann authored
The function moveSongInPlaylist() attempted to read the position of the current song, even if it was -1. Check that first. The same bug was in shufflePlaylist().
-
- 21 Jan, 2009 5 commits
-
-
Max Kellermann authored
It is possible that playlist.current is reset before the TAG event handler playlist_tag_event() is called. Convert the assertion into a run-time check.
-
Max Kellermann authored
Don't attempt to restart the player if it was stopped, but there were still songs left on the playlist. This looks like it has been a workaround for a bug which has been fixed long time ago.
-
Max Kellermann authored
Don't assign the result of getPlayerError() to an integer.
-
Max Kellermann authored
Use g_free() consistently with g_malloc(). Don't clear the pointers after freeing them.
-
Max Kellermann authored
Simplify some code by using config_get_positive(), instead of doing manual parsing and validation each time.
-
- 20 Jan, 2009 1 commit
-
-
Max Kellermann authored
The "TAG" event is emitted by the player thread when the current song's tag has changed. Split this event from "PLAYLIST" and make it a separate callback, which is more efficient.
-
- 18 Jan, 2009 1 commit
-
-
Max Kellermann authored
-
- 17 Jan, 2009 2 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Renamed functions, types, variables.
-
- 16 Jan, 2009 1 commit
-
-
Max Kellermann authored
getBoolConfigParam() returns an int. It is not possible to check for CONF_BOOL_UNSET after it has been assigned to a bool; use a temporary int value for that.
-
- 14 Jan, 2009 1 commit
-
-
Max Kellermann authored
When a song file is deleted during database update, all pointers to it must be removed from the playlist. The "for" loop in deleteASongFromPlaylist() did not deal with multiple copies of the deleted song properly, and left instances of the (to-be-invalidated) pointer in. Fix this by reversing the loop.
-
- 13 Jan, 2009 1 commit
-
-
Max Kellermann authored
MPD's shuffling algorithm was not implemented well: it considers songs which were already swapped, making it somewhat non-random. Fix the Fisher-Yates shuffle algorithm by passing the proper bounds to the PRNG.
-
- 10 Jan, 2009 3 commits
-
-
Max Kellermann authored
A song index cannot be negative. Also require the second parameter to be valid.
-
Max Kellermann authored
In a range "start:end", "end" itself should not be included. Use the same semantics as other languages implementing ranges, e.g. Python.
-
Thomas Jansen authored
Loosely based on a patch provided by lesion in bug #1766. The playlistinfo command can now retrieve ranges of the playlist. The new argument indicates which entry is the last one that will be displayed. The number of displayed entries may be smaller than expected if the end of the playlist is reached. Previous usage: playlistinfo [start] New usage: playlistinfo [start[:end]]
-
- 04 Jan, 2009 4 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Don't call command_error() if loading a song from the playlist fails. This may result in assertion failures, since command_error() may be called more than once.
-
Max Kellermann authored
-
Max Kellermann authored
For internal checks (i.e. not in command.c), we need to check whether an URI is in the databse, in the local file system or a remote URI with a scheme.
-
- 03 Jan, 2009 1 commit
-
-
Max Kellermann authored
If the state file cannot be read, for whatever reason, don't abort MPD. The state file isn't _that_ important.
-