rpcrt4: Fix ITypeInfo leak in get_iface_info.

Signed-off-by: Jacek Caban <jacek@codeweavers.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

rpcrt4: Fix ITypeInfo leak in get_iface_info.
a09c08f1 · Kevin Puetz · Alexandre Julliard · c8c00d6f · a09c08f1
Commit a09c08f1 authored Jan 27, 2020 by Kevin Puetz Committed by Alexandre Julliard Jan 27, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

ndr_typelib.c dlls/rpcrt4/ndr_typelib.c +6 -4

No files found.
--- a/dlls/rpcrt4/ndr_typelib.c
+++ b/dlls/rpcrt4/ndr_typelib.c
@@ -1265,14 +1265,16 @@ static HRESULT get_iface_info(ITypeInfo *typeinfo, WORD *funcs, WORD *parentfunc
    if (FAILED(hr))
        goto err;
    hr = ITypeInfo_GetRefTypeInfo(*real_typeinfo, reftype, &parentinfo);
+    if (SUCCEEDED(hr))
+    {
+        hr = ITypeInfo_GetTypeAttr(parentinfo, &typeattr);
+        ITypeInfo_Release(parentinfo);
+    }
    if (FAILED(hr))
        goto err;
-    hr = ITypeInfo_GetTypeAttr(parentinfo, &typeattr);
-    if (FAILED(hr))
-        goto err;
+
    *parentiid = typeattr->guid;
    ITypeInfo_ReleaseTypeAttr(parentinfo, typeattr);
-    ITypeInfo_Release(parentinfo);

    return S_OK;