- 19 Oct, 2016 40 commits
-
-
Yaakov Selkowitz authored
Private is a struct member name in mingw-w64 <winioctl.h>, causing this useless define in a private header to break the build. Signed-off-by:
Yaakov Selkowitz <yselkowitz@users.sourceforge.net> Reviewed-by:
Jon TURNEY <jon.turney@dronecode.org.uk> Backported-to-NX-by:
Ulrich Sibiller <uli42@gmx.de>
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Backported-to-NX-by:
-
Alan Coopersmith authored
Fixes leaks in error paths found by Parfait 1.0.0: Error: X Resource Leak Leaked X Resource pix at line 62 of CrBFData.c in function 'XCreateBitmapFromData'. pix initialized at line 60 with XCreatePixmap Error: X Resource Leak Leaked X Resource pix at line 70 of CrPFBData.c in function 'XCreatePixmapFromBitmapData'. pix initialized at line 66 with XCreatePixmap Signed-off-by:Aaron Plattner <aplattner@nvidia.com> Backported-to-NX-by:
-
Philipp Reh authored
When we dequeue an event in XCheckTypedEvent or XCheckTypedWindowEvent, make sure to store the corresponding cookie too. Signed-off-by:
Philipp Reh <sefi@s-e-f-i.de> Reviewed-by:
Daniel Stone <daniel@fooishbar.org> Backported-to-NX-by:
-
Jeremy Huddleston authored
This will prevent a number of false positives in where clang's static analysis reports about calls to malloc(0). Signed-off-by:
Jeremy Huddleston <jeremyhu@apple.com> Backported-to-NX-by:
-
Jeremy Huddleston authored
This provides a simplified version of the SetReqLen macro when using clang for static analysis. Prior to this change, we would see many Idempotent operation warnings inside this macro due to the common case of calling with arg2 and arg3 being the same variable. This has no effect on code produced during compilation, but it silences a number of false positives in static analysis. XIPassiveGrab.c:170:5: warning: Assigned value is always the same as the existing value SetReqLen(req, num_modifiers, num_modifiers); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from XIPassiveGrab.c:26: .../nx-X11/lib/X11/Xlibint.h:580:8: note: instantiated from: n = badlen; \ ^ Signed-off-by: -
Alan Coopersmith authored
Signed-off-by:
-
Jeremy Huddleston authored
Signed-off-by:
-
Bodo Graumann authored
IsModifierKey, defined in include/X11/Xutil.h, is a macro determining, which keys are regarded as modifiers. The constants ISO_Level5_Shift, ISO_Level5_Latch and ISO_Level5_Lock where excluded previously, leaving some Neo2 modifiers functionless in combination with compose. This patch adjusts the range to include the correct, full range of modifier constants. Neo2 Bug 277 <http://wiki.neo-layout.org/ticket/277> X.Org Bug 21910 <http://bugs.freedesktop.org/show_bug.cgi?id=21910> Signed-off-by:
Bodo Graumann <mail@bodograumann.de> Reviewed-by:
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Jamey Sharp <jamey@minilop.net> Backported-to-NX-by:
-
Peter Hutterer authored
Some XI2 requests change in size over different versions and libXi would need to hack around GetReq and GetReqExtra. Add a new GetReqSized so the library can explicitly specify the size of the request in 4-byte units. Signed-off-by:
-
Peter Hutterer authored
GetEmptyReq and GetResReq cannot do this due to the final typecast - typically requests that need either of those do not have their own typedef in the protocol headers. Signed-off-by:
-
Erkki Seppälä authored
Fixed memory leak by adding Xfree and initializing missing_list with NULL Variable "missing_list" goes out of scope Reviewed-by:
Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by:
Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by:
-
Erkki Seppälä authored
Fixed memory leak by adding Xfree for colormap_ret Variable "colormap_ret" goes out of scope Reviewed-by:
-
Erkki Seppälä authored
Checked return value of XGetWindowProperty and return false if it fails. Return value of "XGetWindowProperty(im->core.display, spec->lib_connect_wid, prop, 0L, (length + bytes_after_ret + 3UL) / 4UL, 1, 0UL, &type_ret, &format_ret, &nitems, &bytes_after_ret, &prop_ret)" is not checked Reviewed-by:
-
Erkki Seppälä authored
Fixed by negative value to memcpy by checking for the negative return value of _Xlcwctomb and returning 0/XLookupNone in that case. a negative value was passed to memcpy Unfortunately the other return values for *status don't fit into the error (which appears to indicate some internal error or running out of memory). The other valid status codes are XBufferOverflow, XLookupNone, XLookupChars, XLookupKeySym, and XLookupBoth. Each of these has a specific meaning attached. Reviewed-by:
-
Ander Conselvan de Oliveira authored
Fixed by zero'ing conv on allocation with Xcalloc. Then close_converter works properly. Using uninitialized value "conv->state" in call to function "close_converter" Reviewed-by:
-
Samuel Thibault authored
_XimLocalMbLookupString can return a braille keysym even if _Xlcwctomb can't convert to the current MB charset. _XimLocalUtf8LookupString needs to set the braille keysym and status too. Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Backported-to-NX-by:
-
Samuel Thibault authored
Braille chords management needs key release events. We need to explicitly request then, else GTK would not pass them throught XFilterEvent and braille wouldn't work. Signed-off-by:
-
Erkki Seppälä authored
Variable "map" goes out of scope Release modifiermap before returning. Reordered code to call XGetModifierMapping after the first return from the function. Signed-off-by:
Dirk Wallenstein <halsmit@t-online.de> Backported-to-NX-by:
-
Alan Coopersmith authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
name_ptr and detail_ptr weren't free'd in some cases before returning False. Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
While at it, remove unneeded check for NULL before Xfree. Signed-off-by:
-
Jeremy Huddleston authored
Found by clang static analysis Signed-off-by:
-
Yann Droneaud authored
As stated in man page (XOpenIM) and Xlib documentation (chapter 13.5.3), XGetIMValues() and XSetImValues() "returns the name of the first argument that could not be obtained." But currently, err = XGetIMValues(im, "invalid", &arg, NULL); returns &arg instead of "invalid". This patch fixes https://bugs.freedesktop.org/show_bug.cgi?id=12897Signed-off-by:
Yann Droneaud <yann@droneaud.fr> Reviewed-by:
-
Yann Droneaud authored
In case of error, XSetICValues() must return the first argument that failed to be set. But in some error paths, it returns False, which is converted to NULL, so the function returns OK in case of error. Signed-off-by:
-
Xue Wei authored
Fixes pasting more than 1024 bytes into xterm, as described in https://bugs.freedesktop.org/show_bug.cgi?id=25209Signed-off-by:
-
Alan Coopersmith authored
Signed-off-by:
-
Andreas Wettstein authored
Currently, only non-modifier keys (actually, keysyms) can be part of a compose sequence, and they are matched against the defined compose sequences at the time the key is pressed. The patch allows to use modifier keys an well, but matches them on key release, and only if no other key has been pressed after the modifier. Releasing a non-matched modifier during an ongoing compose sequence only aborts the sequence if any modifier release would have matched. In particular, if no compose sequences with modifiers are specified, the compose mechanism works exactly as without this patch. Even if modifiers are part of a compose sequence, they are not filtered. This is because modifiers affect the keyboard state no matter what we do here and, therefore, filtering them only could confuse clients. The purpose is this extension to the compose mechanism is to allow to make better use of keys in convenient reach for touch typing. Signed-off-by:
Andreas Wettstein <wettstein509@solnet.ch> Signed-off-by:
James Cloos <cloos@jhcloos.com> Backported-to-NX-by:
-
Samuel Thibault authored
Braille patterns should also be usable in Compose. This combines the implementation of braille chords and compose tree: only emit the braille pattern if it can not be found in the compose tree, if any. Signed-off-by:
-
Peter Hutterer authored
Signed-off-by:
-
Alan Coopersmith authored
Fixes warning: "Xrm.c", line 1094: warning: storage class after type is obsolescent Signed-off-by:
-
Keith Packard authored
Wait for all other threads to release the user-level lock when acquiring it. This ensures that only one thread at a time holds the user-level lock, necessary as it is a nesting lock and a single variable is used to determine when the lock is nesting and when it is contended. Signed-off-by:
Keith Packard <keithp@keithp.com> Reviewed-by:
-
Marko Myllynen authored
https://bugs.freedesktop.org/show_bug.cgi?id=19687Signed-off-by:
Marko Myllynen <myllynen@redhat.com> Reviewed-by:
Matt Dew <marcoz@osource.org> Signed-off-by:
-
