process_bug.cgi 29.2 KB
Newer Older
1 2
#!/usr/bonsaitools/bin/perl -w
# -*- Mode: perl; indent-tabs-mode: nil -*-
terry%netscape.com's avatar
terry%netscape.com committed
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
terry%netscape.com's avatar
terry%netscape.com committed
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
terry%netscape.com's avatar
terry%netscape.com committed
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
terry%netscape.com's avatar
terry%netscape.com committed
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Dan Mosedale <dmose@mozilla.org>
terry%netscape.com's avatar
terry%netscape.com committed
23

24 25 26
use diagnostics;
use strict;

27 28 29
my $UserInEditGroupSet = -1;
my $UserInCanConfirmGroupSet = -1;

30 31 32 33 34 35
require "CGI.pl";

# Shut up misguided -w warnings about "used only once":

use vars %::versions,
    %::components,
36 37 38 39 40 41 42
    %::COOKIE,
    %::keywordsbyname,
    %::legal_keywords,
    %::legal_opsys,
    %::legal_platform,
    %::legal_priority,
    %::legal_severity;
43

44
my $whoid = confirm_login();
45 46 47

print "Content-type: text/html\n\n";

48 49
PutHeader ("Bug processed");

50 51
GetVersionTable();

52 53 54 55 56 57
if ( Param("strictvaluechecks") ) {
    CheckFormFieldDefined(\%::FORM, 'product');
    CheckFormFieldDefined(\%::FORM, 'version');
    CheckFormFieldDefined(\%::FORM, 'component');
}

58
if ($::FORM{'product'} ne $::dontchange) {
59 60 61
    if ( Param("strictvaluechecks") ) {
        CheckFormField(\%::FORM, 'product', \@::legal_product);
    }
62
    my $prod = $::FORM{'product'};
63 64 65 66 67 68 69 70 71

    # note that when this script is called from buglist.cgi (rather
    # than show_bug.cgi), it's possible that the product will be changed
    # but that the version and/or component will be set to 
    # "--dont_change--" but still happen to be correct.  in this case,
    # the if statement will incorrectly trigger anyway.  this is a 
    # pretty weird case, and not terribly unreasonable behavior, but 
    # worthy of a comment, perhaps.
    #
72 73
    my $vok = lsearch($::versions{$prod}, $::FORM{'version'}) >= 0;
    my $cok = lsearch($::components{$prod}, $::FORM{'component'}) >= 0;
74 75 76 77 78 79 80 81 82
    if (!$vok || !$cok) {
        print "<H1>Changing product means changing version and component.</H1>\n";
        print "You have chosen a new product, and now the version and/or\n";
        print "component fields are not correct.  (Or, possibly, the bug did\n";
        print "not have a valid component or version field in the first place.)\n";
        print "Anyway, please set the version and component now.<p>\n";
        print "<form>\n";
        print "<table>\n";
        print "<tr>\n";
83
        print "<td align=right><b>Product:</b></td>\n";
84 85
        print "<td>$prod</td>\n";
        print "</tr><tr>\n";
86 87
        print "<td align=right><b>Version:</b></td>\n";
        print "<td>" . Version_element($::FORM{'version'}, $prod) . "</td>\n";
88
        print "</tr><tr>\n";
89 90
        print "<td align=right><b>Component:</b></td>\n";
        print "<td>" . Component_element($::FORM{'component'}, $prod) . "</td>\n";
91 92 93 94
        print "</tr>\n";
        print "</table>\n";
        foreach my $i (keys %::FORM) {
            if ($i ne 'version' && $i ne 'component') {
95
                print "<input type=hidden name=$i value=\"" .
96
                value_quote($::FORM{$i}) . "\">\n";
terry%netscape.com's avatar
terry%netscape.com committed
97 98
            }
        }
99
        print "<input type=submit value=Commit>\n";
100 101
        print "</form>\n";
        print "</hr>\n";
102
        print "<a href=query.cgi>Cancel all this and go to the query page.</a>\n";
103
        PutFooter();
104
        exit;
terry%netscape.com's avatar
terry%netscape.com committed
105 106 107 108
    }
}


109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131
# Checks that the user is allowed to change the given field.  Actually, right
# now, the rules are pretty simple, and don't look at the field itself very
# much, but that could be enhanced.

my $lastbugid = 0;
my $ownerid;
my $reporterid;
my $qacontactid;

sub CheckCanChangeField {
    my ($f, $bugid, $oldvalue, $newvalue) = (@_);
    if ($f eq "assigned_to" || $f eq "reporter" || $f eq "qa_contact") {
        if ($oldvalue =~ /^\d+$/) {
            if ($oldvalue == 0) {
                $oldvalue = "";
            } else {
                $oldvalue = DBID_to_name($oldvalue);
            }
        }
    }
    if ($oldvalue eq $newvalue) {
        return 1;
    }
132 133 134
    if (trim($oldvalue) eq trim($newvalue)) {
        return 1;
    }
135 136 137 138 139 140 141 142 143 144 145 146 147 148
    if ($f =~ /^longdesc/) {
        return 1;
    }
    if ($UserInEditGroupSet < 0) {
        $UserInEditGroupSet = UserInGroup("editbugs");
    }
    if ($UserInEditGroupSet) {
        return 1;
    }
    if ($lastbugid != $bugid) {
        SendSQL("SELECT reporter, assigned_to, qa_contact FROM bugs " .
                "WHERE bug_id = $bugid");
        ($reporterid, $ownerid, $qacontactid) = (FetchSQLData());
    }
149 150
    if ($f eq "bug_status" && $newvalue ne $::unconfirmedstate &&
        IsOpenedState($newvalue)) {
151 152 153 154 155 156 157 158 159 160 161 162

        # Hmm.  They are trying to set this bug to some opened state
        # that isn't the UNCONFIRMED state.  Are they in the right
        # group?  Or, has it ever been confirmed?  If not, then this
        # isn't legal.

        if ($UserInCanConfirmGroupSet < 0) {
            $UserInCanConfirmGroupSet = UserInGroup("canconfirm");
        }
        if ($UserInCanConfirmGroupSet) {
            return 1;
        }
163 164 165 166
        SendSQL("SELECT everconfirmed FROM bugs WHERE bug_id = $bugid");
        my $everconfirmed = FetchOneColumn();
        if ($everconfirmed) {
            return 1;
167
        }
168 169 170
    } elsif ($reporterid eq $whoid || $ownerid eq $whoid ||
             $qacontactid eq $whoid) {
        return 1;
171 172 173 174
    }
    SendSQL("UNLOCK TABLES");
    $oldvalue = value_quote($oldvalue);
    $newvalue = value_quote($newvalue);
175
    print PuntTryAgain(qq{
176 177 178 179 180 181
Only the owner or submitter of the bug, or a sufficiently
empowered user, may make that change to the $f field.
<TABLE>
<TR><TH ALIGN="right">Old value:</TH><TD>$oldvalue</TD></TR>
<TR><TH ALIGN="right">New value:</TH><TD>$newvalue</TD></TR>
</TABLE>
182
});
183 184 185 186 187 188 189 190 191
    PutFooter();
    exit();
}


    
    


192 193
my @idlist;
if (defined $::FORM{'id'}) {
194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216

    # since this means that we were called from show_bug.cgi, now is a good
    # time to do a whole bunch of error checking that can't easily happen when
    # we've been called from buglist.cgi, because buglist.cgi only tweaks
    # values that have been changed instead of submitting all the new values.
    # (XXX those error checks need to happen too, but implementing them 
    # is more work in the current architecture of this script...)
    #
    if ( Param('strictvaluechecks') ) { 
        CheckFormField(\%::FORM, 'rep_platform', \@::legal_platform);
        CheckFormField(\%::FORM, 'priority', \@::legal_priority);
        CheckFormField(\%::FORM, 'bug_severity', \@::legal_severity);
        CheckFormField(\%::FORM, 'component', 
                       \@{$::components{$::FORM{'product'}}});
        CheckFormFieldDefined(\%::FORM, 'bug_file_loc');
        CheckFormFieldDefined(\%::FORM, 'short_desc');
        CheckFormField(\%::FORM, 'product', \@::legal_product);
        CheckFormField(\%::FORM, 'version', 
                       \@{$::versions{$::FORM{'product'}}});
        CheckFormField(\%::FORM, 'op_sys', \@::legal_opsys);
        CheckFormFieldDefined(\%::FORM, 'longdesclength');
        CheckPosInt($::FORM{'id'});
    }
217
    push @idlist, $::FORM{'id'};
terry%netscape.com's avatar
terry%netscape.com committed
218
} else {
219 220
    foreach my $i (keys %::FORM) {
        if ($i =~ /^id_/) {
221 222 223
            if ( Param('strictvaluechecks') ) { 
                CheckPosInt(substr($i, 3));
            }
224
            push @idlist, substr($i, 3);
terry%netscape.com's avatar
terry%netscape.com committed
225 226 227 228
        }
    }
}

229 230
if (!defined $::FORM{'who'}) {
    $::FORM{'who'} = $::COOKIE{'Bugzilla_login'};
terry%netscape.com's avatar
terry%netscape.com committed
231 232
}

233 234
# the common updates to all bugs in @idlist start here
#
235 236 237 238 239
print "<TITLE>Update Bug " . join(" ", @idlist) . "</TITLE>\n";
if (defined $::FORM{'id'}) {
    navigation_header();
}
print "<HR>\n";
240 241 242 243 244 245 246
$::query = "update bugs\nset";
$::comma = "";
umask(0);

sub DoComma {
    $::query .= "$::comma\n    ";
    $::comma = ",";
terry%netscape.com's avatar
terry%netscape.com committed
247 248
}

249 250 251 252 253 254 255 256 257 258 259 260 261 262
sub DoConfirm {
    if ($UserInEditGroupSet < 0) {
        $UserInEditGroupSet = UserInGroup("editbugs");
    }
    if ($UserInCanConfirmGroupSet < 0) {
        $UserInCanConfirmGroupSet = UserInGroup("canconfirm");
    }
    if ($UserInEditGroupSet || $UserInCanConfirmGroupSet) {
        DoComma();
        $::query .= "everconfirmed = 1";
    }
}


263 264 265 266
sub ChangeStatus {
    my ($str) = (@_);
    if ($str ne $::dontchange) {
        DoComma();
267 268 269 270 271
        if (IsOpenedState($str)) {
            $::query .= "bug_status = IF(everconfirmed = 1, '$str', '$::unconfirmedstate')";
        } else {
            $::query .= "bug_status = '$str'";
        }
272 273 274
        $::FORM{'bug_status'} = $str; # Used later for call to
                                      # CheckCanChangeField to make sure this
                                      # is really kosher.
terry%netscape.com's avatar
terry%netscape.com committed
275 276 277
    }
}

278 279 280 281 282
sub ChangeResolution {
    my ($str) = (@_);
    if ($str ne $::dontchange) {
        DoComma();
        $::query .= "resolution = '$str'";
terry%netscape.com's avatar
terry%netscape.com committed
283 284 285
    }
}

286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301
#
# This function checks if there is a comment required for a specific
# function and tests, if the comment was given.
# If comments are required for functions  is defined by params.
#
sub CheckonComment( $ ) {
    my ($function) = (@_);
    
    # Param is 1 if comment should be added !
    my $ret = Param( "commenton" . $function );

    # Allow without comment in case of undefined Params.
    $ret = 0 unless ( defined( $ret ));

    if( $ret ) {
        if (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/) {
302
            # No comment - sorry, action not allowed !
303 304 305
            PuntTryAgain("You have to specify a <b>comment</b> on this " .
                         "change.  Please give some words " .
                         "on the reason for your change.");
306 307 308 309 310 311 312
        } else {
            $ret = 0;
        }
    }
    return( ! $ret ); # Return val has to be inverted
}

terry%netscape.com's avatar
terry%netscape.com committed
313

314 315 316 317 318 319 320 321 322 323 324 325 326 327 328
my $foundbit = 0;
foreach my $b (grep(/^bit-\d*$/, keys %::FORM)) {
    if (!$foundbit) {
        $foundbit = 1;
        DoComma();
        $::query .= "groupset = 0";
    }
    if ($::FORM{$b}) {
        my $v = substr($b, 4);
        $::query .= "+ $v";     # Carefully written so that the math is
                                # done by MySQL, which can handle 64-bit math,
                                # and not by Perl, which I *think* can not.
    }
}

329
foreach my $field ("rep_platform", "priority", "bug_severity",          
330
                   "summary", "component", "bug_file_loc", "short_desc",
331
                   "product", "version", "op_sys",
332
                   "target_milestone", "status_whiteboard") {
333 334 335
    if (defined $::FORM{$field}) {
        if ($::FORM{$field} ne $::dontchange) {
            DoComma();
336
            $::query .= "$field = " . SqlQuote(trim($::FORM{$field}));
terry%netscape.com's avatar
terry%netscape.com committed
337 338 339 340
        }
    }
}

341

342 343
if (defined $::FORM{'qa_contact'}) {
    my $name = trim($::FORM{'qa_contact'});
terry%netscape.com's avatar
terry%netscape.com committed
344
    if ($name ne $::dontchange) {
345 346 347 348 349 350 351 352 353
        my $id = 0;
        if ($name ne "") {
            $id = DBNameToIdAndCheck($name);
        }
        DoComma();
        $::query .= "qa_contact = $id";
    }
}

354 355 356

ConnectToDatabase();

357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374
my %ccids;
my $origcclist = "";

# We make sure to check out the CC list before we actually start touching any
# bugs.
if (defined $::FORM{'cc'} && defined $::FORM{'id'}) {
    $origcclist = ShowCcList($::FORM{'id'});
    if ($origcclist ne $::FORM{'cc'}) {
        foreach my $person (split(/[ ,]/, $::FORM{'cc'})) {
            if ($person ne "") {
                my $cid = DBNameToIdAndCheck($person);
                $ccids{$cid} = 1;
            }
        }
    }
}


375 376 377
if ( Param('strictvaluechecks') ) {
    CheckFormFieldDefined(\%::FORM, 'knob');
}
378 379 380 381
SWITCH: for ($::FORM{'knob'}) {
    /^none$/ && do {
        last SWITCH;
    };
382 383 384 385 386
    /^confirm$/ && CheckonComment( "confirm" ) && do {
        DoConfirm();
        ChangeStatus('NEW');
        last SWITCH;
    };
387
    /^accept$/ && CheckonComment( "accept" ) && do {
388
        DoConfirm();
389 390 391
        ChangeStatus('ASSIGNED');
        last SWITCH;
    };
392
    /^clearresolution$/ && CheckonComment( "clearresolution" ) && do {
393 394 395
        ChangeResolution('');
        last SWITCH;
    };
396
    /^resolve$/ && CheckonComment( "resolve" ) && do {
397 398 399 400
        ChangeStatus('RESOLVED');
        ChangeResolution($::FORM{'resolution'});
        last SWITCH;
    };
401
    /^reassign$/ && CheckonComment( "reassign" ) && do {
402 403 404
        if ($::FORM{'andconfirm'}) {
            DoConfirm();
        }
405 406
        ChangeStatus('NEW');
        DoComma();
407 408 409
        if ( Param("strictvaluechecks") ) {
          if ( !defined$::FORM{'assigned_to'} ||
               trim($::FORM{'assigned_to'}) eq "") {
410 411 412 413
            PuntTryAgain("You cannot reassign to a bug to nobody.  Unless " .
                         "you intentionally cleared out the " .
                         "\"Reassign bug to\" field, " .
                         Param("browserbugmessage"));
414 415
          }
        }
416 417 418 419
        my $newid = DBNameToIdAndCheck($::FORM{'assigned_to'});
        $::query .= "assigned_to = $newid";
        last SWITCH;
    };
420
    /^reassignbycomponent$/  && CheckonComment( "reassignbycomponent" ) && do {
421
        if ($::FORM{'product'} eq $::dontchange) {
422 423
            PuntTryAgain("You must specify a product to help determine the " .
                         "new owner of these bugs.");
424
        }
425
        if ($::FORM{'component'} eq $::dontchange) {
426 427
            PuntTryAgain("You must specify a component whose owner should " .
                         "get assigned these bugs.");
terry%netscape.com's avatar
terry%netscape.com committed
428
        }
429 430
        ChangeStatus('NEW');
        SendSQL("select initialowner from components where program=" .
431 432
                SqlQuote($::FORM{'product'}) . " and value=" .
                SqlQuote($::FORM{'component'}));
433 434 435 436
        my $newname = FetchOneColumn();
        my $newid = DBNameToIdAndCheck($newname, 1);
        DoComma();
        $::query .= "assigned_to = $newid";
437 438 439 440 441 442 443 444 445 446 447
        if (Param("useqacontact")) {
            SendSQL("select initialqacontact from components where program=" .
                    SqlQuote($::FORM{'product'}) .
                    " and value=" . SqlQuote($::FORM{'component'}));
            my $qacontact = FetchOneColumn();
            if (defined $qacontact && $qacontact ne "") {
                my $newqa = DBNameToIdAndCheck($qacontact, 1);
                DoComma();
                $::query .= "qa_contact = $newqa";
            }
        }
448 449
        last SWITCH;
    };   
450
    /^reopen$/  && CheckonComment( "reopen" ) && do {
451
        ChangeStatus('REOPENED');
452
        ChangeResolution('');
453 454
        last SWITCH;
    };
455
    /^verify$/ && CheckonComment( "verify" ) && do {
456 457 458
        ChangeStatus('VERIFIED');
        last SWITCH;
    };
459
    /^close$/ && CheckonComment( "close" ) && do {
460 461 462
        ChangeStatus('CLOSED');
        last SWITCH;
    };
463
    /^duplicate$/ && CheckonComment( "duplicate" ) && do {
464 465
        ChangeStatus('RESOLVED');
        ChangeResolution('DUPLICATE');
466 467 468
        if ( Param('strictvaluechecks') ) {
            CheckFormFieldDefined(\%::FORM,'dup_id');
        }
469
        my $num = trim($::FORM{'dup_id'});
470 471 472
        SendSQL("SELECT bug_id FROM bugs WHERE bug_id = " . SqlQuote($num));
        $num = FetchOneColumn();
        if (!$num) {
473 474
            PuntTryAgain("You must specify a bug number of which this bug " .
                         "is a duplicate.  The bug has not been changed.")
terry%netscape.com's avatar
terry%netscape.com committed
475
        }
476
        if (!defined($::FORM{'id'}) || $num == $::FORM{'id'}) {
477 478 479
            PuntTryAgain("Nice try, $::FORM{'who'}.  But it doesn't really ".
                         "make sense to mark a bug as a duplicate of " .
                         "itself, does it?");
terry%netscape.com's avatar
terry%netscape.com committed
480
        }
481
        AppendComment($num, $::FORM{'who'}, "*** Bug $::FORM{'id'} has been marked as a duplicate of this bug. ***");
482 483 484
        if ( Param('strictvaluechecks') ) {
          CheckFormFieldDefined(\%::FORM,'comment');
        }
485
        $::FORM{'comment'} .= "\n\n*** This bug has been marked as a duplicate of $num ***";
486

487 488 489
        print "<TABLE BORDER=1><TD><H2>Notation added to bug $num</H2>\n";
        system("./processmail $num $::FORM{'who'}");
        print "<TD><A HREF=\"show_bug.cgi?id=$num\">Go To BUG# $num</A></TABLE>\n";
490

491 492 493 494
        last SWITCH;
    };
    # default
    print "Unknown action $::FORM{'knob'}!\n";
495
    PutFooter();
496
    exit;
terry%netscape.com's avatar
terry%netscape.com committed
497 498 499
}


500
if ($#idlist < 0) {
501
    PuntTryAgain("You apparently didn't choose any bugs to modify.");
terry%netscape.com's avatar
terry%netscape.com committed
502 503
}

504 505 506 507 508

my @keywordlist;
my %keywordseen;

if ($::FORM{'keywords'}) {
509 510 511 512
    foreach my $keyword (split(/[\s,]+/, $::FORM{'keywords'})) {
        if ($keyword eq '') {
            next;
        }
513 514
        my $i = $::keywordsbyname{$keyword};
        if (!$i) {
515 516 517 518
            PuntTryAgain("Unknown keyword named <code>$keyword</code>. " .
                         "<P>The legal keyword names are " .
                         "<A HREF=describekeywords.cgi>" .
                         "listed here</A>.");
519 520 521 522 523 524 525 526
        }
        if (!$keywordseen{$i}) {
            push(@keywordlist, $i);
            $keywordseen{$i} = 1;
        }
    }
}

527 528 529
my $keywordaction = $::FORM{'keywordaction'} || "makeexact";

if ($::comma eq "" && 0 == @keywordlist && $keywordaction ne "makeexact") {
530
    if (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/) {
531 532
        PuntTryAgain("Um, you apparently did not change anything on the " .
                     "selected bugs.");
terry%netscape.com's avatar
terry%netscape.com committed
533 534 535
    }
}

536
my $basequery = $::query;
537
my $delta_ts;
terry%netscape.com's avatar
terry%netscape.com committed
538

539

540 541
sub SnapShotBug {
    my ($id) = (@_);
542
    SendSQL("select delta_ts, " . join(',', @::log_columns) .
543
            " from bugs where bug_id = $id");
544 545
    my @row = FetchSQLData();
    $delta_ts = shift @row;
546

547
    return @row;
terry%netscape.com's avatar
terry%netscape.com committed
548 549 550
}


551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567
sub SnapShotDeps {
    my ($i, $target, $me) = (@_);
    SendSQL("select $target from dependencies where $me = $i order by $target");
    my @list;
    while (MoreSQLData()) {
        push(@list, FetchOneColumn());
    }
    return join(',', @list);
}


my $timestamp;

sub LogDependencyActivity {
    my ($i, $oldstr, $target, $me) = (@_);
    my $newstr = SnapShotDeps($i, $target, $me);
    if ($oldstr ne $newstr) {
568 569 570 571
        my $fieldid = GetFieldID($target);
        SendSQL("INSERT INTO bugs_activity " .
                "(bug_id,who,bug_when,fieldid,oldvalue,newvalue) VALUES " .
                "($i,$whoid,$timestamp,$fieldid,'$oldstr','$newstr')");
572 573 574 575 576
        return 1;
    }
    return 0;
}

577 578 579 580 581 582
delete $::FORM{'resolution'};   # Make sure we don't test the resolution
                                # against our permissions; we've already done
                                # that kind of testing, and this form field
                                # is actually usually not used.


583
# this loop iterates once for each bug to be processed (eg when this script
584
# is called with multiple bugs selected from buglist.cgi instead of
585 586
# show_bug.cgi).
#
587
foreach my $id (@idlist) {
588
    my %dependencychanged;
589 590
    my $write = "WRITE";        # Might want to make a param to control
                                # whether we do LOW_PRIORITY ...
591 592 593
    SendSQL("LOCK TABLES bugs $write, bugs_activity $write, cc $write, " .
            "profiles $write, dependencies $write, votes $write, " .
            "keywords $write, longdescs $write, fielddefs $write, " .
594
            "keyworddefs READ, groups READ, attachments READ");
595
    my @oldvalues = SnapShotBug($id);
596 597 598 599 600 601 602
    my $i = 0;
    foreach my $col (@::log_columns) {
        if (exists $::FORM{$col}) {
            CheckCanChangeField($col, $id, $oldvalues[$i], $::FORM{$col});
        }
        $i++;
    }
terry%netscape.com's avatar
terry%netscape.com committed
603

604 605 606 607 608 609 610 611
    if (defined $::FORM{'delta_ts'} && $::FORM{'delta_ts'} ne $delta_ts) {
        print "
<H1>Mid-air collision detected!</H1>
Someone else has made changes to this bug at the same time you were trying to.
The changes made were:
<p>
";
        DumpBugActivity($id, $delta_ts);
612
        my $longdesc = GetLongDescriptionAsHTML($id);
613
        my $longchanged = 0;
614

615 616
        if (length($longdesc) > $::FORM{'longdesclength'}) {
            $longchanged = 1;
617 618 619
            print "<P>Added text to the long description:<blockquote>";
            print substr($longdesc, $::FORM{'longdesclength'});
            print "</blockquote>\n";
620 621 622 623 624 625 626 627 628 629
        }
        SendSQL("unlock tables");
        print "You have the following choices: <ul>\n";
        $::FORM{'delta_ts'} = $delta_ts;
        print "<li><form method=post>";
        foreach my $i (keys %::FORM) {
            my $value = value_quote($::FORM{$i});
            print qq{<input type=hidden name="$i" value="$value">\n};
        }
        print qq{<input type=submit value="Submit my changes anyway">\n};
630
        print " This will cause all of the above changes to be overwritten";
631 632 633
        if ($longchanged) {
            print ", except for the changes to the description";
        }
634
        print qq{.</form>\n<li><a href="show_bug.cgi?id=$id">Throw away my changes, and go revisit bug $id</a></ul>\n};
635
        PutFooter();
636 637 638
        exit;
    }
        
639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654
    my %deps;
    if (defined $::FORM{'dependson'}) {
        my $me = "blocked";
        my $target = "dependson";
        for (1..2) {
            $deps{$target} = [];
            my %seen;
            foreach my $i (split('[\s,]+', $::FORM{$target})) {
                if ($i eq "") {
                    next;

                }
                SendSQL("select bug_id from bugs where bug_id = " .
                        SqlQuote($i));
                my $comp = FetchOneColumn();
                if ($comp ne $i) {
655
                    PuntTryAgain("$i is not a legal bug number");
656 657 658 659 660 661 662 663 664 665 666 667 668
                }
                if (!exists $seen{$i}) {
                    push(@{$deps{$target}}, $i);
                    $seen{$i} = 1;
                }
            }
            my @stack = @{$deps{$target}};
            while (@stack) {
                my $i = shift @stack;
                SendSQL("select $target from dependencies where $me = $i");
                while (MoreSQLData()) {
                    my $t = FetchOneColumn();
                    if ($t == $id) {
669 670 671 672
                        PuntTryAgain("Dependency loop detected!<P>" .
                                     "The change you are making to " .
                                     "dependencies has caused a circular " .
                                     "dependency chain.");
673 674 675 676 677 678 679 680
                    }
                    if (!exists $seen{$t}) {
                        push @stack, $t;
                        $seen{$t} = 1;
                    }
                }
            }
                        
681

682 683 684 685 686
            my $tmp = $me;
            $me = $target;
            $target = $tmp;
        }
    }
687

688 689 690 691 692 693
    if (@::legal_keywords) {
        # There are three kinds of "keywordsaction": makeexact, add, delete.
        # For makeexact, we delete everything, and then add our things.
        # For add, we delete things we're adding (to make sure we don't
        # end up having them twice), and then we add them.
        # For delete, we just delete things on the list.
694
        my $changed = 0;
695 696
        if ($keywordaction eq "makeexact") {
            SendSQL("DELETE FROM keywords WHERE bug_id = $id");
697
            $changed = 1;
698 699 700 701 702
        }
        foreach my $keyword (@keywordlist) {
            if ($keywordaction ne "makeexact") {
                SendSQL("DELETE FROM keywords
                         WHERE bug_id = $id AND keywordid = $keyword");
703
                $changed = 1;
704 705 706 707
            }
            if ($keywordaction ne "delete") {
                SendSQL("INSERT INTO keywords 
                         (bug_id, keywordid) VALUES ($id, $keyword)");
708 709 710 711 712 713 714 715 716 717 718 719
                $changed = 1;
            }
        }
        if ($changed) {
            SendSQL("SELECT keyworddefs.name 
                     FROM keyworddefs, keywords
                     WHERE keywords.bug_id = $id
                         AND keyworddefs.id = keywords.keywordid
                     ORDER BY keyworddefs.name");
            my @list;
            while (MoreSQLData()) {
                push(@list, FetchOneColumn());
720
            }
721 722 723
            SendSQL("UPDATE bugs SET keywords = " .
                    SqlQuote(join(', ', @list)) .
                    " WHERE bug_id = $id");
724 725 726
        }
    }

727
    my $query = "$basequery\nwhere bug_id = $id";
terry%netscape.com's avatar
terry%netscape.com committed
728
    
729 730 731 732
# print "<PRE>$query</PRE>\n";

    if ($::comma ne "") {
        SendSQL($query);
733 734 735
        SendSQL("select delta_ts from bugs where bug_id = $id");
    } else {
        SendSQL("select now()");
terry%netscape.com's avatar
terry%netscape.com committed
736
    }
737
    $timestamp = FetchOneColumn();
terry%netscape.com's avatar
terry%netscape.com committed
738
    
739 740
    if (defined $::FORM{'comment'}) {
        AppendComment($id, $::FORM{'who'}, $::FORM{'comment'});
terry%netscape.com's avatar
terry%netscape.com committed
741 742
    }
    
743
    if (defined $::FORM{'cc'} && $origcclist ne $::FORM{'cc'}) {
744
        SendSQL("delete from cc where bug_id = $id");
745 746
        foreach my $ccid (keys %ccids) {
            SendSQL("insert into cc (bug_id, who) values ($id, $ccid)");
terry%netscape.com's avatar
terry%netscape.com committed
747
        }
748 749 750 751 752 753 754 755 756
        my $newcclist = ShowCcList($id);
        if ($newcclist ne $origcclist) {
            my $col = GetFieldID('cc');
            my $origq = SqlQuote($origcclist);
            my $newq = SqlQuote($newcclist);
            SendSQL("INSERT INTO bugs_activity " .
                    "(bug_id,who,bug_when,fieldid,oldvalue,newvalue) VALUES " .
                    "($id,$whoid,'$timestamp',$col,$origq,$newq)");
        }
terry%netscape.com's avatar
terry%netscape.com committed
757 758
    }

759 760 761 762 763 764 765 766 767 768 769 770

    if (defined $::FORM{'dependson'}) {
        my $me = "blocked";
        my $target = "dependson";
        for (1..2) {
            SendSQL("select $target from dependencies where $me = $id order by $target");
            my %snapshot;
            my @oldlist;
            while (MoreSQLData()) {
                push(@oldlist, FetchOneColumn());
            }
            my @newlist = sort {$a <=> $b} @{$deps{$target}};
771 772
            @dependencychanged{@oldlist} = 1;
            @dependencychanged{@newlist} = 1;
773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800

            while (0 < @oldlist || 0 < @newlist) {
                if (@oldlist == 0 || (@newlist > 0 &&
                                      $oldlist[0] > $newlist[0])) {
                    $snapshot{$newlist[0]} = SnapShotDeps($newlist[0], $me,
                                                          $target);
                    shift @newlist;
                } elsif (@newlist == 0 || (@oldlist > 0 &&
                                           $newlist[0] > $oldlist[0])) {
                    $snapshot{$oldlist[0]} = SnapShotDeps($oldlist[0], $me,
                                                          $target);
                    shift @oldlist;
                } else {
                    if ($oldlist[0] != $newlist[0]) {
                        die "Error in list comparing code";
                    }
                    shift @oldlist;
                    shift @newlist;
                }
            }
            my @keys = keys(%snapshot);
            if (@keys) {
                my $oldsnap = SnapShotDeps($id, $target, $me);
                SendSQL("delete from dependencies where $me = $id");
                foreach my $i (@{$deps{$target}}) {
                    SendSQL("insert into dependencies ($me, $target) values ($id, $i)");
                }
                foreach my $k (@keys) {
801
                    LogDependencyActivity($k, $snapshot{$k}, $me, $target);
802 803 804 805 806 807 808 809 810 811 812
                }
                LogDependencyActivity($id, $oldsnap, $target, $me);
            }

            my $tmp = $me;
            $me = $target;
            $target = $tmp;
        }
    }


813 814 815 816
    # get a snapshot of the newly set values out of the database, 
    # and then generate any necessary bug activity entries by seeing 
    # what has changed since before we wrote out the new values.
    #
817
    my @newvalues = SnapShotBug($id);
818

819
    foreach my $c (@::log_columns) {
820 821
        my $col = $c;           # We modify it, don't want to modify array
                                # values in place.
822 823
        my $old = shift @oldvalues;
        my $new = shift @newvalues;
824 825 826 827 828 829
        if (!defined $old) {
            $old = "";
        }
        if (!defined $new) {
            $new = "";
        }
830
        if ($old ne $new) {
831 832 833
            if ($col eq 'assigned_to' || $col eq 'qa_contact') {
                $old = DBID_to_name($old) if $old != 0;
                $new = DBID_to_name($new) if $new != 0;
834 835 836
                $origcclist .= ",$old"; # make sure to send mail to people
                                        # if they are going to no longer get
                                        # updates about this bug.
terry%netscape.com's avatar
terry%netscape.com committed
837
            }
838
            if ($col eq 'product') {
839
                RemoveVotes($id, 0,
840 841
                            "This bug has been moved to a different product");
            }
842
            $col = GetFieldID($col);
843 844
            $old = SqlQuote($old);
            $new = SqlQuote($new);
845
            my $q = "insert into bugs_activity (bug_id,who,bug_when,fieldid,oldvalue,newvalue) values ($id,$whoid,'$timestamp',$col,$old,$new)";
846
            # puts "<pre>$q</pre>"
847
            SendSQL($q);
terry%netscape.com's avatar
terry%netscape.com committed
848 849 850
        }
    }
    
851
    print "<TABLE BORDER=1><TD><H2>Changes to bug $id submitted</H2>\n";
852
    SendSQL("unlock tables");
853
    system("./processmail", "-forcecc", $origcclist, $id, $::FORM{'who'});
854
    print "<TD><A HREF=\"show_bug.cgi?id=$id\">Back To BUG# $id</A></TABLE>\n";
855 856

    foreach my $k (keys(%dependencychanged)) {
857
        print "<TABLE BORDER=1><TD><H2>Checking for dependency changes on bug $k</H2>\n";
858 859 860 861
        system("./processmail $k $::FORM{'who'}");
        print "<TD><A HREF=\"show_bug.cgi?id=$k\">Go To BUG# $k</A></TABLE>\n";
    }

terry%netscape.com's avatar
terry%netscape.com committed
862 863
}

864
if (defined $::next_bug) {
865
    print("<P>The next bug in your list is:\n");
866 867
    $::FORM{'id'} = $::next_bug;
    print "<HR>\n";
terry%netscape.com's avatar
terry%netscape.com committed
868

869
    navigation_header();
870
    do "bug_form.pl";
terry%netscape.com's avatar
terry%netscape.com committed
871
} else {
872
    navigation_header();
873
    PutFooter();
terry%netscape.com's avatar
terry%netscape.com committed
874
}