Pg.pm 16.5 KB
Newer Older
1 2 3
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
4
#
5 6
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23

=head1 NAME

Bugzilla::DB::Pg - Bugzilla database compatibility layer for PostgreSQL

=head1 DESCRIPTION

This module overrides methods of the Bugzilla::DB module with PostgreSQL
specific implementation. It is instantiated by the Bugzilla::DB module
and should never be used directly.

For interface details see L<Bugzilla::DB> and L<DBI>.

=cut

package Bugzilla::DB::Pg;

24
use 5.10.1;
25
use strict;
26
use warnings;
27 28

use Bugzilla::Error;
29
use Bugzilla::Version;
30
use DBD::Pg;
31 32

# This module extends the DB interface via inheritance
33
use parent qw(Bugzilla::DB);
34

35
use constant BLOB_TYPE => {pg_type => DBD::Pg::PG_BYTEA};
36

37
sub new {
38 39 40
  my ($class, $params) = @_;
  my ($user, $pass, $host, $dbname, $port)
    = @$params{qw(db_user db_pass db_host db_name db_port)};
41

42 43 44 45
  # The default database name for PostgreSQL. We have
  # to connect to SOME database, even if we have
  # no $dbname parameter.
  $dbname ||= 'template1';
46

47 48 49 50
  # construct the DSN from the parameters we got
  my $dsn = "dbi:Pg:dbname=$dbname";
  $dsn .= ";host=$host" if $host;
  $dsn .= ";port=$port" if $port;
51

52 53 54
  # This stops Pg from printing out lots of "NOTICE" messages when
  # creating tables.
  $dsn .= ";options='-c client_min_messages=warning'";
55

56
  my $attrs = {pg_enable_utf8 => Bugzilla->params->{'utf8'}};
57

58 59
  my $self = $class->db_new(
    {dsn => $dsn, user => $user, pass => $pass, attrs => $attrs});
60

61 62 63
  # all class local variables stored in DBI derived class needs to have
  # a prefix 'private_'. See DBI documentation.
  $self->{private_bz_tables_locked} = "";
64

65 66
  # Needed by TheSchwartz
  $self->{private_bz_dsn} = $dsn;
67

68 69 70
  bless($self, $class);

  return $self;
71 72 73 74 75
}

# if last_insert_id is supported on PostgreSQL by lowest DBI/DBD version
# supported by Bugzilla, this implementation can be removed.
sub bz_last_key {
76
  my ($self, $table, $column) = @_;
77

78 79
  my $seq = $table . "_" . $column . "_seq";
  my ($last_insert_id) = $self->selectrow_array("SELECT CURRVAL('$seq')");
80

81
  return $last_insert_id;
82 83
}

84
sub sql_group_concat {
85 86 87 88 89 90 91 92 93
  my ($self, $text, $separator, $sort, $order_by) = @_;
  $sort = 1 if !defined $sort;
  $separator = $self->quote(', ') if !defined $separator;

  # PostgreSQL 8.x doesn't support STRING_AGG
  if (vers_cmp($self->bz_server_version, 9) < 0) {
    my $sql = "ARRAY_ACCUM($text)";
    if ($sort) {
      $sql = "ARRAY_SORT($sql)";
94
    }
95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118
    return "ARRAY_TO_STRING($sql, $separator)";
  }

  if ($order_by && $text =~ /^DISTINCT\s*(.+)$/i) {

    # Since Postgres (quite rightly) doesn't support "SELECT DISTINCT x
    # ORDER BY y", we need to sort the list, and then get the unique
    # values
    return
      "ARRAY_TO_STRING(ANYARRAY_UNIQ(ARRAY_AGG($1 ORDER BY $order_by)), $separator)";
  }

  # Determine the ORDER BY clause (if any)
  if ($order_by) {
    $order_by = " ORDER BY $order_by";
  }
  elsif ($sort) {

    # We don't include the DISTINCT keyword in an order by
    $text =~ /^(?:DISTINCT\s*)?(.+)$/i;
    $order_by = " ORDER BY $1";
  }

  return "STRING_AGG(${text}::text, $separator${order_by}::text)";
119 120
}

121
sub sql_istring {
122
  my ($self, $string) = @_;
123

124
  return "LOWER(${string}::text)";
125 126 127
}

sub sql_position {
128
  my ($self, $fragment, $text) = @_;
129

130
  return "POSITION(${fragment}::text IN ${text}::text)";
131 132
}

133
sub sql_like {
134 135
  my ($self, $fragment, $column, $not) = @_;
  $not //= '';
136

137 138 139 140
  return
      "${column}::text $not LIKE "
    . $self->sql_like_escape($fragment)
    . " ESCAPE '|'";
141 142 143
}

sub sql_ilike {
144 145
  my ($self, $fragment, $column, $not) = @_;
  $not //= '';
146

147 148 149 150
  return
      "${column}::text $not ILIKE "
    . $self->sql_like_escape($fragment)
    . " ESCAPE '|'";
151 152 153
}

sub sql_not_ilike {
154
  return shift->sql_ilike(@_, 'NOT');
155 156 157 158 159
}

# Escapes any % or _ characters which are special in a LIKE match.
# Also performs a $dbh->quote to escape any quote characters.
sub sql_like_escape {
160
  my ($self, $fragment) = @_;
161

162 163 164
  $fragment =~ s/\|/\|\|/g;    # escape the escape character if it appears
  $fragment =~ s/%/\|%/g;      # percent and underscore are the special match
  $fragment =~ s/_/\|_/g;      # characters in SQL.
165

166
  return $self->quote("%$fragment%");
167 168
}

169
sub sql_regexp {
170 171
  my ($self, $expr, $pattern, $nocheck, $real_pattern) = @_;
  $real_pattern ||= $pattern;
172

173
  $self->bz_check_regexp($real_pattern) if !$nocheck;
174

175
  return "${expr}::text ~* $pattern";
176 177 178
}

sub sql_not_regexp {
179 180
  my ($self, $expr, $pattern, $nocheck, $real_pattern) = @_;
  $real_pattern ||= $pattern;
181

182
  $self->bz_check_regexp($real_pattern) if !$nocheck;
183

184
  return "${expr}::text !~* $pattern";
185 186 187
}

sub sql_limit {
188 189 190 191 192 193 194 195
  my ($self, $limit, $offset) = @_;

  if (defined($offset)) {
    return "LIMIT $limit OFFSET $offset";
  }
  else {
    return "LIMIT $limit";
  }
196 197
}

198
sub sql_from_days {
199
  my ($self, $days) = @_;
200

201
  return "TO_TIMESTAMP('$days', 'J')::date";
202 203
}

204
sub sql_to_days {
205
  my ($self, $date) = @_;
206

207
  return "TO_CHAR(${date}::date, 'J')::int";
208 209 210
}

sub sql_date_format {
211 212 213 214 215 216 217 218 219 220 221 222 223 224
  my ($self, $date, $format) = @_;

  $format = "%Y.%m.%d %H:%i:%s" if !$format;

  $format =~ s/\%Y/YYYY/g;
  $format =~ s/\%y/YY/g;
  $format =~ s/\%m/MM/g;
  $format =~ s/\%d/DD/g;
  $format =~ s/\%a/Dy/g;
  $format =~ s/\%H/HH24/g;
  $format =~ s/\%i/MI/g;
  $format =~ s/\%s/SS/g;

  return "TO_CHAR($date, " . $self->quote($format) . ")";
225 226
}

227
sub sql_date_math {
228 229 230
  my ($self, $date, $operator, $interval, $units) = @_;

  return "$date $operator $interval * INTERVAL '1 $units'";
231 232
}

233
sub sql_string_concat {
234 235 236 237 238 239
  my ($self, @params) = @_;

  # Postgres 7.3 does not support concatenating of different types, so we
  # need to cast both parameters to text. Version 7.4 seems to handle this
  # properly, so when we stop support 7.3, this can be removed.
  return '(CAST(' . join(' AS text) || CAST(', @params) . ' AS text))';
240 241
}

242 243
# Tell us whether or not a particular sequence exists in the DB.
sub bz_sequence_exists {
244 245 246 247 248 249
  my ($self, $seq_name) = @_;
  my $exists
    = $self->selectrow_array(
    'SELECT 1 FROM pg_statio_user_sequences WHERE relname = ?',
    undef, $seq_name);
  return $exists || 0;
250 251
}

252
sub bz_explain {
253 254 255
  my ($self, $sql) = @_;
  my $explain = $self->selectcol_arrayref("EXPLAIN ANALYZE $sql");
  return join("\n", @$explain);
256 257
}

258 259 260 261
#####################################################################
# Custom Database Setup
#####################################################################

262
sub bz_check_server_version {
263 264 265 266 267 268 269 270 271 272 273 274
  my $self           = shift;
  my ($db)           = @_;
  my $server_version = $self->SUPER::bz_check_server_version(@_);
  my ($major_version, $minor_version) = $server_version =~ /^0*(\d+)\.0*(\d+)/;

  # Pg 9.0 requires DBD::Pg 2.17.2 in order to properly read bytea values.
  # Pg 9.2 requires DBD::Pg 2.19.3 as spclocation no longer exists.
  if ($major_version >= 9) {
    local $db->{dbd}->{version} = ($minor_version >= 2) ? '2.19.3' : '2.17.2';
    local $db->{name} = $db->{name} . " ${major_version}.$minor_version";
    Bugzilla::DB::_bz_check_dbd(@_);
  }
275 276
}

277
sub bz_setup_database {
278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296
  my $self = shift;
  $self->SUPER::bz_setup_database(@_);

  my ($has_plpgsql)
    = $self->selectrow_array(
    "SELECT COUNT(*) FROM pg_language WHERE lanname = 'plpgsql'");
  $self->do('CREATE LANGUAGE plpgsql') unless $has_plpgsql;

  if (vers_cmp($self->bz_server_version, 9) < 0) {

    # Custom Functions for Postgres 8
    my $function = 'array_accum';
    my $array_accum
      = $self->selectrow_array('SELECT 1 FROM pg_proc WHERE proname = ?',
      undef, $function);
    if (!$array_accum) {
      print "Creating function $function...\n";
      $self->do(
        "CREATE AGGREGATE array_accum (
297 298 299 300
                           SFUNC = array_append,
                           BASETYPE = anyelement,
                           STYPE = anyarray,
                           INITCOND = '{}' 
301 302 303
                       )"
      );
    }
304

305
    $self->do(<<'END');
306 307 308 309 310 311 312 313 314 315 316 317
CREATE OR REPLACE FUNCTION array_sort(ANYARRAY)
RETURNS ANYARRAY LANGUAGE SQL
IMMUTABLE STRICT
AS $$
SELECT ARRAY(
    SELECT $1[s.i] AS each_item
    FROM
        generate_series(array_lower($1,1), array_upper($1,1)) AS s(i)
    ORDER BY each_item
);
$$;
END
318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343
  }
  else {
    # Custom functions for Postgres 9.0+

   # -Copyright © 2013 Joshua D. Burns (JDBurnZ) and Message In Action LLC
   # JDBurnZ: https://github.com/JDBurnZ
   # Message In Action: https://www.messageinaction.com
   #
   #Permission is hereby granted, free of charge, to any person obtaining a copy of
   #this software and associated documentation files (the "Software"), to deal in
   #the Software without restriction, including without limitation the rights to
   #use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
   #the Software, and to permit persons to whom the Software is furnished to do so,
   #subject to the following conditions:
   #
   #The above copyright notice and this permission notice shall be included in all
   #copies or substantial portions of the Software.
   #
   #THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
   #IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
   #FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
   #COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
   #IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
   #CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
    $self->do(
      q|
344 345 346 347 348 349 350 351 352 353 354 355
            DROP FUNCTION IF EXISTS anyarray_uniq(anyarray);
            CREATE OR REPLACE FUNCTION anyarray_uniq(with_array anyarray)
            RETURNS anyarray AS $BODY$
            DECLARE
                -- The variable used to track iteration over "with_array".
                loop_offset integer;

                -- The array to be returned by this function.
                return_array with_array%TYPE := '{}';
            BEGIN
                IF with_array IS NULL THEN
                    return NULL;
356 357
                END IF;

358 359 360 361 362 363 364 365 366 367
                -- Iterate over each element in "concat_array".
                FOR loop_offset IN ARRAY_LOWER(with_array, 1)..ARRAY_UPPER(with_array, 1) LOOP
                    IF NOT with_array[loop_offset] = ANY(return_array) THEN
                        return_array = ARRAY_APPEND(return_array, with_array[loop_offset]);
                    END IF;
                END LOOP;

                RETURN return_array;
            END;
            $BODY$ LANGUAGE plpgsql;
368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414
        |
    );
  }

  # PostgreSQL doesn't like having *any* index on the thetext
  # field, because it can't have index data longer than 2770
  # characters on that field.
  $self->bz_drop_index('longdescs', 'longdescs_thetext_idx');

  # Same for all the comments fields in the fulltext table.
  $self->bz_drop_index('bugs_fulltext', 'bugs_fulltext_comments_idx');
  $self->bz_drop_index('bugs_fulltext', 'bugs_fulltext_comments_noprivate_idx');

  # PostgreSQL also wants an index for calling LOWER on
  # login_name, which we do with sql_istrcmp all over the place.
  $self->bz_add_index(
    'profiles',
    'profiles_login_name_lower_idx',
    {FIELDS => ['LOWER(login_name)'], TYPE => 'UNIQUE'}
  );

  # Now that Bugzilla::Object uses sql_istrcmp, other tables
  # also need a LOWER() index.
  _fix_case_differences('fielddefs', 'name');
  $self->bz_add_index('fielddefs', 'fielddefs_name_lower_idx',
    {FIELDS => ['LOWER(name)'], TYPE => 'UNIQUE'});
  _fix_case_differences('keyworddefs', 'name');
  $self->bz_add_index('keyworddefs', 'keyworddefs_name_lower_idx',
    {FIELDS => ['LOWER(name)'], TYPE => 'UNIQUE'});
  _fix_case_differences('products', 'name');
  $self->bz_add_index('products', 'products_name_lower_idx',
    {FIELDS => ['LOWER(name)'], TYPE => 'UNIQUE'});

  # bz_rename_column and bz_rename_table didn't correctly rename
  # the sequence.
  $self->_fix_bad_sequence('fielddefs', 'id', 'fielddefs_fieldid_seq',
    'fielddefs_id_seq');

  # If the 'tags' table still exists, then bz_rename_table()
  # will fix the sequence for us.
  if (!$self->bz_table_info('tags')) {
    my $res = $self->_fix_bad_sequence('tag', 'id', 'tags_id_seq', 'tag_id_seq');

    # If $res is true, then the sequence has been renamed, meaning that
    # the primary key must be renamed too.
    if ($res) {
      $self->do('ALTER INDEX tags_pkey RENAME TO tag_pkey');
415
    }
416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439
  }

  # Certain sequences got upgraded before we required Pg 8.3, and
  # so they were not properly associated with their columns.
  my @tables = $self->bz_table_list_real;
  foreach my $table (@tables) {
    my @columns = $self->bz_table_columns_real($table);
    foreach my $column (@columns) {

      # All our SERIAL pks have "id" in their name at the end.
      next unless $column =~ /id$/;
      my $sequence = "${table}_${column}_seq";
      if ($self->bz_sequence_exists($sequence)) {
        my $is_associated = $self->selectrow_array('SELECT pg_get_serial_sequence(?,?)',
          undef, $table, $column);
        next if $is_associated;
        print "Fixing $sequence to be associated" . " with $table.$column...\n";
        $self->do("ALTER SEQUENCE $sequence OWNED BY $table.$column");

        # In order to produce an exactly identical schema to what
        # a brand-new checksetup.pl run would produce, we also need
        # to re-set the default on this column.
        $self->do(
          "ALTER TABLE $table
440
                          ALTER COLUMN $column
441 442 443
                           SET DEFAULT nextval('$sequence')"
        );
      }
444
    }
445
  }
446 447
}

448
sub _fix_bad_sequence {
449 450 451 452 453 454 455 456 457 458 459 460 461
  my ($self, $table, $column, $old_seq, $new_seq) = @_;
  if ( $self->bz_column_info($table, $column)
    && $self->bz_sequence_exists($old_seq))
  {
    print "Fixing $old_seq sequence...\n";
    $self->do("ALTER SEQUENCE $old_seq RENAME TO $new_seq");
    $self->do(
      "ALTER TABLE $table ALTER COLUMN $column
                    SET DEFAULT NEXTVAL('$new_seq')"
    );
    return 1;
  }
  return 0;
462 463
}

464 465
# Renames things that differ only in case.
sub _fix_case_differences {
466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495
  my ($table, $field) = @_;
  my $dbh = Bugzilla->dbh;

  my $duplicates = $dbh->selectcol_arrayref(
    "SELECT DISTINCT LOWER($field) FROM $table 
        GROUP BY LOWER($field) HAVING COUNT(LOWER($field)) > 1"
  );

  foreach my $name (@$duplicates) {
    my $dups
      = $dbh->selectcol_arrayref(
      "SELECT $field FROM $table WHERE LOWER($field) = ?",
      undef, $name);
    my $primary = shift @$dups;
    foreach my $dup (@$dups) {
      my $new_name = "${dup}_";

      # Make sure the new name isn't *also* a duplicate.
      while (1) {
        last
          if (!$dbh->selectrow_array(
          "SELECT 1 FROM $table WHERE LOWER($field) = ?",
          undef, lc($new_name)
          ));
        $new_name .= "_";
      }
      print "$table '$primary' and '$dup' have names that differ",
        " only in case.\nRenaming '$dup' to '$new_name'...\n";
      $dbh->do("UPDATE $table SET $field = ? WHERE $field = ?",
        undef, $new_name, $dup);
496
    }
497
  }
498 499
}

500 501 502 503
#####################################################################
# Custom Schema Information Functions
#####################################################################

504
# Pg includes the PostgreSQL system tables in table_list_real, so
505 506
# we need to remove those.
sub bz_table_list_real {
507 508 509
  my $self = shift;

  my @full_table_list = $self->SUPER::bz_table_list_real(@_);
510

511 512 513
  # All PostgreSQL system tables start with "pg_" or "sql_"
  my @table_list = grep(!/(^pg_)|(^sql_)/, @full_table_list);
  return @table_list;
514 515
}

516
1;
517

518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550
=head2 Functions

=over

=item C<sql_like_escape>

=over

=item B<Description>

The postgres versions of the sql_like methods use the ANSI SQL LIKE
statements to perform substring searching.  To prevent issues with
users attempting to search for strings containing special characters
associated with LIKE, we escape them out so they don't affect the search
terms.

=item B<Params>

=over

=item C<$fragment> - The string fragment in need of escaping and quoting

=back

=item B<Returns>

The fragment with any pre existing %,_,| characters escaped out, wrapped in
percent characters and quoted.

=back

=back

551 552 553 554 555 556 557 558 559 560 561 562 563 564
=head1 B<Methods in need of POD>

=over

=item sql_date_format

=item bz_explain

=item bz_sequence_exists

=item bz_last_key

=item sql_position

565 566 567 568 569 570
=item sql_like

=item sql_ilike

=item sql_not_ilike

571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595
=item sql_limit

=item sql_not_regexp

=item sql_string_concat

=item sql_date_math

=item sql_to_days

=item bz_check_server_version

=item sql_from_days

=item bz_table_list_real

=item sql_regexp

=item sql_istring

=item sql_group_concat

=item bz_setup_database

=back