process_bug.cgi 63.3 KB
Newer Older
1
#!/usr/bonsaitools/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
terry%netscape.com's avatar
terry%netscape.com committed
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
terry%netscape.com's avatar
terry%netscape.com committed
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
terry%netscape.com's avatar
terry%netscape.com committed
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
terry%netscape.com's avatar
terry%netscape.com committed
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Dan Mosedale <dmose@mozilla.org>
23
#                 Dave Miller <justdave@syndicomm.com>
24
#                 Christopher Aillon <christopher@aillon.com>
25
#                 Myk Melez <myk@mozilla.org>
terry%netscape.com's avatar
terry%netscape.com committed
26

27 28
use strict;

29 30 31
my $UserInEditGroupSet = -1;
my $UserInCanConfirmGroupSet = -1;

32 33
use lib qw(.);

34
use Bugzilla::Constants;
35
require "CGI.pl";
36

37
use Bug;
38 39
use Bugzilla::User;

40
use RelationSet;
41

42 43 44
# Use the Flag module to modify flag data if the user set flags.
use Bugzilla::Flag;

45 46
# Shut up misguided -w warnings about "used only once":

47 48 49 50 51 52 53 54 55
use vars qw(%versions
          %components
          %COOKIE
          %legal_opsys
          %legal_platform
          %legal_priority
          %settable_resolution
          %target_milestone
          %legal_severity
56
           );
57

58
ConnectToDatabase();
59
my $whoid = confirm_login();
60

61 62
my $requiremilestone = 0;

63 64
use vars qw($template $vars);

65 66 67 68 69 70 71 72
######################################################################
# Begin Data/Security Validation
######################################################################

# Create a list of IDs of all bugs being modified in this request.
# This list will either consist of a single bug number from the "id"
# form/URL field or a series of numbers from multiple form/URL fields
# named "id_x" where "x" is the bug number.
73 74
# For each bug being modified, make sure its ID is a valid bug number 
# representing an existing bug that the user is authorized to access.
75 76
my @idlist;
if (defined $::FORM{'id'}) {
77
    ValidateBugID($::FORM{'id'});
78
    push @idlist, $::FORM{'id'};
79
} else {
80 81
    foreach my $i (keys %::FORM) {
        if ($i =~ /^id_([1-9][0-9]*)/) {
82 83 84
            my $id = $1;
            ValidateBugID($id);
            push @idlist, $id;
85
        }
86 87 88
    }
}

89
# Make sure there are bugs to process.
90
scalar(@idlist) || ThrowUserError("no_bugs_chosen");
91

92 93 94
# do a match on the fields if applicable

&Bugzilla::User::match_field({
95 96 97 98
    'qa_contact'                => { 'type' => 'single' },
    'newcc'                     => { 'type' => 'multi'  },
    'assigned_to'               => { 'type' => 'single' },
    '^requestee(_type)?-(\d+)$' => { 'type' => 'single' },
99 100
});

101 102 103 104 105 106 107 108 109 110
# If we are duping bugs, let's also make sure that we can change 
# the original.  This takes care of issue A on bug 96085.
if (defined $::FORM{'dup_id'} && $::FORM{'knob'} eq "duplicate") {
    ValidateBugID($::FORM{'dup_id'});

    # Also, let's see if the reporter has authorization to see the bug
    # to which we are duping.  If not we need to prompt.
    DuplicateUserConfirm();
}

111 112
ValidateComment($::FORM{'comment'});

113 114
$::FORM{'dontchange'} = '' unless exists $::FORM{'dontchange'};

115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132
# If the bug(s) being modified have dependencies, validate them
# and rebuild the list with the validated values.  This is important
# because there are situations where validation changes the value
# instead of throwing an error, f.e. when one or more of the values
# is a bug alias that gets converted to its corresponding bug ID
# during validation.
foreach my $field ("dependson", "blocked") {
    if (defined($::FORM{$field}) && $::FORM{$field} ne "") {
        my @validvalues;
        foreach my $id (split(/[\s,]+/, $::FORM{$field})) {
            next unless $id;
            ValidateBugID($id, 1);
            push(@validvalues, $id);
        }
        $::FORM{$field} = join(",", @validvalues);
    }
}

133 134 135 136
######################################################################
# End Data/Security Validation
######################################################################

137
print "Content-type: text/html\n\n";
138
$vars->{'title_tag'} = "bug_processed";
139 140 141 142 143 144 145 146 147 148 149

# Set the title if we can see a mid-air coming. This test may have false
# negatives, but never false positives, and should catch the majority of cases.
# It only works at all in the single bug case.
if (defined($::FORM{'id'})) {
    SendSQL("SELECT delta_ts FROM bugs WHERE bug_id = $::FORM{'id'}");
    my $delta_ts = FetchOneColumn();
    
    if (defined $::FORM{'delta_ts'} && $delta_ts && 
        $::FORM{'delta_ts'} ne $delta_ts) 
    {
150
        $vars->{'title_tag'} = "mid_air";
151 152
    }
}
153

154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170
# Set up the vars for nagiavtional <link> elements
my $next_bug;
if ($::COOKIE{"BUGLIST"} && $::FORM{'id'}) {
    my @bug_list = split(/:/, $::COOKIE{"BUGLIST"});
    $vars->{'bug_list'} = \@bug_list;
    my $cur = lsearch(\@bug_list, $::FORM{"id"});
    if ($cur >= 0 && $cur < $#bug_list) {
        $next_bug = $bug_list[$cur + 1];

        # Note that we only bother with the bug_id here, and get
        # the full bug object at the end, before showing the edit
        # page. If you change this, remember that we have not
        # done the security checks on the next bug yet
        $vars->{'bug'} = { bug_id => $next_bug };
    }
}

171 172
GetVersionTable();

173 174 175
CheckFormFieldDefined(\%::FORM, 'product');
CheckFormFieldDefined(\%::FORM, 'version');
CheckFormFieldDefined(\%::FORM, 'component');
176

177 178 179
# check if target milestone is defined - matthew@zeroknowledge.com
if ( Param("usetargetmilestone") ) {
  CheckFormFieldDefined(\%::FORM, 'target_milestone');
180 181
}

182 183 184
#
# This function checks if there is a comment required for a specific
# function and tests, if the comment was given.
185
# If comments are required for functions is defined by params.
186 187 188 189 190 191 192 193 194 195 196 197 198
#
sub CheckonComment( $ ) {
    my ($function) = (@_);
    
    # Param is 1 if comment should be added !
    my $ret = Param( "commenton" . $function );

    # Allow without comment in case of undefined Params.
    $ret = 0 unless ( defined( $ret ));

    if( $ret ) {
        if (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/) {
            # No comment - sorry, action not allowed !
199
            ThrowUserError("comment_required");
200 201 202 203 204 205 206
        } else {
            $ret = 0;
        }
    }
    return( ! $ret ); # Return val has to be inverted
}

207 208 209 210 211 212
# Figure out whether or not the user is trying to change the product
# (either the "product" variable is not set to "don't change" or the
# user is changing a single bug and has changed the bug's product),
# and make the user verify the version, component, target milestone,
# and bug groups if so.
if ( $::FORM{'id'} ) {
213 214
    SendSQL("SELECT name FROM products, bugs " .
            "WHERE products.id = bugs.product_id AND bug_id = $::FORM{'id'}");
215 216
    $::oldproduct = FetchSQLData();
}
217
if ((($::FORM{'id'} && $::FORM{'product'} ne $::oldproduct) 
218
     || (!$::FORM{'id'} && $::FORM{'product'} ne $::FORM{'dontchange'}))
219 220
    && CheckonComment( "reassignbycomponent" ))
{
221 222 223 224 225 226 227 228
    # Check to make sure they actually have the right to change the product
    if (!CheckCanChangeField('product', $::FORM{'id'}, $::oldproduct, $::FORM{'product'})) {
        $vars->{'oldvalue'} = $::oldproduct;
        $vars->{'newvalue'} = $::FORM{'product'};
        $vars->{'field'} = 'product';
        ThrowUserError("illegal_change", undef, "abort");            
    }
 
229
    CheckFormField(\%::FORM, 'product', \@::legal_product);
230
    my $prod = $::FORM{'product'};
231 232 233 234 235 236 237 238 239

    # note that when this script is called from buglist.cgi (rather
    # than show_bug.cgi), it's possible that the product will be changed
    # but that the version and/or component will be set to 
    # "--dont_change--" but still happen to be correct.  in this case,
    # the if statement will incorrectly trigger anyway.  this is a 
    # pretty weird case, and not terribly unreasonable behavior, but 
    # worthy of a comment, perhaps.
    #
240 241
    my $vok = lsearch($::versions{$prod}, $::FORM{'version'}) >= 0;
    my $cok = lsearch($::components{$prod}, $::FORM{'component'}) >= 0;
242 243 244 245 246 247

    my $mok = 1;   # so it won't affect the 'if' statement if milestones aren't used
    if ( Param("usetargetmilestone") ) {
       $mok = lsearch($::target_milestone{$prod}, $::FORM{'target_milestone'}) >= 0;
    }

248 249 250
    # If the product-specific fields need to be verified, or we need to verify
    # whether or not to add the bugs to their new product's group, display
    # a verification form.
251
    if (!$vok || !$cok || !$mok || (AnyDefaultGroups() && !defined($::FORM{'addtonewgroup'}))) {
252
        $vars->{'form'} = \%::FORM;
253
        $vars->{'mform'} = \%::MFORM;
254
        
255
        if (!$vok || !$cok || !$mok) {
256
            $vars->{'verify_fields'} = 1;
257 258 259 260
            my %defaults;
            # We set the defaults to these fields to the old value,
            # if its a valid option, otherwise we use the default where
            # thats appropriate
261
            $vars->{'versions'} = $::versions{$prod};
262 263 264
            if (lsearch($::versions{$prod}, $::FORM{'version'}) != -1) {
                $defaults{'version'} = $::FORM{'version'};
            }
265
            $vars->{'components'} = $::components{$prod};
266 267 268 269
            if (lsearch($::components{$prod}, $::FORM{'component'}) != -1) {
                $defaults{'component'} = $::FORM{'component'};
            }

270 271 272
            if (Param("usetargetmilestone")) {
                $vars->{'use_target_milestone'} = 1;
                $vars->{'milestones'} = $::target_milestone{$prod};
273 274 275 276 277
                if (lsearch($::target_milestone{$prod},
                            $::FORM{'target_milestone'}) != -1) {
                    $defaults{'target_milestone'} = $::FORM{'target_milestone'};
                } else {
                    SendSQL("SELECT defaultmilestone FROM products WHERE " .
278
                            "name = " . SqlQuote($prod));
279 280
                    $defaults{'target_milestone'} = FetchOneColumn();
                }
281
            }
282 283
            else {
                $vars->{'use_target_milestone'} = 0;
terry%netscape.com's avatar
terry%netscape.com committed
284
            }
285
            $vars->{'defaults'} = \%defaults;
286
        }
287 288
        else {
            $vars->{"verify_fields"} = 0;
terry%netscape.com's avatar
terry%netscape.com committed
289
        }
290
        
291
        $vars->{'verify_bug_group'} = (AnyDefaultGroups() 
292 293
                                       && !defined($::FORM{'addtonewgroup'}));
        
294
        $template->process("bug/process/verify-new-product.html.tmpl", $vars)
295
          || ThrowTemplateError($template->error());
296
        exit;
terry%netscape.com's avatar
terry%netscape.com committed
297 298 299 300
    }
}


301 302 303 304 305 306 307 308 309
# Checks that the user is allowed to change the given field.  Actually, right
# now, the rules are pretty simple, and don't look at the field itself very
# much, but that could be enhanced.

my $lastbugid = 0;
my $ownerid;
my $reporterid;
my $qacontactid;

310 311 312
################################################################################
# CheckCanChangeField() defines what users are allowed to change what bugs. You
# can add code here for site-specific policy changes, according to the 
313 314 315
# instructions given in the Bugzilla Guide and below. Note that you may also
# have to update the Bug::user() function to give people access to the options
# that they are permitted to change.
316 317 318 319 320 321 322 323 324 325 326 327 328 329 330
#
# CheckCanChangeField() should return true if the user is allowed to change this
# field, and false if they are not.
#
# The parameters to this function are as follows:
# $field    - name of the field in the bugs table the user is trying to change
# $bugid    - the ID of the bug they are changing
# $oldvalue - what they are changing it from
# $newvalue - what they are changing it to
#
# Note that this function is currently not called for dependency changes 
# (bug 141593) or CC changes, which means anyone can change those fields.
#
# Do not change the sections between START DO_NOT_CHANGE and END DO_NOT_CHANGE.
################################################################################
331
sub CheckCanChangeField {
332 333 334 335 336 337 338 339
    # START DO_NOT_CHANGE
    my ($field, $bugid, $oldvalue, $newvalue) = (@_);

    # Convert email IDs into addresses for $oldvalue
    if (($field eq "assigned_to") || 
        ($field eq "reporter") || 
        ($field eq "qa_contact")) 
    {
340 341 342 343 344 345 346 347
        if ($oldvalue =~ /^\d+$/) {
            if ($oldvalue == 0) {
                $oldvalue = "";
            } else {
                $oldvalue = DBID_to_name($oldvalue);
            }
        }
    }
348 349
    
    # Return true if they haven't changed this field at all.
350 351
    if ($oldvalue eq $newvalue) {
        return 1;
352 353
    }    
    elsif (trim($oldvalue) eq trim($newvalue)) {
354 355
        return 1;
    }
356 357 358 359 360 361
    
    # A resolution change is always accompanied by a status change. So, we 
    # always OK resolution changes; if they really can't do this, we will 
    # notice it when status is checked. 
    if ($field eq "resolution") { 
        return 1;             
362
    }
363 364 365 366 367
    # END DO_NOT_CHANGE

    # Allow anyone to change comments.
    if ($field =~ /^longdesc/) {
        return 1;
368
    }
369 370 371 372 373
    
    # START DO_NOT_CHANGE
    # Find out whether the user is a member of the "editbugs" and/or
    # "canconfirm" groups. $UserIn*GroupSet are caches of the return value of 
    # the UserInGroup calls.
374 375 376
    if ($UserInEditGroupSet < 0) {
        $UserInEditGroupSet = UserInGroup("editbugs");
    }
377 378 379 380 381 382 383
    
    if ($UserInCanConfirmGroupSet < 0) {
        $UserInCanConfirmGroupSet = UserInGroup("canconfirm");
    }
    # END DO_NOT_CHANGE
    
    # Allow anyone with "editbugs" to change anything.
384 385 386
    if ($UserInEditGroupSet) {
        return 1;
    }
387 388 389 390 391 392 393 394 395 396 397 398 399
    
    # Allow anyone with "canconfirm" to confirm bugs.
    if (($field eq "bug_status") && 
        ($oldvalue eq $::unconfirmedstate) &&
        IsOpenedState($newvalue) &&
        $UserInCanConfirmGroupSet) 
    {
        return 1;
    }
    
    # START DO_NOT_CHANGE
    # $reporterid, $ownerid and $qacontactid are caches of the results of
    # the call to find out the owner, reporter and qacontact of the current bug.
400
    if ($lastbugid != $bugid) {
401 402
        SendSQL("SELECT reporter, assigned_to, qa_contact FROM bugs
                 WHERE bug_id = $bugid");
403
        ($reporterid, $ownerid, $qacontactid) = (FetchSQLData());
404 405 406 407 408 409
    }    
    # END DO_NOT_CHANGE

    # Allow the owner to change anything.
    if ($ownerid eq $whoid) {
        return 1;
410
    }
411 412 413
    
    # Allow the QA contact to change anything.
    if ($qacontactid eq $whoid) {
414 415
        return 1;
    }
416 417 418 419 420 421 422 423 424 425 426
    
    # The reporter's a more complicated case...
    if ($reporterid eq $whoid) {
        # Reporter may not:
        # - confirm his own bugs (this assumes he doesn't have canconfirm, or we
        #   would have returned "1" earlier)
        if (($field eq "bug_status") && 
            ($oldvalue eq $::unconfirmedstate) &&
             IsOpenedState($newvalue))
        {
            return 0;
427
        }
428 429 430 431 432 433 434 435 436 437 438
        
        # - change the target milestone            
        if  ($field eq "target_milestone")  {
            return 0;
        }       
        
        # - change the priority (unless he could have set it originally)
        if (($field eq "priority") &&
            !Param('letsubmitterchoosepriority'))
        {
            return 0;
439
        }
440 441
        
        # Allow reporter to change anything else.
442
        return 1;
443
    }
444 445 446 447
  
    # If we haven't returned by this point, then the user doesn't have the
    # necessary permissions to change this field.
    return 0;
448 449
}

450 451
# Confirm that the reporter of the current bug can access the bug we are duping to.
sub DuplicateUserConfirm {
452 453 454 455 456
    # if we've already been through here, then exit
    if (defined $::FORM{'confirm_add_duplicate'}) {
        return;
    }

457 458 459 460 461 462
    my $dupe = trim($::FORM{'id'});
    my $original = trim($::FORM{'dup_id'});
    
    SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($dupe));
    my $reporter = FetchOneColumn();

463
    if (CanSeeBug($original, $reporter)) {
464 465 466
        $::FORM{'confirm_add_duplicate'} = "1";
        return;
    }
467 468

    SendSQL("SELECT cclist_accessible FROM bugs WHERE bug_id = $original");
469
    $vars->{'cclist_accessible'} = FetchOneColumn();
470
    
471 472 473
    # Once in this part of the subroutine, the user has not been auto-validated
    # and the duper has not chosen whether or not to add to CC list, so let's
    # ask the duper what he/she wants to do.
474
    
475
    $vars->{'form'} = \%::FORM;
476
    $vars->{'mform'} = \%::MFORM;
477 478 479 480 481
    $vars->{'original_bug_id'} = $original;
    $vars->{'duplicate_bug_id'} = $dupe;
    
    # Confirm whether or not to add the reporter to the cc: list
    # of the original bug (the one this bug is being duped against).
482
    print "Content-type: text/html\n\n";
483
    $template->process("bug/process/confirm-duplicate.html.tmpl", $vars)
484
      || ThrowTemplateError($template->error());
485 486
    exit;
} # end DuplicateUserConfirm()
487

488
if (defined $::FORM{'id'}) {
489 490 491 492 493 494 495
    # since this means that we were called from show_bug.cgi, now is a good
    # time to do a whole bunch of error checking that can't easily happen when
    # we've been called from buglist.cgi, because buglist.cgi only tweaks
    # values that have been changed instead of submitting all the new values.
    # (XXX those error checks need to happen too, but implementing them 
    # is more work in the current architecture of this script...)
    #
496 497 498 499 500 501 502 503 504 505 506 507
    CheckFormField(\%::FORM, 'rep_platform', \@::legal_platform);
    CheckFormField(\%::FORM, 'priority', \@::legal_priority);
    CheckFormField(\%::FORM, 'bug_severity', \@::legal_severity);
    CheckFormField(\%::FORM, 'component', 
                   \@{$::components{$::FORM{'product'}}});
    CheckFormFieldDefined(\%::FORM, 'bug_file_loc');
    CheckFormFieldDefined(\%::FORM, 'short_desc');
    CheckFormField(\%::FORM, 'product', \@::legal_product);
    CheckFormField(\%::FORM, 'version', 
                   \@{$::versions{$::FORM{'product'}}});
    CheckFormField(\%::FORM, 'op_sys', \@::legal_opsys);
    CheckFormFieldDefined(\%::FORM, 'longdesclength');
terry%netscape.com's avatar
terry%netscape.com committed
508 509
}

510
my $action = '';
511
if (defined $::FORM{action}) {
512
  $action = trim($::FORM{action});
513
}
514
if (Param("move-enabled") && $action eq Param("move-button-text")) {
515 516 517 518 519 520 521
  $::FORM{'buglist'} = join (":", @idlist);
  do "move.pl" || die "Error executing move.cgi: $!";
  PutFooter();
  exit;
}


522 523 524 525 526 527 528
$::query = "update bugs\nset";
$::comma = "";
umask(0);

sub DoComma {
    $::query .= "$::comma\n    ";
    $::comma = ",";
terry%netscape.com's avatar
terry%netscape.com committed
529 530
}

531
sub DoConfirm {
532
    if (CheckCanChangeField("canconfirm", $::FORM{'id'}, 0, 1)) {
533 534 535 536 537 538
        DoComma();
        $::query .= "everconfirmed = 1";
    }
}


539 540
sub ChangeStatus {
    my ($str) = (@_);
541 542
    if (!$::FORM{'dontchange'} ||
       ($str ne $::FORM{'dontchange'})) {
543
        DoComma();
544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575
        if ($::FORM{knob} eq 'reopen') {
            # When reopening, we need to check whether the bug was ever
            # confirmed or not
            $::query .= "bug_status = IF(everconfirmed = 1, " .
                         SqlQuote($str) . ", " .
                         SqlQuote($::unconfirmedstate) . ")";
        } elsif (IsOpenedState($str)) {
            # Note that we cannot combine this with the above branch - here we
            # need to check if bugs.bug_status is open, (since we don't want to
            # reopen closed bugs when reassigning), while above the whole point
            # is to reopen a closed bug.
            # Currently, the UI doesn't permit a user to reassign a closed bug
            # from the single bug page (only during a mass change), but they
            # could still hack the submit, so don't restrict this extended
            # check to the mass change page for safety/sanity/consistency
            # purposes.

            # The logic for this block is:
            # If the new state is open:
            #   If the old state was open
            #     If the bug was confirmed
            #       - move it to the new state
            #     Else
            #       - Set the state to unconfirmed
            #   Else
            #     - leave it as it was

            # This is valid only because 'reopen' is the only thing which moves
            # from closed to open, and its handled above
            # This also relies on the fact that confirming and accepting have
            # already called DoConfirm before this is called

576 577
            my @open_state = map(SqlQuote($_), OpenStates());
            my $open_state = join(", ", @open_state);
578 579 580 581 582
            $::query .= "bug_status = IF(bug_status IN($open_state), " .
                                        "IF(everconfirmed = 1, " .
                                            SqlQuote($str) . ", " .
                                            SqlQuote($::unconfirmedstate) . " ), " .
                                        "bug_status)";
583
        } else {
584
            $::query .= "bug_status = " . SqlQuote($str);
585
        }
586 587 588
        $::FORM{'bug_status'} = $str; # Used later for call to
                                      # CheckCanChangeField to make sure this
                                      # is really kosher.
terry%netscape.com's avatar
terry%netscape.com committed
589 590 591
    }
}

592 593
sub ChangeResolution {
    my ($str) = (@_);
594 595
    if (!$::FORM{'dontchange'} ||
       ($str ne $::FORM{'dontchange'})) {
596
        DoComma();
597
        $::query .= "resolution = " . SqlQuote($str);
terry%netscape.com's avatar
terry%netscape.com committed
598 599 600
    }
}

601 602 603 604
# Changing this so that it will process groups from checkboxes instead of
# select lists.  This means that instead of looking for the bit-X values in
# the form, we need to loop through all the bug groups this user has access
# to, and for each one, see if it's selected.
605 606
# If the form element isn't present, or the user isn't in the group, leave
# it as-is
607

608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626
my @groupAdd = ();
my @groupDel = ();

SendSQL("SELECT groups.id, isactive FROM groups, user_group_map WHERE " .
        "groups.id = user_group_map.group_id AND " .
        "user_group_map.user_id = $::userid AND " .
        "isbless = 0 AND isbuggroup = 1");
while (my ($b, $isactive) = FetchSQLData()) {
    # The multiple change page may not show all groups a bug is in
    # (eg product groups when listing more than one product)
    # Only consider groups which were present on the form. We can't do this
    # for single bug changes because non-checked checkboxes aren't present.
    # All the checkboxes should be shown in that case, though, so its not
    # an issue there
    if ($::FORM{'id'} || exists $::FORM{"bit-$b"}) {
        if (!$::FORM{"bit-$b"}) {
            push(@groupDel, $b);
        } elsif ($::FORM{"bit-$b"} == 1 && $isactive) {
            push(@groupAdd, $b);
627 628
        }
    }
629 630
}

631
foreach my $field ("rep_platform", "priority", "bug_severity",          
632 633
                   "summary", "bug_file_loc", "short_desc",
                   "version", "op_sys",
634
                   "target_milestone", "status_whiteboard") {
635
    if (defined $::FORM{$field}) {
636 637
        if (!$::FORM{'dontchange'}
            || $::FORM{$field} ne $::FORM{'dontchange'}) {
638
            DoComma();
639
            $::query .= "$field = " . SqlQuote(trim($::FORM{$field}));
terry%netscape.com's avatar
terry%netscape.com committed
640 641 642 643
        }
    }
}

644
my $prod_id; # Remember, can't use this for mass changes
645
if ($::FORM{'product'} ne $::FORM{'dontchange'}) {
646
    $prod_id = get_product_id($::FORM{'product'});
647
    $prod_id ||
648
      ThrowUserError("invalid_product_name", {product => $::FORM{'product'}});
649
      
650 651 652 653 654 655 656 657 658 659
    DoComma();
    $::query .= "product_id = $prod_id";
} else {
    SendSQL("SELECT DISTINCT product_id FROM bugs WHERE bug_id IN (" .
            join(',', @idlist) . ") LIMIT 2");
    $prod_id = FetchOneColumn();
    $prod_id = undef if (FetchOneColumn());
}

my $comp_id; # Remember, can't use this for mass changes
660
if ($::FORM{'component'} ne $::FORM{'dontchange'}) {
661
    if (!defined $prod_id) {
662
        ThrowUserError("no_component_change_for_multiple_products");
663 664 665
    }
    $comp_id = get_component_id($prod_id,
                                $::FORM{'component'});
666 667 668 669
    $comp_id || ThrowCodeError("invalid_component", 
                               {component => $::FORM{'component'},
                                product => $::FORM{'product'}});
    
670 671 672 673
    DoComma();
    $::query .= "component_id = $comp_id";
}

674 675 676 677 678 679 680 681 682 683 684 685 686
# If this installation uses bug aliases, and the user is changing the alias,
# add this change to the query.
if (Param("usebugaliases") && defined($::FORM{'alias'})) {
    my $alias = trim($::FORM{'alias'});
    
    # Since aliases are unique (like bug numbers), they can only be changed
    # for one bug at a time, so ignore the alias change unless only a single
    # bug is being changed.
    if (scalar(@idlist) == 1) {
        # Validate the alias if the user entered one.
        if ($alias ne "") {
            # Make sure the alias isn't too long.
            if (length($alias) > 20) {
687
                ThrowUserError("alias_too_long");
688 689 690 691
            }

            # Make sure the alias is unique.
            my $escaped_alias = SqlQuote($alias);
692 693
            $vars->{'alias'} = $alias;
            
694 695 696
            SendSQL("SELECT bug_id FROM bugs WHERE alias = $escaped_alias " . 
                    "AND bug_id != $idlist[0]");
            my $id = FetchOneColumn();
697
            
698
            if ($id) {
699 700
                $vars->{'bug_link'} = GetBugLink($id, "Bug $id");
                ThrowUserError("alias_in_use");
701 702 703 704
            }

            # Make sure the alias isn't just a number.
            if ($alias =~ /^\d+$/) {
705
                ThrowUserError("alias_is_numeric");
706 707 708 709
            }

            # Make sure the alias has no commas or spaces.
            if ($alias =~ /[, ]/) {
710
                ThrowUserError("alias_has_comma_or_space");
711 712 713 714 715 716 717 718 719
            }
        }
        
        # Add the alias change to the query.  If the field contains the blank 
        # value, make the field be NULL to indicate that the bug has no alias.
        # Otherwise, if the field contains a value, update the record 
        # with that value.
        DoComma();
        $::query .= "alias = ";
720 721 722 723 724
        if ($alias eq "") {
            $::query .= "NULL";
        } else {
            $::query .= SqlQuote($alias);
        }
725 726
    }
}
727

728 729
if (defined $::FORM{'qa_contact'}) {
    my $name = trim($::FORM{'qa_contact'});
730
    if ($name ne $::FORM{'dontchange'}) {
731 732 733 734 735 736 737 738 739
        my $id = 0;
        if ($name ne "") {
            $id = DBNameToIdAndCheck($name);
        }
        DoComma();
        $::query .= "qa_contact = $id";
    }
}

740
# jeff.hedlund@matrixsi.com time tracking data processing:
741 742 743 744 745 746 747 748 749 750 751 752 753 754 755
if (UserInGroup(Param('timetrackinggroup'))) {
    foreach my $field ("estimated_time", "remaining_time") {
        if (defined $::FORM{$field}) {
            my $er_time = trim($::FORM{$field});
            if ($er_time ne $::FORM{'dontchange'}) {
                if ($er_time > 99999.99) {
                    ThrowUserError("value_out_of_range", {field => $field});
                }
                if ($er_time =~ /^(?:\d+(?:\.\d*)?|\.\d+)$/) {
                    DoComma();
                    $::query .= "$field = " . SqlQuote($er_time);
                } else {
                    $vars->{'field'} = $field;
                    ThrowUserError("need_positive_number");
                }
756 757 758 759
            }
        }
    }
}
760

761 762
# If the user is submitting changes from show_bug.cgi for a single bug,
# and that bug is restricted to a group, process the checkboxes that
763
# allowed the user to set whether or not the reporter
764 765
# and cc list can see the bug even if they are not members of all groups 
# to which the bug is restricted.
766
if ( $::FORM{'id'} ) {
767 768 769
    SendSQL("SELECT group_id FROM bug_group_map WHERE bug_id = $::FORM{'id'}");
    my ($havegroup) = FetchSQLData();
    if ( $havegroup ) {
770 771 772 773 774 775 776 777 778 779
        DoComma();
        $::FORM{'reporter_accessible'} = $::FORM{'reporter_accessible'} ? '1' : '0';
        $::query .= "reporter_accessible = $::FORM{'reporter_accessible'}";

        DoComma();
        $::FORM{'cclist_accessible'} = $::FORM{'cclist_accessible'} ? '1' : '0';
        $::query .= "cclist_accessible = $::FORM{'cclist_accessible'}";
    }
}

780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795
if ($::FORM{'id'} && 
    (Param("insidergroup") && UserInGroup(Param("insidergroup")))) {
    detaint_natural($::FORM{'id'});
    foreach my $field (keys %::FORM) {
        if ($field =~ /when-([0-9]+)/) {
            my $sequence = $1;
            my $private = $::FORM{"isprivate-$sequence"} ? 1 : 0 ;
            if ($private != $::FORM{"oisprivate-$sequence"}) {
                detaint_natural($::FORM{"$field"});
                SendSQL("UPDATE longdescs SET isprivate = $private 
                    WHERE bug_id = $::FORM{'id'} AND bug_when = " . $::FORM{"$field"});
            }
        }

    }
}
796

797
my $duplicate = 0;
798

799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816
# We need to check the addresses involved in a CC change before we touch any bugs.
# What we'll do here is formulate the CC data into two hashes of ID's involved
# in this CC change.  Then those hashes can be used later on for the actual change.
my (%cc_add, %cc_remove);
if (defined $::FORM{newcc} || defined $::FORM{removecc} || defined $::FORM{masscc}) {
    # If masscc is defined, then we came from buglist and need to either add or
    # remove cc's... otherwise, we came from bugform and may need to do both.
    my ($cc_add, $cc_remove) = "";
    if (defined $::FORM{masscc}) {
        if ($::FORM{ccaction} eq 'add') {
            $cc_add = $::FORM{masscc};
        } elsif ($::FORM{ccaction} eq 'remove') {
            $cc_remove = $::FORM{masscc};
        }
    } else {
        $cc_add = $::FORM{newcc};
        # We came from bug_form which uses a select box to determine what cc's
        # need to be removed...
817
        if (defined $::FORM{removecc} && $::FORM{cc}) {
818 819 820 821 822
            $cc_remove = join (",", @{$::MFORM{cc}});
        }
    }

    if ($cc_add) {
823 824
        $cc_add =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_add) ) {
825 826 827 828 829
            my $pid = DBNameToIdAndCheck($person);
            $cc_add{$pid} = $person;
        }
    }
    if ($cc_remove) {
830 831
        $cc_remove =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_remove) ) {
832 833 834 835 836 837 838
            my $pid = DBNameToIdAndCheck($person);
            $cc_remove{$pid} = $person;
        }
    }
}


839
CheckFormFieldDefined(\%::FORM, 'knob');
840 841 842 843
SWITCH: for ($::FORM{'knob'}) {
    /^none$/ && do {
        last SWITCH;
    };
844 845 846 847 848
    /^confirm$/ && CheckonComment( "confirm" ) && do {
        DoConfirm();
        ChangeStatus('NEW');
        last SWITCH;
    };
849
    /^accept$/ && CheckonComment( "accept" ) && do {
850
        DoConfirm();
851
        ChangeStatus('ASSIGNED');
852 853
        if (Param("musthavemilestoneonaccept") &&
                scalar(@{$::target_milestone{$::FORM{'product'}}}) > 1) {
854 855 856 857
            if (Param("usetargetmilestone")) {
                $requiremilestone = 1;
            }
        }
858 859
        last SWITCH;
    };
860
    /^clearresolution$/ && CheckonComment( "clearresolution" ) && do {
861 862 863
        ChangeResolution('');
        last SWITCH;
    };
864
    /^resolve$/ && CheckonComment( "resolve" ) && do {
865 866 867 868 869 870
        if (UserInGroup(Param('timetrackinggroup'))) {
            if (defined $::FORM{'remaining_time'} &&
                $::FORM{'remaining_time'} > 0) {
                ThrowUserError("resolving_remaining_time");
            }
        }
871 872
        # Check here, because its the only place we require the resolution
        CheckFormField(\%::FORM, 'resolution', \@::settable_resolution);
873 874 875 876
        ChangeStatus('RESOLVED');
        ChangeResolution($::FORM{'resolution'});
        last SWITCH;
    };
877
    /^reassign$/ && CheckonComment( "reassign" ) && do {
878 879 880
        if ($::FORM{'andconfirm'}) {
            DoConfirm();
        }
881 882
        ChangeStatus('NEW');
        DoComma();
883 884 885
        if (!defined$::FORM{'assigned_to'} ||
            trim($::FORM{'assigned_to'}) eq "") {
            ThrowUserError("reassign_to_empty");
886
        }
887
        my $newid = DBNameToIdAndCheck(trim($::FORM{'assigned_to'}));
888 889 890
        $::query .= "assigned_to = $newid";
        last SWITCH;
    };
891
    /^reassignbycomponent$/  && CheckonComment( "reassignbycomponent" ) && do {
892
        if ($::FORM{'product'} eq $::FORM{'dontchange'}) {
893
            ThrowUserError("need_product");
894
        }
895
        if ($::FORM{'component'} eq $::FORM{'dontchange'}) {
896
            ThrowUserError("need_component");
terry%netscape.com's avatar
terry%netscape.com committed
897
        }
898 899 900
        if ($::FORM{'compconfirm'}) {
            DoConfirm();
        }
901
        ChangeStatus('NEW');
902 903
        SendSQL("SELECT initialowner FROM components " .
                "WHERE components.id = $comp_id");
904 905
        my $newid = FetchOneColumn();
        my $newname = DBID_to_name($newid);
906 907
        DoComma();
        $::query .= "assigned_to = $newid";
908
        if (Param("useqacontact")) {
909 910
            SendSQL("SELECT initialqacontact FROM components " .
                    "WHERE components.id = $comp_id");
911
            my $qacontact = FetchOneColumn();
912
            if (defined $qacontact && $qacontact != 0) {
913
                DoComma();
914
                $::query .= "qa_contact = $qacontact";
915 916
            }
        }
917 918
        last SWITCH;
    };   
919
    /^reopen$/  && CheckonComment( "reopen" ) && do {
920
        ChangeStatus('REOPENED');
921
        ChangeResolution('');
922 923
        last SWITCH;
    };
924
    /^verify$/ && CheckonComment( "verify" ) && do {
925 926 927
        ChangeStatus('VERIFIED');
        last SWITCH;
    };
928
    /^close$/ && CheckonComment( "close" ) && do {
929 930 931
        ChangeStatus('CLOSED');
        last SWITCH;
    };
932
    /^duplicate$/ && CheckonComment( "duplicate" ) && do {
933 934
        ChangeStatus('RESOLVED');
        ChangeResolution('DUPLICATE');
935
        CheckFormFieldDefined(\%::FORM,'dup_id');
936
        my $num = trim($::FORM{'dup_id'});
937 938 939
        SendSQL("SELECT bug_id FROM bugs WHERE bug_id = " . SqlQuote($num));
        $num = FetchOneColumn();
        if (!$num) {
940
            ThrowUserError("dupe_invalid_bug_id")
terry%netscape.com's avatar
terry%netscape.com committed
941
        }
942
        if (!defined($::FORM{'id'}) || $num == $::FORM{'id'}) {
943
            ThrowUserError("dupe_of_self_disallowed");
terry%netscape.com's avatar
terry%netscape.com committed
944
        }
945 946 947 948
        my $checkid = trim($::FORM{'id'});
        SendSQL("SELECT bug_id FROM bugs where bug_id = " .  SqlQuote($checkid));
        $checkid = FetchOneColumn();
        if (!$checkid) {
949 950
            $vars->{'bug_id'} = $checkid;
            ThrowUserError("invalid_bug_id");
951
        }
952
        $::FORM{'comment'} .= "\n\n*** This bug has been marked as a duplicate of $num ***";
953
        $duplicate = $num;
954

955 956
        last SWITCH;
    };
957 958 959
    
    $vars->{'action'} = $::FORM{'knob'};
    ThrowCodeError("unknown_action");
terry%netscape.com's avatar
terry%netscape.com committed
960 961 962
}


963
if ($#idlist < 0) {
964
    ThrowUserError("no_bugs_chosen");
terry%netscape.com's avatar
terry%netscape.com committed
965 966
}

967 968 969 970 971

my @keywordlist;
my %keywordseen;

if ($::FORM{'keywords'}) {
972 973 974 975
    foreach my $keyword (split(/[\s,]+/, $::FORM{'keywords'})) {
        if ($keyword eq '') {
            next;
        }
976
        my $i = GetKeywordIdFromName($keyword);
977
        if (!$i) {
978
            $vars->{keyword} = $keyword;
979
            ThrowUserError("unknown_keyword");
980 981 982 983 984 985 986 987
        }
        if (!$keywordseen{$i}) {
            push(@keywordlist, $i);
            $keywordseen{$i} = 1;
        }
    }
}

988 989
my $keywordaction = $::FORM{'keywordaction'} || "makeexact";

990
if ($::comma eq ""
991
    && (! @groupAdd) && (! @groupDel)
992
    && (! @::legal_keywords || (0 == @keywordlist && $keywordaction ne "makeexact"))
993 994
    && defined $::FORM{'masscc'} && ! $::FORM{'masscc'}
    ) {
995
    if (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/) {
996
        ThrowUserError("bugs_not_changed");
terry%netscape.com's avatar
terry%netscape.com committed
997 998 999
    }
}

1000
my $basequery = $::query;
1001
my $delta_ts;
terry%netscape.com's avatar
terry%netscape.com committed
1002

1003

1004 1005
sub SnapShotBug {
    my ($id) = (@_);
1006
    SendSQL("select delta_ts, " . join(',', @::log_columns) .
1007
            " from bugs where bug_id = $id");
1008 1009
    my @row = FetchSQLData();
    $delta_ts = shift @row;
1010

1011
    return @row;
terry%netscape.com's avatar
terry%netscape.com committed
1012 1013 1014
}


1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026
sub SnapShotDeps {
    my ($i, $target, $me) = (@_);
    SendSQL("select $target from dependencies where $me = $i order by $target");
    my @list;
    while (MoreSQLData()) {
        push(@list, FetchOneColumn());
    }
    return join(',', @list);
}


my $timestamp;
1027
my $bug_changed;
1028

1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047
sub FindWrapPoint {
    my ($string, $startpos) = @_;
    if (!$string) { return 0 }
    if (length($string) < $startpos) { return length($string) }
    my $wrappoint = rindex($string, ",", $startpos); # look for comma
    if ($wrappoint < 0) {  # can't find comma
        $wrappoint = rindex($string, " ", $startpos); # look for space
        if ($wrappoint < 0) {  # can't find space
            $wrappoint = rindex($string, "-", $startpos); # look for hyphen
            if ($wrappoint < 0) {  # can't find hyphen
                $wrappoint = $startpos;  # just truncate it
            } else {
                $wrappoint++; # leave hyphen on the left side
            }
        }
    }
    return $wrappoint;
}

1048 1049 1050 1051
sub LogDependencyActivity {
    my ($i, $oldstr, $target, $me) = (@_);
    my $newstr = SnapShotDeps($i, $target, $me);
    if ($oldstr ne $newstr) {
1052 1053
        # Figure out what's really different...
        my ($removed, $added) = DiffStrings($oldstr, $newstr);
1054
        LogActivityEntry($i,$target,$removed,$added,$whoid,$timestamp);
1055 1056
        # update timestamp on target bug so midairs will be triggered
        SendSQL("UPDATE bugs SET delta_ts=NOW() WHERE bug_id=$i");
1057
        $bug_changed = 1;
1058 1059 1060 1061 1062
        return 1;
    }
    return 0;
}

1063
# this loop iterates once for each bug to be processed (eg when this script
1064
# is called with multiple bugs selected from buglist.cgi instead of
1065 1066
# show_bug.cgi).
#
1067
foreach my $id (@idlist) {
1068
    my %dependencychanged;
1069
    $bug_changed = 0;
1070 1071
    my $write = "WRITE";        # Might want to make a param to control
                                # whether we do LOW_PRIORITY ...
1072
    SendSQL("LOCK TABLES bugs $write, bugs_activity $write, cc $write, " .
1073
            "cc AS selectVisible_cc $write, " .
1074
            "profiles $write, dependencies $write, votes $write, " .
1075
            "products READ, components READ, " .
1076
            "keywords $write, longdescs $write, fielddefs $write, " .
1077
            "bug_group_map $write, flags $write, duplicates $write," .
1078 1079
            "user_group_map READ, flagtypes READ, " . 
            "flaginclusions AS i READ, flagexclusions AS e READ, " .
1080 1081 1082 1083
            "keyworddefs READ, groups READ, attachments READ, " .
            "group_control_map AS oldcontrolmap READ, " .
            "group_control_map AS newcontrolmap READ, " .
            "group_control_map READ");
1084
    my @oldvalues = SnapShotBug($id);
1085
    my %oldhash;
1086 1087 1088 1089 1090 1091 1092
    # Fun hack.  @::log_columns only contains the component_id,
    # not the name (since bug 43600 got fixed).  So, we need to have
    # this id ready for the loop below, otherwise anybody can
    # change the component of a bug (we checked product above).
    # http://bugzilla.mozilla.org/show_bug.cgi?id=180545
    my $product_id = get_product_id($::FORM{'product'});
    $::FORM{'component_id'} = get_component_id($product_id, $::FORM{'component'});
1093 1094
    my $i = 0;
    foreach my $col (@::log_columns) {
1095 1096
        # Consider NULL db entries to be equivalent to the empty string
        $oldvalues[$i] ||= '';
1097
        $oldhash{$col} = $oldvalues[$i];
1098
        if (exists $::FORM{$col}) {
1099
            if (!CheckCanChangeField($col, $id, $oldvalues[$i], $::FORM{$col})) {
1100 1101
                # More fun hacking... don't display component_id
                if ($col eq 'component_id') {
1102
                    $vars->{'oldvalue'} = get_component_name($oldhash{'component_id'});
1103 1104 1105 1106 1107 1108 1109 1110
                    $vars->{'newvalue'} = $::FORM{'component'};
                    $vars->{'field'} = 'component';
                }
                else {
                    $vars->{'oldvalue'} = $oldvalues[$i];
                    $vars->{'newvalue'} = $::FORM{$col};
                    $vars->{'field'} = $col;
                }
1111
                ThrowUserError("illegal_change", undef, "abort");            
1112
            }
1113 1114 1115
        }
        $i++;
    }
1116
    $oldhash{'product'} = get_product_name($oldhash{'product_id'});
1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128
    if (!CanEditProductId($oldhash{'product_id'})) {
        $vars->{'product'} = $oldhash{'product'};
        ThrowUserError("product_edit_denied");
    }

    if (defined $::FORM{'product'} 
        && $::FORM{'product'} ne $::FORM{'dontchange'} 
        && $::FORM{'product'} ne $oldhash{'product'}
        && !CanEnterProduct($::FORM{'product'})) {
        $vars->{'product'} = $::FORM{'product'};
        ThrowUserError("entry_access_denied");
    }
1129 1130
    if ($requiremilestone) {
        my $value = $::FORM{'target_milestone'};
1131
        if (!defined $value || $value eq $::FORM{'dontchange'}) {
1132 1133
            $value = $oldhash{'target_milestone'};
        }
1134
        SendSQL("SELECT defaultmilestone FROM products WHERE name = " .
1135 1136 1137
                SqlQuote($oldhash{'product'}));
        if ($value eq FetchOneColumn()) {
            SendSQL("UNLOCK TABLES");
1138
            $vars->{'bug_id'} = $id;
1139
            ThrowUserError("milestone_required", undef, "abort");
1140 1141
        }
    }   
1142
    if (defined $::FORM{'delta_ts'} && $::FORM{'delta_ts'} ne $delta_ts) {
1143 1144 1145 1146
        ($vars->{'operations'}) = GetBugActivity($::FORM{'id'}, $::FORM{'delta_ts'});

        $vars->{'start_at'} = $::FORM{'longdesclength'};
        $vars->{'comments'} = GetComments($id);
1147

1148
        $::FORM{'delta_ts'} = $delta_ts;
1149
        $vars->{'form'} = \%::FORM;
1150
        $vars->{'mform'} = \%::MFORM;
1151 1152 1153 1154 1155 1156
        
        $vars->{'bug_id'} = $id;
        
        SendSQL("UNLOCK TABLES");
        
        # Warn the user about the mid-air collision and ask them what to do.
1157
        $template->process("bug/process/midair.html.tmpl", $vars)
1158
          || ThrowTemplateError($template->error());
1159 1160 1161
        exit;
    }
        
1162 1163 1164 1165
    my %deps;
    if (defined $::FORM{'dependson'}) {
        my $me = "blocked";
        my $target = "dependson";
1166
        my %deptree;
1167
        for (1..2) {
1168
            $deptree{$target} = [];
1169 1170
            my %seen;
            foreach my $i (split('[\s,]+', $::FORM{$target})) {
1171 1172
                next if $i eq "";
                
1173
                if ($id eq $i) {
1174
                    ThrowUserError("dependency_loop_single", undef, "abort");
1175
                }
1176
                if (!exists $seen{$i}) {
1177
                    push(@{$deptree{$target}}, $i);
1178 1179 1180
                    $seen{$i} = 1;
                }
            }
1181 1182 1183
            # populate $deps{$target} as first-level deps only.
            # and find remainder of dependency tree in $deptree{$target}
            @{$deps{$target}} = @{$deptree{$target}};
1184 1185 1186
            my @stack = @{$deps{$target}};
            while (@stack) {
                my $i = shift @stack;
1187 1188
                SendSQL("select $target from dependencies where $me = " .
                        SqlQuote($i));
1189 1190
                while (MoreSQLData()) {
                    my $t = FetchOneColumn();
1191 1192 1193 1194
                    # ignore any _current_ dependencies involving this bug,
                    # as they will be overwritten with data from the form.
                    if ($t != $id && !exists $seen{$t}) {
                        push(@{$deptree{$target}}, $t);
1195 1196 1197 1198 1199
                        push @stack, $t;
                        $seen{$t} = 1;
                    }
                }
            }
1200

1201
            if ($me eq 'dependson') {
1202 1203
                my @deps   =  @{$deptree{'dependson'}};
                my @blocks =  @{$deptree{'blocked'}};
1204 1205 1206 1207 1208 1209 1210
                my @union = ();
                my @isect = ();
                my %union = ();
                my %isect = ();
                foreach my $b (@deps, @blocks) { $union{$b}++ && $isect{$b}++ }
                @union = keys %union;
                @isect = keys %isect;
1211
                if (@isect > 0) {
1212 1213
                    my $both;
                    foreach my $i (@isect) {
1214
                       $both = $both . GetBugLink($i, "#" . $i) . " ";
1215
                    }
1216 1217
                    
                    $vars->{'both'} = $both;
1218
                    ThrowUserError("dependency_loop_multi", undef, "abort");
1219 1220
                }
            }
1221 1222 1223 1224 1225
            my $tmp = $me;
            $me = $target;
            $target = $tmp;
        }
    }
1226

1227 1228 1229
    SendSQL("select now()");
    $timestamp = FetchOneColumn();

1230 1231 1232
    delete $::FORM{'work_time'} unless UserInGroup(Param('timetrackinggroup'));

    if ($::FORM{'work_time'} && $::FORM{'work_time'} > 99999.99) {
1233 1234
        ThrowUserError("value_out_of_range", {field => 'work_time'});
    }
1235 1236
    if ($::FORM{'comment'} || $::FORM{'work_time'}) {
        if ($::FORM{'work_time'} && 
1237 1238 1239 1240
            (!defined $::FORM{'comment'} || $::FORM{'comment'} =~ /^\s*$/)) {
            ThrowUserError('comment_required');
        } else {
            AppendComment($id, $::COOKIE{'Bugzilla_login'}, $::FORM{'comment'},
1241 1242
                          $::FORM{'commentprivacy'}, $timestamp, $::FORM{'work_time'});
            if ($::FORM{'work_time'}) {
1243 1244 1245
                LogActivityEntry($id, "work_time", "", $::FORM{'work_time'},
                                 $whoid, $timestamp);
                $bug_changed = 1;
1246 1247 1248 1249
            }
        }
    }

1250 1251 1252 1253 1254 1255
    if (@::legal_keywords) {
        # There are three kinds of "keywordsaction": makeexact, add, delete.
        # For makeexact, we delete everything, and then add our things.
        # For add, we delete things we're adding (to make sure we don't
        # end up having them twice), and then we add them.
        # For delete, we just delete things on the list.
1256
        my $changed = 0;
1257 1258
        if ($keywordaction eq "makeexact") {
            SendSQL("DELETE FROM keywords WHERE bug_id = $id");
1259
            $changed = 1;
1260 1261 1262 1263 1264
        }
        foreach my $keyword (@keywordlist) {
            if ($keywordaction ne "makeexact") {
                SendSQL("DELETE FROM keywords
                         WHERE bug_id = $id AND keywordid = $keyword");
1265
                $changed = 1;
1266 1267 1268 1269
            }
            if ($keywordaction ne "delete") {
                SendSQL("INSERT INTO keywords 
                         (bug_id, keywordid) VALUES ($id, $keyword)");
1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281
                $changed = 1;
            }
        }
        if ($changed) {
            SendSQL("SELECT keyworddefs.name 
                     FROM keyworddefs, keywords
                     WHERE keywords.bug_id = $id
                         AND keyworddefs.id = keywords.keywordid
                     ORDER BY keyworddefs.name");
            my @list;
            while (MoreSQLData()) {
                push(@list, FetchOneColumn());
1282
            }
1283 1284 1285
            SendSQL("UPDATE bugs SET keywords = " .
                    SqlQuote(join(', ', @list)) .
                    " WHERE bug_id = $id");
1286 1287
        }
    }
1288
    my $query = "$basequery\nwhere bug_id = $id";
terry%netscape.com's avatar
terry%netscape.com committed
1289
    
1290 1291
    if ($::comma ne "") {
        SendSQL($query);
terry%netscape.com's avatar
terry%netscape.com committed
1292
    }
1293

1294 1295 1296 1297 1298 1299 1300
    # Check for duplicates if the bug is [re]open
    SendSQL("SELECT resolution FROM bugs WHERE bug_id = $id");
    my $resolution = FetchOneColumn();
    if ($resolution eq '') {
        SendSQL("DELETE FROM duplicates WHERE dupe = $id");
    }
    
1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323
    my $newproduct_id = $oldhash{'product_id'};
    if ((defined $::FORM{'product'})
        && ($::FORM{'product'} ne $::FORM{'dontchange'})) {
        my $newproduct_id = get_product_id($::FORM{'product'});
    }

    my %groupsrequired = ();
    my %groupsforbidden = ();
    SendSQL("SELECT id, membercontrol 
             FROM groups LEFT JOIN group_control_map
             ON id = group_id
             AND product_id = $newproduct_id WHERE isactive != 0");
    while (MoreSQLData()) {
        my ($group, $control) = FetchSQLData();
        $control ||= 0;
        unless ($control > &::CONTROLMAPNA)  {
            $groupsforbidden{$group} = 1;
        }
        if ($control == &::CONTROLMAPMANDATORY) {
            $groupsrequired{$group} = 1;
        }
    }

1324
    my @groupAddNames = ();
1325 1326 1327 1328
    my @groupAddNamesAll = ();
    foreach my $grouptoadd (@groupAdd, keys %groupsrequired) {
        next if $groupsforbidden{$grouptoadd};
        push(@groupAddNamesAll, GroupIdToName($grouptoadd));
1329 1330 1331 1332 1333 1334 1335
        if (!BugInGroupId($id, $grouptoadd)) {
            push(@groupAddNames, GroupIdToName($grouptoadd));
            SendSQL("INSERT INTO bug_group_map (bug_id, group_id) 
                     VALUES ($id, $grouptoadd)");
        }
    }
    my @groupDelNames = ();
1336 1337 1338 1339
    my @groupDelNamesAll = ();
    foreach my $grouptodel (@groupDel, keys %groupsforbidden) {
        push(@groupDelNamesAll, GroupIdToName($grouptodel));
        next if $groupsrequired{$grouptodel};
1340 1341 1342 1343 1344 1345 1346 1347 1348 1349
        if (BugInGroupId($id, $grouptodel)) {
            push(@groupDelNames, GroupIdToName($grouptodel));
        }
        SendSQL("DELETE FROM bug_group_map 
                 WHERE bug_id = $id AND group_id = $grouptodel");
    }

    my $groupDelNames = join(',', @groupDelNames);
    my $groupAddNames = join(',', @groupAddNames);

1350 1351 1352
    LogActivityEntry($id, "bug_group", $groupDelNames, $groupAddNames,
                     $whoid, $timestamp); 
    $bug_changed = 1;
1353 1354

    my @ccRemoved = (); 
1355 1356 1357 1358 1359 1360 1361 1362 1363
    if (defined $::FORM{newcc} || defined $::FORM{removecc} || defined $::FORM{masscc}) {
        # Get the current CC list for this bug
        my %oncc;
        SendSQL("SELECT who FROM cc WHERE bug_id = $id");
        while (MoreSQLData()) {
            $oncc{FetchOneColumn()} = 1;
        }

        my (@added, @removed) = ();
1364 1365 1366 1367 1368 1369
        foreach my $pid (keys %cc_add) {
            # If this person isn't already on the cc list, add them
            if (! $oncc{$pid}) {
                SendSQL("INSERT INTO cc (bug_id, who) VALUES ($id, $pid)");
                push (@added, $cc_add{$pid});
                $oncc{$pid} = 1;
1370 1371
            }
        }
1372 1373 1374 1375 1376 1377
        foreach my $pid (keys %cc_remove) {
            # If the person is on the cc list, remove them
            if ($oncc{$pid}) {
                SendSQL("DELETE FROM cc WHERE bug_id = $id AND who = $pid");
                push (@removed, $cc_remove{$pid});
                $oncc{$pid} = 0;
1378 1379
            }
        }
1380

1381 1382
        # If any changes were found, record it in the activity log
        if (scalar(@removed) || scalar(@added)) {
1383 1384
            my $removed = join(", ", @removed);
            my $added = join(", ", @added);
1385 1386
            LogActivityEntry($id,"cc",$removed,$added,$whoid,$timestamp);
            $bug_changed = 1;
1387
        }
1388
        @ccRemoved = @removed;
1389
    }
1390

1391
    # We need to send mail for dependson/blocked bugs if the dependencies
1392 1393 1394
    # change or the status or resolution change. This var keeps track of that.
    my $check_dep_bugs = 0;

1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405
    if (defined $::FORM{'dependson'}) {
        my $me = "blocked";
        my $target = "dependson";
        for (1..2) {
            SendSQL("select $target from dependencies where $me = $id order by $target");
            my %snapshot;
            my @oldlist;
            while (MoreSQLData()) {
                push(@oldlist, FetchOneColumn());
            }
            my @newlist = sort {$a <=> $b} @{$deps{$target}};
1406 1407
            @dependencychanged{@oldlist} = 1;
            @dependencychanged{@newlist} = 1;
1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435

            while (0 < @oldlist || 0 < @newlist) {
                if (@oldlist == 0 || (@newlist > 0 &&
                                      $oldlist[0] > $newlist[0])) {
                    $snapshot{$newlist[0]} = SnapShotDeps($newlist[0], $me,
                                                          $target);
                    shift @newlist;
                } elsif (@newlist == 0 || (@oldlist > 0 &&
                                           $newlist[0] > $oldlist[0])) {
                    $snapshot{$oldlist[0]} = SnapShotDeps($oldlist[0], $me,
                                                          $target);
                    shift @oldlist;
                } else {
                    if ($oldlist[0] != $newlist[0]) {
                        die "Error in list comparing code";
                    }
                    shift @oldlist;
                    shift @newlist;
                }
            }
            my @keys = keys(%snapshot);
            if (@keys) {
                my $oldsnap = SnapShotDeps($id, $target, $me);
                SendSQL("delete from dependencies where $me = $id");
                foreach my $i (@{$deps{$target}}) {
                    SendSQL("insert into dependencies ($me, $target) values ($id, $i)");
                }
                foreach my $k (@keys) {
1436
                    LogDependencyActivity($k, $snapshot{$k}, $me, $target);
1437 1438
                }
                LogDependencyActivity($id, $oldsnap, $target, $me);
1439
                $check_dep_bugs = 1;
1440 1441 1442 1443 1444 1445 1446 1447
            }

            my $tmp = $me;
            $me = $target;
            $target = $tmp;
        }
    }

1448 1449 1450 1451 1452
    # When a bug changes products and the old or new product is associated
    # with a bug group, it may be necessary to remove the bug from the old
    # group or add it to the new one.  There are a very specific series of
    # conditions under which these activities take place, more information
    # about which can be found in comments within the conditionals below.
1453
    # Check if the user has changed the product to which the bug belongs;
1454
    if ( 
1455
      defined $::FORM{'product'} 
1456
        && $::FORM{'product'} ne $::FORM{'dontchange'} 
1457 1458
          && $::FORM{'product'} ne $oldhash{'product'} 
    ) {
1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524
        my $newproduct_id = get_product_id($::FORM{'product'});
        # Depending on the "addtonewgroup" variable, groups with
        # defaults will change.
        #
        # For each group, determine
        # - The group id and if it is active
        # - The control map value for the old product and this group
        # - The control map value for the new product and this group
        # - Is the user in this group?
        # - Is the bug in this group?
        SendSQL("SELECT DISTINCT groups.id, isactive, " .
                "oldcontrolmap.membercontrol, newcontrolmap.membercontrol, " .
                "user_group_map.user_id IS NOT NULL, " .
                "bug_group_map.group_id IS NOT NULL " .
                "FROM groups " .
                "LEFT JOIN group_control_map AS oldcontrolmap " .
                "ON oldcontrolmap.group_id = groups.id " .
                "AND oldcontrolmap.product_id = " . $oldhash{'product_id'} .
                " LEFT JOIN group_control_map AS newcontrolmap " .
                "ON newcontrolmap.group_id = groups.id " .
                "AND newcontrolmap.product_id = $newproduct_id " .
                "LEFT JOIN user_group_map " .
                "ON user_group_map.group_id = groups.id " .
                "AND user_group_map.user_id = $::userid " .
                "AND user_group_map.isbless = 0 " .
                "LEFT JOIN bug_group_map " .
                "ON bug_group_map.group_id = groups.id " .
                "AND bug_group_map.bug_id = $id "
            );
        my @groupstoremove = ();
        my @groupstoadd = ();
        my @defaultstoremove = ();
        my @defaultstoadd = ();
        my @allgroups = ();
        my $buginanydefault = 0;
        my $buginanychangingdefault = 0;
        while (MoreSQLData()) {
            my ($groupid, $isactive, $oldcontrol, $newcontrol, 
            $useringroup, $bugingroup) = FetchSQLData();
            # An undefined newcontrol is none.
            $newcontrol = CONTROLMAPNA unless $newcontrol;
            $oldcontrol = CONTROLMAPNA unless $oldcontrol;
            push(@allgroups, $groupid);
            if (($bugingroup) && ($isactive)
                && ($oldcontrol == CONTROLMAPDEFAULT)) {
                # Bug was in a default group.
                $buginanydefault = 1;
                if ($newcontrol != CONTROLMAPDEFAULT) {
                    # Bug was in a default group that no longer is.
                    $buginanychangingdefault = 1;
                    push (@defaultstoremove, $groupid);
                }
            }
            if (($isactive) && (!$bugingroup)
                && ($newcontrol == CONTROLMAPDEFAULT)
                && ($useringroup)) {
                push (@defaultstoadd, $groupid);
            }
            if (($bugingroup) && ($isactive) && ($newcontrol == CONTROLMAPNA)) {
                # Group is no longer permitted.
                push(@groupstoremove, $groupid);
            }
            if ((!$bugingroup) && ($isactive) 
                && ($newcontrol == CONTROLMAPMANDATORY)) {
                # Group is now required.
                push(@groupstoadd, $groupid);
1525
            }
1526
        }
1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539
        # If addtonewgroups = "yes", old default groups will be removed
        # and new default groups will be added.
        # If addtonewgroups = "yesifinold", old default groups will be removed
        # and new default groups will be added only if the bug was in ANY
        # of the old default groups.
        # If addtonewgroups = "no", old default groups will be removed and not
        # replaced.
        push(@groupstoremove, @defaultstoremove);
        if (AnyDefaultGroups()
            && (($::FORM{'addtonewgroup'} eq 'yes')
            || (($::FORM{'addtonewgroup'} eq 'yesifinold') 
            && ($buginanydefault)))) {
            push(@groupstoadd, @defaultstoadd);
1540 1541
        }

1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563
        # Now actually update the bug_group_map.
        my @DefGroupsAdded = ();
        my @DefGroupsRemoved = ();
        foreach my $groupid (@allgroups) {
            my $thisadd = grep( ($_ == $groupid), @groupstoadd);
            my $thisdel = grep( ($_ == $groupid), @groupstoremove);
            if ($thisadd) {
                push(@DefGroupsAdded, GroupIdToName($groupid));
                SendSQL("INSERT INTO bug_group_map (bug_id, group_id) VALUES " .
                        "($id, $groupid)");
            } elsif ($thisdel) {
                push(@DefGroupsRemoved, GroupIdToName($groupid));
                SendSQL("DELETE FROM bug_group_map WHERE bug_id = $id " .
                        "AND group_id = $groupid");
            }
        }
        if ((@DefGroupsAdded) || (@DefGroupsRemoved)) {
            LogActivityEntry($id, "bug_group",
                join(', ', @DefGroupsRemoved),
                join(', ', @DefGroupsAdded),
                     $whoid, $timestamp); 
        }
1564 1565
    }
  
1566 1567 1568 1569
    # get a snapshot of the newly set values out of the database, 
    # and then generate any necessary bug activity entries by seeing 
    # what has changed since before we wrote out the new values.
    #
1570
    my @newvalues = SnapShotBug($id);
1571 1572 1573 1574 1575 1576 1577 1578
    my %newhash;
    $i = 0;
    foreach my $col (@::log_columns) {
        # Consider NULL db entries to be equivalent to the empty string
        $newvalues[$i] ||= '';
        $newhash{$col} = $newvalues[$i];
        $i++;
    }
1579
    # for passing to Bugzilla::BugMail to ensure that when someone is removed
1580 1581 1582 1583
    # from one of these fields, they get notified of that fact (if desired)
    #
    my $origOwner = "";
    my $origQaContact = "";
1584
    
1585
    foreach my $c (@::log_columns) {
1586 1587
        my $col = $c;           # We modify it, don't want to modify array
                                # values in place.
1588 1589 1590
        my $old = shift @oldvalues;
        my $new = shift @newvalues;
        if ($old ne $new) {
1591

1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604
            # Products and components are now stored in the DB using ID's
            # We need to translate this to English before logging it
            if ($col eq 'product_id') {
                $old = get_product_name($old);
                $new = get_product_name($new);
                $col = 'product';
            }
            if ($col eq 'component_id') {
                $old = get_component_name($old);
                $new = get_component_name($new);
                $col = 'component';
            }

1605 1606
            # save off the old value for passing to Bugzilla::BugMail so
            # the old owner can be notified
1607 1608 1609 1610 1611 1612 1613 1614 1615 1616
            #
            if ($col eq 'assigned_to') {
                $old = ($old) ? DBID_to_name($old) : "";
                $new = ($new) ? DBID_to_name($new) : "";
                $origOwner = $old;
            }

            # ditto for the old qa contact
            #
            if ($col eq 'qa_contact') {
1617 1618
                $old = ($old) ? DBID_to_name($old) : "";
                $new = ($new) ? DBID_to_name($new) : "";
1619
                $origQaContact = $old;
terry%netscape.com's avatar
terry%netscape.com committed
1620
            }
1621

1622 1623 1624 1625 1626
            # If this is the keyword field, only record the changes, not everything.
            if ($col eq 'keywords') {
                ($old, $new) = DiffStrings($old, $new);
            }

1627
            if ($col eq 'product') {
1628
                RemoveVotes($id, 0,
1629 1630
                            "This bug has been moved to a different product");
            }
1631 1632 1633 1634 1635 1636 1637
            
            if ($col eq 'bug_status' 
                && IsOpenedState($old) ne IsOpenedState($new))
            {
                $check_dep_bugs = 1;
            }
            
1638 1639
            LogActivityEntry($id,$col,$old,$new,$whoid,$timestamp);
            $bug_changed = 1;
terry%netscape.com's avatar
terry%netscape.com committed
1640 1641
        }
    }
1642 1643 1644 1645 1646
    # Set and update flags.
    if ($UserInEditGroupSet) {
        my $target = Bugzilla::Flag::GetTarget($id);
        Bugzilla::Flag::process($target, $timestamp, \%::FORM);
    }
1647 1648 1649
    if ($bug_changed) {
        SendSQL("UPDATE bugs SET delta_ts = " . SqlQuote($timestamp) . " WHERE bug_id = $id");
    }
1650
    SendSQL("UNLOCK TABLES");
1651

1652 1653 1654 1655
    $vars->{'mailrecipients'} = { 'cc' => \@ccRemoved,
                                  'owner' => $origOwner,
                                  'qa' => $origQaContact,
                                  'changer' => $::COOKIE{'Bugzilla_login'} };
1656 1657 1658 1659 1660

    $vars->{'id'} = $id;
    
    # Let the user know the bug was changed and who did and didn't
    # receive email about the change.
1661
    $template->process("bug/process/results.html.tmpl", $vars)
1662
      || ThrowTemplateError($template->error());
1663
    $vars->{'header_done'} = 1;
1664
    
1665 1666 1667 1668 1669 1670 1671 1672
    if ($duplicate) {
        # Check to see if Reporter of this bug is reporter of Dupe 
        SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($::FORM{'id'}));
        my $reporter = FetchOneColumn();
        SendSQL("SELECT reporter FROM bugs WHERE bug_id = " . SqlQuote($duplicate) . " and reporter = $reporter");
        my $isreporter = FetchOneColumn();
        SendSQL("SELECT who FROM cc WHERE bug_id = " . SqlQuote($duplicate) . " and who = $reporter");
        my $isoncc = FetchOneColumn();
1673
        unless ($isreporter || $isoncc || ! $::FORM{'confirm_add_duplicate'}) {
matty%chariot.net.au's avatar
matty%chariot.net.au committed
1674
            # The reporter is oblivious to the existence of the new bug and is permitted access
1675
            # ... add 'em to the cc (and record activity)
1676 1677
            LogActivityEntry($duplicate,"cc","",DBID_to_name($reporter),
                             $whoid,$timestamp);
1678 1679
            SendSQL("INSERT INTO cc (who, bug_id) VALUES ($reporter, " . SqlQuote($duplicate) . ")");
        }
1680 1681
        # Bug 171639 - Duplicate notifications do not need to be private. 
        AppendComment($duplicate, $::COOKIE{'Bugzilla_login'}, "*** Bug $::FORM{'id'} has been marked as a duplicate of this bug. ***", 0);
1682
        CheckFormFieldDefined(\%::FORM,'comment');
1683
        SendSQL("INSERT INTO duplicates VALUES ($duplicate, $::FORM{'id'})");
1684
        
1685 1686 1687
        $vars->{'mailrecipients'} = { 'changer' => $::COOKIE{'Bugzilla_login'} 
                                    }; 

1688 1689 1690 1691
        $vars->{'id'} = $duplicate;
        $vars->{'type'} = "dupe";
        
        # Let the user know a duplication notation was added to the original bug.
1692
        $template->process("bug/process/results.html.tmpl", $vars)
1693
          || ThrowTemplateError($template->error());
1694
        $vars->{'header_done'} = 1;
1695 1696
    }

1697 1698
    if ($check_dep_bugs) {
        foreach my $k (keys(%dependencychanged)) {
1699
            $vars->{'mailrecipients'} = { 'changer' => $::COOKIE{'Bugzilla_login'} };
1700 1701 1702 1703 1704 1705 1706 1707
            $vars->{'id'} = $k;
            $vars->{'type'} = "dep";

            # Let the user know we checked to see if we should email notice
            # of this change to users with a relationship to the dependent
            # bug and who did and didn't receive email about it.
            $template->process("bug/process/results.html.tmpl", $vars)
              || ThrowTemplateError($template->error());
1708
            $vars->{'header_done'} = 1;
1709
        }
1710
    }
terry%netscape.com's avatar
terry%netscape.com committed
1711 1712
}

1713 1714 1715 1716 1717 1718
# now show the next bug
if ($next_bug) {
    if (detaint_natural($next_bug) && CanSeeBug($next_bug, $::userid)) {
        my $bug = new Bug($next_bug, $::userid);
        $vars->{'bug'} = $bug;
        ThrowCodeError("bug_error") if $bug->error;
1719

1720 1721
        $template->process("bug/process/next.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
1722

1723
        exit;
1724
    }
terry%netscape.com's avatar
terry%netscape.com committed
1725
}
1726

1727
# End the response page.
1728
$template->process("bug/navigate.html.tmpl", $vars)
1729
  || ThrowTemplateError($template->error());
1730
$template->process("global/footer.html.tmpl", $vars)
1731
  || ThrowTemplateError($template->error());