Commit 9dd61f71 authored by terry%mozilla.org's avatar terry%mozilla.org

Use new "keywords" cache to display keywords in bug lists. Not only

is this much faster, but it also lets you sort by that column, and requires less special-case code.
parent 9178b8f1
...@@ -182,6 +182,7 @@ DefCol("os", "substring(bugs.op_sys, 1, 4)", "OS", "bugs.op_sys"); ...@@ -182,6 +182,7 @@ DefCol("os", "substring(bugs.op_sys, 1, 4)", "OS", "bugs.op_sys");
DefCol("target_milestone", "bugs.target_milestone", "TargetM", DefCol("target_milestone", "bugs.target_milestone", "TargetM",
"bugs.target_milestone"); "bugs.target_milestone");
DefCol("votes", "bugs.votes", "Votes", "bugs.votes desc"); DefCol("votes", "bugs.votes", "Votes", "bugs.votes desc");
DefCol("keywords", "bugs.keywords", "Keywords", "bugs.keywords");
my @collist; my @collist;
if (defined $::COOKIE{'COLUMNLIST'}) { if (defined $::COOKIE{'COLUMNLIST'}) {
...@@ -570,8 +571,6 @@ foreach my $c (@collist) { ...@@ -570,8 +571,6 @@ foreach my $c (@collist) {
} else { } else {
$tablestart .= $::title{$c}; $tablestart .= $::title{$c};
} }
} elsif ($c eq "keywords") {
$tablestart .= "<TH valign=left>Keywords</TH>";
} }
} }
...@@ -657,19 +656,6 @@ while (@row = FetchSQLData()) { ...@@ -657,19 +656,6 @@ while (@row = FetchSQLData()) {
$value = "<nobr>$value</nobr>"; $value = "<nobr>$value</nobr>";
} }
pnl "<td class=$c>$value"; pnl "<td class=$c>$value";
} elsif ($c eq "keywords") {
my $query =
$::db->query("SELECT keyworddefs.name
FROM keyworddefs, keywords
WHERE keywords.bug_id = $bug_id
AND keyworddefs.id = keywords.keywordid
ORDER BY keyworddefs.name");
my @list;
my @row;
while (@row= $query->fetchrow()) {
push(@list, $row[0]);
}
pnl("<td>" . join(", ", @list) . "</td>");
} }
} }
if ($dotweak) { if ($dotweak) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment