a=LpSolit

r/a=mkanat

(Bug.add_attachment)
r=timello, a=mkanat

Bug 490930: Always store attachments locally if they are over X size (and below some threshold!), don't ever display "Big File" checkbox
r=mkanat a=LpSolit

allows specifying that certain fields have validator defaults even if they
also have a database default or are in another table.
r=LpSolit, a=LpSolit

[r=LpSolit a=LpSolit]

are required for create(). It now assumes that any column that is NOT NULL
and has not DEFAULT in the database is required. We also shift the burden
of throwing errors about empty values to the validators. This fixes the bug
that Bugzilla::Bug->create() wasn't populating default values for fields
if they weren't specified in the create() parameters.
r=timello, a=mkanat

a=LpSolit

Patch by Max Kanat-Alexander <mkanat@bugzilla.org> (module owner) a=mkanat

Bug 140999: Users without edit permissions for an attachment should still be able to make comments - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> a=LpSolit

Bug 480986: The BMP -> PNG conversion tool for new attachments should be an extension - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r/a=mkanat

Bug 509027: Add a hook in Bugzilla::Attachment::_check_data() - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r/a=mkanat

Bug 415541: Implement $bug->set_flags() and $attachment->set_flags() - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> a=LpSolit

Bug 454251: Implement Bugzilla::Attachment->create() and $attachment->update() - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> a=LpSolit (module owner)

Bug 399074: Remove the 'maxpatchsize' parameter - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r/a=mkanat

Fix bustage due to bug 453743: I have to exclude flags related to private attachments you cannot see

Bug 388251: Implement 'new Bugzilla::Attachment' - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> a=LpSolit

Bug 453743: Decrease the number of calls to the DB about flags when viewing a bug - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r/a=mkanat

Bug 415155: Remove $cgi from the list of arguments when calling Bugzilla::Flag subroutines - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> a=LpSolit

Bug 413772: Eliminate sqlify_criteria() in Bugzilla::Flag and replace match() there with Bugzilla::Object::match() - Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r/a=LpSolit

Bug 413222: Implement $attachment->remove_from_db - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> a=LpSolit

Patch By Xiaoou Wu <xiaoou.wu@oracle.com> r=mkanat, a=mkanat

Patch By Xiaoou Wu <xiaoou.wu@oracle.com> r=mkanat, a=mkanat

Bug 99215: Attachments have no midair collision protection - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r=mkanat r=justdave a=justdave

Midair with product change while adding an attachment silently clears flags - Patch by Tiago R. Mello <timello@gmail.com> r/a=LpSolit

Bug 392175: Move isViewable out of attachment.cgi + some other minor cleanup - Patch by FrÃdÃric Buclin <LpSolit@gmail.com>

patch by jhulten@tragicallyleet.com r=timeless
I've updated it to trunk r=lpsolit a=lpsolit

r=lpsolit a=lpsolit

Bug 376497: validateID() should return an attachment object - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> a=LpSolit

Bug 364177: On attachment and bug creation, if *one* requestee cannot see the bug, *all* requests are cancelled - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r/a=mkanat

Bug 367077: Big attachments which should be stored locally are not - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r=wurblzap a=LpSolit

Bug 365739: An error is thrown when attaching a too big file on bug creation - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r/a=justdave

Bug 356395: On bug creation, an error is thrown when the requestee of a private attachment is not in the insidergroup, or when the requestee is not in the grant group (for attachment flags) - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r/a=myk

Bug 189627: Implement per-product privileges - Patch by FrÃdÃric Buclin <LpSolit@gmail.com> r=mkanat a=myk

Bug 346086: [SECURITY] attachment.cgi lets you view descriptions of private attachments even when you are not in the insidergroup - Patch by Frédéric Buclin <LpSolit@gmail.com> r=myk a=justdave

Bug 343809: Merge FlagType::validate() with Flag::validate() - Patch by Frédéric Buclin <LpSolit@gmail.com> a=myk

Bug 174039: Set flags on bug entry - Patch by Frédéric Buclin <LpSolit@gmail.com> r=wurblzap r=myk a=myk

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave