input/CdioParanoia: fix crash if no drive was found

cdio_get_devices_with_cap() can return nullptr if no drive was found, or it can instead return an empty list. The latter caused MPD to crash.

input/CdioParanoia: fix crash if no drive was found
8eb31648 · Max Kellermann · 915c5442 · 8eb31648 · 8eb31648
Commit 8eb31648 authored Jul 08, 2022 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

NEWS NEWS +2 -0

CdioParanoiaInputPlugin.cxx src/input/plugins/CdioParanoiaInputPlugin.cxx +3 -0

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.23.8 (not yet released)
 * storage
  - curl: fix crash if web server does not understand WebDAV
+* input
+  - cdio_paranoia: fix crash if no drive was found
 * output
  - pipewire: fix crash with PipeWire 0.3.53
 * mixer

--- a/src/input/plugins/CdioParanoiaInputPlugin.cxx
+++ b/src/input/plugins/CdioParanoiaInputPlugin.cxx
@@ -176,6 +176,9 @@ cdio_detect_device()

 	AtScopeExit(devices) { cdio_free_device_list(devices); };

+	if (devices[0] == nullptr)
+		return nullptr;
+
 	return AllocatedPath::FromFS(devices[0]);
 }