Skip to content

M
mpd
Commit b0703b92 authored by Max Kellermann's avatar Max Kellermann
Browse files
Options

util/FormatString: pass the allocated buffer to AllocatedString::Donate()

.. and not the stack buffer. This made the AllocatedString destructor crash. Closes #52
parent dd9fd3d8
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 1 deletion
NEWS
View file @ b0703b92
...@@ -3,6 +3,7 @@ ver 0.20.10 (not yet released) ...@@ -3,6 +3,7 @@ ver 0.20.10 (not yet released)
- ffmpeg: support MusicBrainz ID3v2 tags - ffmpeg: support MusicBrainz ID3v2 tags
* tags * tags
- aiff: fix FORM chunk size endianess (is big-endian) - aiff: fix FORM chunk size endianess (is big-endian)
* fix crash on Windows
ver 0.20.9 (2017/06/04) ver 0.20.9 (2017/06/04)
* decoder * decoder
......
src/util/FormatString.cxx
View file @ b0703b92
...@@ -57,7 +57,7 @@ FormatStringV(const char *fmt, va_list args) ...@@ -57,7 +57,7 @@ FormatStringV(const char *fmt, va_list args)
const size_t length = strlen(buffer); const size_t length = strlen(buffer);
char *p = new char[length + 1]; char *p = new char[length + 1];
memcpy(p, buffer, length + 1); memcpy(p, buffer, length + 1);
return AllocatedString<>::Donate(buffer); return AllocatedString<>::Donate(p);
#endif #endif
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment