util/FormatString: pass the allocated buffer to AllocatedString::Donate()

.. and not the stack buffer. This made the AllocatedString destructor crash. Closes #52

util/FormatString: pass the allocated buffer to AllocatedString::Donate()
b0703b92 · Max Kellermann · dd9fd3d8 · b0703b92 · b0703b92
Commit b0703b92 authored Aug 03, 2017 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

NEWS NEWS +1 -0

FormatString.cxx src/util/FormatString.cxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,7 @@ ver 0.20.10 (not yet released)
  - ffmpeg: support MusicBrainz ID3v2 tags
 * tags
  - aiff: fix FORM chunk size endianess (is big-endian)
+* fix crash on Windows

 ver 0.20.9 (2017/06/04)
 * decoder

--- a/src/util/FormatString.cxx
+++ b/src/util/FormatString.cxx
@@ -57,7 +57,7 @@ FormatStringV(const char *fmt, va_list args)
 	const size_t length = strlen(buffer);
 	char *p = new char[length + 1];
 	memcpy(p, buffer, length + 1);
-	return AllocatedString<>::Donate(buffer);
+	return AllocatedString<>::Donate(p);
 #endif
 }