- 08 Jul, 2022 7 commits
-
-
Max Kellermann authored
This disables a long delay for playing songs from the cdio_paranoia input plugin if ReplayGain is enabled.
-
Max Kellermann authored
The Read() method is not required to fill the whole buffer. By returning as soon as at least one byte was read, we allow faster cancellation.
-
Max Kellermann authored
cdio_get_devices_with_cap() can return nullptr if no drive was found, or it can instead return an empty list. The latter caused MPD to crash.
-
Max Kellermann authored
If the PipeWire output has not yet been enabled and no thread_loop has been created yet, a nullptr dereference in SetVolume() was possible because nullptr was passed to pw_thread_loop_lock().
-
Max Kellermann authored
If a mixer is "global", it is available even if the output isn't open. However, since the check was changed from IsEnabled() to IsReallyEnabled(), enabled outputs have not yet been used have not been "really" enabled yet, preventing using the mixer. Fixes a regression by commit 35dbc1a9 (part of https://github.com/MusicPlayerDaemon/MPD/pull/1480). Closes https://github.com/MusicPlayerDaemon/MPD/issues/1563
-
Max Kellermann authored
This reveals more about the nature of an error instead of just returning "problems setting volume".
-
Max Kellermann authored
libfmt version 9 broke the API by removing fmt::make_args_checked(). Fixes https://bugs.debian.org/1014543
-
- 04 Jul, 2022 1 commit
-
-
Max Kellermann authored
Since PipeWire 0.3.53, control names can apparently be nulled, leading to crashes in applications assertion that the string cannot be nullptr. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1558
-
- 01 Jul, 2022 1 commit
-
-
Max Kellermann authored
This fixes a std::terminate() crash in the CURL storage plugin when PropfindOperation::OnHeaders() throws an exception after receiving a non-207 status. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1559
-
- 09 May, 2022 2 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
- 26 Apr, 2022 4 commits
-
-
Rosen Penev authored
libupnp 1.14 removes the non 2 function. Fixes compilation there. Signed-off-by:
Rosen Penev <rosenp@gmail.com> Closes https://github.com/MusicPlayerDaemon/MPD/issues/1499
-
Arsen Arsenović authored
Previous versions of MPD would, on parameter change, set the PipeWire volume before clearing the restore_volume flag, causing the call to short circuit and do nothing. Instead, clear the flag before the call.
-
Max Kellermann authored
This version was released 7 years ago, and it's reasonable to require at least this version.
-
Max Kellermann authored
-
- 26 Mar, 2022 1 commit
-
-
Vitaly Ostrosablin authored
Move audio output state check ahead of mixer check and force volume applying even for disabled software mixed outputs. This fixes incorrect software mixer volume that used to occur when volume was changed while output being disabled. This is easily reproduced with following sequence of commands on multi-output software mixed MPD setup. mpc volume 38; mpc disable 3; mpc volume 88; mpc enable 3 On current MPD, following commands would result in output 3 playing at volume 38, while all other enabled outputs would play at volume 88. Moreover, global volume would display average of outputs real volumes. In my case, it's 75. After applying this patch, following commands would produce expected behavior. All outputs play at expected (88) volume. And volume is correctly displayed as 88. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1423 Signed-off-by: Vitaly Ostrosablin tmp6154@yandex.ru Signed-off-by:
Vitaly Ostrosablin <tmp6154@yandex.ru>
-
- 16 Mar, 2022 1 commit
-
-
Max Kellermann authored
This is more of what we did in commit 70bd35ab because it turns out there are Ogg-Opus files with pages larger than 40 kB. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1487
-
- 14 Mar, 2022 6 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Closes https://github.com/MusicPlayerDaemon/MPD/issues/1482
-
Richard Schorrig authored
Wasapi output plugin won't start playing after being paused The cause is that the scope guard in the WASAPI work thread (WasapiOutputPlugin.cxx, function WasapiOutputThread::Work(), in the while (true) loop) is set up too 'late' in the execution. There is one condition ("if (data_in_frames >= buffer_size_in_frames)") when it is hit, the loop will continue without executing the scope guard. This scope guard is responsible for emptying the buffer again, and if the buffer is not emptied, the above mentioned condition will stay true. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1451
-
jcorporation authored
- supporting bmp and tiff seems outdated - webp is more widely used for coverimages
-
Max Kellermann authored
This part of the AVIOContext API is not documented :-( Closes https://github.com/MusicPlayerDaemon/MPD/issues/1448
-
- 09 Mar, 2022 1 commit
-
-
Max Kellermann authored
Must be initialized for the check in SetVolume().
-
- 26 Jan, 2022 1 commit
-
-
Max Kellermann authored
Don't return early from ScanOpusTags() if only TagHandler::WantPicture() is set. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1413
-
- 01 Dec, 2021 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Fixes regression by commit 8e0d8109 which is 2 years old, and nobody noticed. D'oh, how embarassing!
-
- 30 Nov, 2021 1 commit
-
-
Max Kellermann authored
Fixes regression by commit 774b4313
-
- 23 Nov, 2021 1 commit
-
-
Max Kellermann authored
Closes https://github.com/MusicPlayerDaemon/MPD/issues/1337
-
- 22 Nov, 2021 2 commits
-
-
Max Kellermann authored
Fixes "searchaddpl" bug emitting bogus error "Bad position". Closes https://github.com/MusicPlayerDaemon/MPD/issues/1338
-
Max Kellermann authored
Closes https://github.com/MusicPlayerDaemon/MPD/issues/1352
-
- 19 Nov, 2021 1 commit
-
-
Max Kellermann authored
Fixes building with GCC 12.
-
- 11 Nov, 2021 4 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
This reverts commit 552c30ea. It has caused various problems; for example, MPD wasn't able to write the pid_file (which was already mitigated by commit a4e42172). And apparently, the socket file created in the same directory by mpd.socket disappears when mpd.service (re)creates the directory. I could not reproduce this problem with 247.3, but maybe this is a bug in older systemd versions? Until we figure out why this happens, let's remove the RuntimeDirectory directive. A future MPD version may be launched as regular user, not as root, which will eliminate one major problem with RuntimeDirectory.
-
Max Kellermann authored
Closes https://github.com/MusicPlayerDaemon/MPD/issues/1328
-
- 09 Nov, 2021 1 commit
-
-
Max Kellermann authored
For libavcodec 59 support. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1333
-
- 05 Nov, 2021 2 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Commit 552c30ea caused problems for those people who still had a "pid_file" setting (even though that is obsolete with systemd), because now /run/mpd is owned by root:root (our mpd.service has no User=mpd directive, so systemd starts MPD as root). To work around this problem, and to be able to keep RuntimeDirectory=mpd (which solved a problem of other MPD users), the best compromise seems to just ignore the "pid_file" setting when it is of no use.
-