- 18 Nov, 2008 3 commits
-
-
Viliam Mateicka authored
The ffmpeg library provides some of the song metadata in the AVFormatContext struct. Pass it from there to MPD.
-
Viliam Mateicka authored
[mk: by definition, tag_new() cannot fail - removed check]
-
Max Kellermann authored
The chunk index passed to successor() must be valid, i.e. it must be smaller than num_chunks.
-
- 16 Nov, 2008 3 commits
-
-
Max Kellermann authored
Define the special value "-1" as "unknown size". Previously, there was no indicator for streams with unknown size, which might confuse some decoders.
-
Max Kellermann authored
With whence==AVSEEK_SIZE, the seek function should return the file size, not the current offset. Check the return value of input_stream_seek().
-
Max Kellermann authored
neaacdec.h declares all arguments as "unsigned long", but internally expects uint32_t pointers. This triggers gcc warnings on 64 bit architectures. To avoid that, make configure.ac detect whether we're using Debian's corrected headers or the original libfaad headers. In any case, pass a pointer to an uint32_t, conditionally casted to "unsigned long*".
-
- 15 Nov, 2008 3 commits
-
-
Max Kellermann authored
When the caller passes length==0, decoder_read() entered an endless loop. Check that condition before entering the "while" loop.
-
Laszlo Ashin authored
-
Laszlo Ashin authored
In 432da18e a dynamic buffer was replaced by a static one but some frees were accidently left there which caused some segfaults.
-
- 14 Nov, 2008 9 commits
-
-
Avuton Olrich authored
-
Max Kellermann authored
The threshold was only checked in the deprecated logging functions (ERROR(), WARNING(), ...). Add the check to the GLib logging handler.
-
Max Kellermann authored
alloca() is not a portable function. Don't use it. Using strncasecmp() is much more efficient anyway, because no memory needs to be allocated and copied.
-
Max Kellermann authored
-
Max Kellermann authored
Don't send a "next song" request to the main thread when the current song hasn't started playing yet, i.e. there are already two different songs in the music pipe. This would erase information about the song boundary within the music pipe, and thus triggered an assertion failure. The bug could occur when playing very short songs which fit into the pipe as a whole.
-
Max Kellermann authored
Fix a deadlock: when the decoder waited for buffer space, the player could enter a deadlock situation because it waits for more chunks for crossfading chunks. Signal the decoder before entering notify_wait().
-
László Áshin authored
The wavpack open function gives us an option called OPEN_STREAMING. This provides more robust and error tolerant playback, but it automatically disables seeking. (More exactly the wavpack lib will not return the length information.) So, if the stream is already not seekable we can use this option safely.
-
László Áshin authored
Wavpack plugin doesn't stop decoding if a block couldn't be fully decoded, rather it tries to go on.
-
László Áshin authored
-
- 13 Nov, 2008 10 commits
-
-
Max Kellermann authored
mp3 seeking was broken, because the command==SEEK check was never reached. Swap the command check order (==SEEK before !=NONE) to fix that.
-
Max Kellermann authored
When a command is sent while the decoder waits for a free chunk in the music pipe, it was not returned by decoder_data().
-
Avuton Olrich authored
-
Max Kellermann authored
Prevent superfluous wakeups and a deadlock condition.
-
Max Kellermann authored
Seeking was somewhat broken in some decoder plugins because they sent empty chunks, and never got a command. Check the decoder command before doing anything else in decoder_data().
-
Max Kellermann authored
When a CANCEL command is received, the player should drop all chunks of the next song. Added new funciton music_pipe_chop() which is used for that.
-
Max Kellermann authored
Provide a debug function which asserts on the sample format of all chunks. Call this function in each iteration of the player main loop.
-
Max Kellermann authored
When the decoder receives a SEEK during initialization, it should ignore that for now. The old code made most decoders abort.
-
Max Kellermann authored
Added an additional assertion which checks partial frames in the existing tail chunk.
-
Max Kellermann authored
When assigning the next_song_chunk variable, it must have been empty. If not, there may be 3 songs overlapping in the music pipe.
-
- 12 Nov, 2008 12 commits
-
-
Max Kellermann authored
This patch extends commit 35a16b99, and amends several 2 missing checks. It simplifies 2 more checks by merging "if" conditions.
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Unfortunately, ov_fopen() is not supported by libvorbis versions older than 1.2.
-
Max Kellermann authored
When the buffer was full, but everything was already consumed, fillAacBuffer() would not attempt to flush and refill it.
-
Max Kellermann authored
Allocate the input buffer within the AacBuffer struct.
-
Max Kellermann authored
The aac plugin does not support seeking. Reject SEEK requests by calling decoder_seek_error(). Quit the plugin's main loop only when STOP is received.
-
Max Kellermann authored
Removed a superfluous decoder_get_command() call.
-
Max Kellermann authored
The audio_format variable is only used and initialized for decoder_initialized(). Move it into that block to save some bytes on the stack.
-
Max Kellermann authored
aac_stream_decode() was basically copy+pasted from aac_decode(). Since stream_decode() can also decode files, eliminate aac_decode().
-
Max Kellermann authored
Check whether enough data has been read yet.
-
Max Kellermann authored
-