Don't scan tag items if the handler doesn't implement the tag()
method.

This is required if a stream ands without another chained FLAC file.

It's always 0.

If the duration is unknown, pass SignedSongTime::Negative(), as
documented for decoder_initialized().

This is obsolete because it has been moved to the MPD core.

Referencing the attribute "partition" is illegal after Close(),
because Close() deletes "this".

Fixes use-after-free bug (https://bugs.musicpd.org/view.php?id=4548).

The "seeking" flag is not set for the initial seek, and so
decoder_read() could be canceled when another SEEK was emitted during
initial seek.

This fixes several seek problems, for example the one reported for the
FLAC decoder plugin:

 https://bugs.musicpd.org/view.php?id=4552

libFLAC API documentation suggests that FLAC__stream_decoder_flush()
should be called to recover from FLAC__STREAM_DECODER_SEEK_ERROR.

Stop after all fatal errors.  This fixes assertion failures in
libFLAC.

No change for regular PCM, but DSD uses 0x69 now.

Fixes abort after seeking on fast machines.

Previously, volume was applied twice: once by PcmVolume, and again by
the hardware mixer.

.. instead of doing it after seeking.  After seeking, the command had
no effect, because CheckDecoderStartup() waits for all outputs to
finish.  This caused a very long delay while seeking and switching
songs (https://bugs.musicpd.org/view.php?id=4534).

This is a kludge which may break system include path order, see
https://bugs.musicpd.org/view.php?id=4524

See https://bugs.musicpd.org/view.php?id=4523

Fix out-of-tree build by prepending $(srcdir)/, and change *.sh to
*.rb.

Source: mpd
Version: 0.19.14-2
Severity: important
Justification: fails to build form source (but built in the past)
Tags: patch
User: debian-alpha@lists.debian.org
Usertags: alpha

mpd FTBFS on Alpha with a failure in the test suite [1]:

FAIL: test/test_byte_reverse
============================

.F...

!!!FAILURES!!!
Test Results:
Run:  4   Failures: 1   Errors: 0

1) test: ByteReverseTest::TestByteReverse2 (F) line: 58 test/test_byte_reverse.cxx
assertion failed
- Expression: strcmp(result, (const char *)dest) == 0

This occurs because the test suite (in test/test_byte_reversal.cxx)
allocates static char arrays and passes the char arrays to functions
whose respective arguments were declared to be uint16_t *, etc., in
the main code.

This is in the realm of undefined behaviour on architectures with
strict memory alignment requirements.  Although the test only fails
on Alpha (because Alpha has a particular CPU load instruction that
gcc likes to use to add bugs ..., ahem,  optimise the code on the
assumption of alignment) it is potentially a latent bug for other
architectures with strict alignment requirements.

Since the code is compiled with the c++11 standard I attach a patch
that modifies the test suite to align the non-compliant strings with
the alignas() attribute.  The test suite now passes on Alpha with
that patch.

Cheers
Michael

[1] https://buildd.debian.org/status/fetch.php?pkg=mpd&arch=alpha&ver=0.19.14-2&stamp=1461542099