When waiting for free space in the ring buffer, the JACK plugin
sleeped 10ms until there is enough space.  This delay was too large
for low-latency setups (<10ms), and created a lot of xruns.  Work
around that by reducing the sleep time to 1ms.

A proper solution for this would be to use an event based approach,
and we will do it, just not now.

When the connection failed once, you had to restart MPD, because it
never cleared the jack_data.shutdown flag.  Instead, it refused to
play anything "because there is no client thread" (which is wrong at
that point).

If the ring buffers are allocated after jack_activate(),
mpd_jack_process() might segfault because it attempts to access them.

Call jack_port_register() before jack_activate().

The variable "serviceName" is initialized with SERVICE_NAME, but was
overwritten with NULL when the setting is not configured.

GIOChannel is more portable than raw read()/write() calls.  We're
using GIOChannel anyway, because we need it for plugging the client
into the GLib main loop.

Configure the GIOChannel to the bare minimum: no character set, no
buffering.

Use g_io_channel_win32_new_socket() instead of g_io_channel_unix_new()
on WIN32.

This variable doesn't have a role since 80799fa8.

http://xkcd.com/292/

On some platforms, g_free() must be used for memory allocated by
GLib.  This patch intends to correct a lot of occurrences, but is
probably not complete.

Create a HTML chunk of each DocBook chapter.  Use the UTF-8 character
set instead of docbook-xsl's ISO-Latin-1 default.

The mixer plugins should re-use the mixer struct and incorporate it in
their object class.

Both methods are always called together.  There is no point in having
them separate.  This simplifies the code, because the old configure()
method could be called more than once, and had to free old
allocations.

Those have been superseded by the new legacy configuration code.

Reimplemented the legacy mixer configuration: copy the deprecated
configuration values into the audio_output section.  Don't configure
the mixers twice (once for the audio_output, and a second time for the
legacy values).

This requires volume_init() to be called before initAudioDriver().

Allocate the mixer object when it is configured.

Merged mixer_configure() into mixer_new().  mixer_new() was quite
useless anyway.

Don't use statically allocated mixer objects.

The plugin structures must never be modified.

The function config_add_param() allows adding new configuration
parameters.

Return the default value in the conf_get_block_*() functions when
param==NULL was passed.

This simplifies a lot of code, because all initialization can be done
in one code path, regardless whether configuration is present.

All config_get_block_*() functions should accept constant config_param
pointers.

config_get_string() is easier to use than config_get_param() because
it unpacks the config_param struct.

Both are unused.

This function shuffles the last song of a range.  This is used by
addSongToPlaylist().

Don't declare and export variables specific to stored playlists in
playlist.c/playlist.h.

Start the decoder thread when the player thread starts.  The decoder
thread is already stopped by the player thread.

player_control.thread contains the handle of the player thread, or
NULL if the player thread isn't running.

decoder_control.thread contains the handle of the decoder thread, or
NULL if the decoder thread isn't running.

Some code will be a little bit simpler if the dot is part of the
string literal.

Document alsa_data members.

frame_size is a memory size and should be a size_t, not a signed integer.

Renamed types, functions, variables.

Two bugs here led to a large number of interrupts being generated on the
sound card when ALSA output is being used. Because we specify no default
period_time, the sound card gives us 3000 interrupts/sec rather than a more
sane 20 or 30. This completes the revert of dd7711 already started by
4ca24f.

The larger bug was in the change to config_get_block_unsigned() and using 0
as the default value for both 'buffer_time' and 'period_time'. This means
any pre-setting of these options in newAlsaData() gets wiped out. Add a new
default for period_time, and ensure default values for buffer_time and
period_time are used if none are provided by the user.
Signed-off-by: Dan McGee <dan@archlinux.org>
[mk: set defaults in newAlsaData() to fix auto-configuration; renamed
"_MS" back to "_US" because ALSA expects microseconds, not milliseconds]
Signed-off-by: Max Kellermann <max@duempel.org>