The normal case was to use the builtin icons. There were two cases
where the icon file was read from disk:

1) /usr/NX/share/images/nxagent.xpm was existing which normally is not
   there

2) case 2 was not true and nxagent.xpm was existing somewhere in the
   PATH (!)

(replace nxagent.xpm by x2goagent.xpm if in x2gp mode)

Scanning the path from the PATH variable for xpm files is kind of
unexpected and dangerous, too (think of automounter triggers or
invalid xpm files).

Also remove the xpm files from the distribution.

This leads to a tremendous startup speedup (several seconds, depending
on latency) because libXpm had to do a lot of X requests (have not
further examined which). With this colour-reduced version things are
quick again for those connections without losing a lot of quality.

Fixes ArcticaProject/nx-libs#824

gimp refused to load it, nxagent crashed if this was loaded as icon file!

Most <int> options are <bool>. Change that and add missing
defaults. Also add list of descriptions for the defer option.

fix one FIXME. This is a rewritten and extended version of a quick
patch by Danil Pleshakov and Dimbor.

Correctly determine the Atom names from the real X server.

The previously used "Atom" type was confusing. Clarify this by
writing the code as requested in the manpage of XChangeProperty:

"If the specified format is 8, the property data must be a char array.
If the specified format is 16, the property data must be a short
array.  If the specified format is 32, the property data must be a
long array."

make i a local loop variable everywhere by changing the while loop to
a for loop.

This fixes a possible unitialized struct variable.

plus some minor formatting fixes

This check has already been done before we reach here.

Also add some comments about a condition that will never occur...

This makes them much more readable

This should disable clipboard but effictively did activate clipboard=both.

Right at the beginnigng of nxagentParseSingleOption we check for
"clipboard" and prepare argv and argc accordingly for
ddxProcessArgument. The removed code thus could never be reached.

"clipboard=something" does not need to be passed on, so return after
setting nxagentOptions accordingly. This fixes

[nx-X11/programs/Xserver/hw/nxagent/Args.c:1584]: (error) Uninitialized variable: argc

instead of a full copy. We still have our own function because we
need to handle the nxagentGlxTrap. This trap is now set before the
start of the dispatcher while it has been set only directly before
calling the dispatched function.

Saves ~50 duplicated lines.

DeleteWindow() is calling FreeWindowResources() which is calling
DisposeWindowOptional() which sets pWin->optional to NULL. So the now
removed code was never called. After removal DeleteWindow() is
identical to the dix version, so we use that one.

many functions are almost identical to dix. Mark the minimal changes.

The only difference to the dix version was a fprintf if compiled with
-D TEST.