nxagent.1 man page: Some layout fixes for string options with well-defined expected selections of values.

hw/nxagent/Display.c: Fix comment where the meaning of the "bypass" reconnectchecks parameter value is explained.

Attributes GH PR #183: https://github.com/ArcticaProject/nx-libs/pull/183

Together with PR #143 this fixes ArcticaProject/nx-libs#132.

t merges an updated upstream into a topic branch.

nx-X11/programs/Xserver/hw/nxagent/Display.c: add FIXME comment to nxagentCheckForColormapsCompatibility().

Maybe needs special strictness handling as well.

Maybe needs special strictness handling as well.

nx-X11/programs/Xserver/hw/nxagent/Display.c: split up nxagentCheckForPixmapFormatsCompatibility() and nxagentInitPixmapFormats().

Don't implicitly call the checking function in the init function (and throw
away the checking functions result...)

Instead, explicitly use the checking function after the init function in other
parts of the code and throw away the checking functions return value
selectively or actually use it while reconnecting.

This is totally different behavior compared to the original one. Hopefully it
doesn't cause any problems (i.e., hopefully there was no good reason for never
using the checking functions return value, but an oversight.)

nx-X11/programs/Xserver/hw/nxagent/Display.c: use new ReconnectTolerance nxagentOption value in nxagentCheckForPixmapFormatsCompatibility() and modify behavior based on this value.

Recognized values:
  - Strict means that the number of internal and
    external pixmap formats must match exactly and
    every internal pixmap format must be available
    in the external pixmap format array.
  - Safe means that the number of pixmap formats might
    diverge, but all internal pixmap formats must
    also be included in the external pixmap formats
    array. This is recommended, because it allows
    clients with more pixmap formats to still connect,
    but not lose functionality.
  - Risky means that the internal pixmap formats array
    is allowed to be smaller than the external pixmap
    formats array, but at least one pixmap format must
    be included in both. This is potentially unsafe.
  - Bypass or higher means that all of these checks are
    essentially deactivated. This is a very bad idea.

Note that the default ReconnectTolerance value is still Strict.

Also, the return value of this function is currently not used or passed through
to other functions at all. An upcoming commit will change this behavior and
actually enable the checks.

nx-X11/programs/Xserver/hw/nxagent/Display.c: use new ReconnectTolerance nxagentOption value in nxagentCheckForDepthsCompatibility() and modify behavior based on this value.

Recognized values:
  - Strict means that the number of old and new depths must
    match exactly and every old depth value must be
    available in the new depth array.
  - Safe means that the number of depths might diverge,
    but all former depth must also be included in the
    new depth array. This is recommended, because
    it allows clients with more depths to still
    connect, but not lose functionality.
  - Risky means that the new depths array is allowed to be
    smaller than the old depths array, but at least
    one depth value must be included in both.
    This is potentially unsafe.
  - Bypass or higher means that all of these checks are
    essentially deactivated. This is a very bad idea.

Note that the default ReconnectTolerance value is still Strict.

nx-X11/programs/Xserver/hw/nxagent/Display.c: use new ReconnectTolerance nxagentOption in nxagentCheckForDefaultDepthCompatibility() and modify behavior based on this value.

Recognized values:
  - Strict means that the old and new default depth values
    must match exactly.
  - Safe or Risky means that the default depth values
    might differ, but the new default depth value must be at
    least as high as the former default depth value. This is
    recommended, because it allows clients with a
    higher default depth value to still connect, but
    not lose functionality.
  - Bypass or higher means that all of these checks are
    essentially deactivated. This is probably a very
    bad idea.

Note that the default ReconnectTolerance value is still Strict.

{nx-X11/programs/Xserver/hw/nxagent/{Args.c,Options.{c,h}},nxcomp/{Loop,Misc}.cpp}: add tolerancechecks parameter as an nx/nx option and ReconnectTolerance as an nxagentOption.

Attributes GH PR #189: https://github.com/ArcticaProject/nx-libs/pull/189

Attributes GH PR #182: https://github.com/ArcticaProject/nx-libs/pull/182
Reviewed by: Nicolas Arenas <narenas@qindel.com>  -- Tue, 05 Jul 2016 06:15:57 -0700
Reviewed by: Mihai Moldovan <ionic@ionic.de>  -- Tue, 05 Jul 2016 09:40:04 -0700
Reviewed by: Ulrich Sibiller <uli42@gmx.de>  -- Tue, 05 Jul 2016 13:57:05 -0700

:44:48 -0700
Reviewed by: Ulrich Sibiller <uli42@gmx.de>  -- Tue, 05 Jul 2016 13:57:05 -0700

 This has already been started while replacing copyright info in file
 headers and has now been completed with this commit.

Per-file copyright notices: Update copyright information in file headers that NoMachine placed there own copyright statement in.

remove NEED_EVENTS/NEED_REPLIES

Remove defines of NEED_EVENTS and NEED_REPLIES because they are never
used anywhere.

Basically these three commits, but as they are newer and to not match
the code structure the patches have not been applied but replaced by
sed + manual intervention:

   From cb95642dc8edebb2935dd471f8b339cb98aa8481 Mon Sep 17 00:00:00 2001
   From: Peter Hutterer <peter.hutterer@redhat.com>
   Date: Fri, 28 Nov 2008 22:28:32 +1000
   Subject: Remove #define NEED_EVENTS and NEED_REPLIES

   A grep on xorg/* revealed there's no consumer of this define.

   Quote Alan Coopersmith:
   "The consumer was in past versions of the headers now located
   in proto/x11proto - for instance, in X11R6.0's xc/include/Xproto.h,
   all the event definitions were only available if NEED_EVENTS were
   defined, and all the reply definitions required NEED_REPLIES.

   Looks like Xproto.h dropped them by X11R6.3, which didn't have
   the #ifdef's anymore, so these are truly ancient now."
Signed-off-by: Peter Hutterer <peter.hutterer@redhat.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>

--

   From 6de368c9aa7ccd2fcd62fca5a2b278913db4d03d Mon Sep 17 00:00:00 2001
   From: Fernando Carrijo <fcarrijo@yahoo.com.br>
   Date: Thu, 1 Jul 2010 06:50:47 -0300
   Subject: Purge macros NEED_EVENTS and NEED_REPLIES
Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
Acked-by: Tiago Vignatti <tiago.vignatti@nokia.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

--

   From 57c03e52e6b4e3ed54df5fdd778865467d08e119 Mon Sep 17 00:00:00 2001
   From: Fernando Carrijo <fcarrijo@yahoo.com.br>
   Date: Thu, 1 Jul 2010 06:59:48 -0300
   Subject: Purge macro NEED_EVENTS
Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
Acked-by: Tiago Vignatti <tiago.vignatti@nokia.com>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

debian/nxproxy.docs: Fix FTBFS due to missing documentation files (moved out of the way with recent commits).

Attributes GH PR #178: https://github.com/ArcticaProject/nx-libs/pull/178
Reviewed by: Vadim Troshchinskiy <vadim@qindel.com> --  Tue, 05 Jul 2016 02:37:08 -0700

 Casting return to (void) was used to tell lint that you intended
 to ignore the return value, so it didn't warn you about it.

 Casting the third argument to (char *) was used as the most generic
 pointer type in the days before compilers supported C89 (void *)
 (except for a couple places it's used for byte-sized pointer math).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Tested-by: Daniel Stone <daniel@fooishbar.org>
 Backport to nx-libs: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>

 Enough with the casting.  Doesn't break API or even ABI, but does make
 a lot of silly casts superfluos.