1. 22 Jun, 2019 23 commits
    • Ulrich Sibiller's avatar
      xkmread.c: fix compiler warning · 31c3d27e
      Ulrich Sibiller authored
      xkmread.c: In function ‘XkmReadFileSectionName’:
      xkmread.c:1181:25: warning: ‘tmpTOC.type’ may be used uninitialized in this function [-Wmaybe-uninitialized]
           XkbConfigText(tmpTOC.type,XkbMessage),0);
      31c3d27e
    • Ulrich Sibiller's avatar
      xkb: Silence some compiler warnings · 813acdd2
      Ulrich Sibiller authored
        commit 83913de25d35709b3ab7b0ab124b73924145d2dd
        Author: Adam Jackson <ajax@redhat.com>
        Date:   Thu Apr 5 12:59:11 2018 -0400
      
          xkb: Silence some compiler warnings
      
          Of the form:
      
          ../xkb/XKBGAlloc.c: In function ‘SrvXkbAddGeomKeyAlias’:
          ../xkb/XKBGAlloc.c:591:13: warning: ‘strncpy’ specified bound 4 equals destination size [-Wstringop-truncation]
                       strncpy(alias->real, realStr, XkbKeyNameLength);
                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
          This is intentional; the code that reads from these fields never reads
          more than 4 bytes anyway. Rephrase things in terms of memcpy so that's
          clear. Obviously this is awful but in XKB awful is par.
      Signed-off-by: 's avatarAdam Jackson <ajax@redhat.com>
      Acked-by: 's avatarKeith Packard <keithp@keithp.com>
      813acdd2
    • Ulrich Sibiller's avatar
      xkb: Use snprintf to measure string lengths instead of manual strlen math · 054e906f
      Ulrich Sibiller authored
        commit a4a2e814d5d0e6152307a301eda1d6fc1c555aaa
        Author: Alan Coopersmith <alan.coopersmith@oracle.com>
        Date:   Sun Feb 13 21:36:02 2011 -0800
      
          xkb: Use snprintf to measure string lengths instead of manual strlen math
      Signed-off-by: 's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      Signed-off-by: 's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Reviewed-by: 's avatarDaniel Stone <daniel@fooishbar.org>
      054e906f
    • Ulrich Sibiller's avatar
      xkbEvents.c: Fix "warning: unused variable `s'". · 2070891c
      Ulrich Sibiller authored
        commit 2391c409a2840d61fed93832650c0d6c82ebebdf
        Author: Eamon Walsh <ewalsh@tycho.nsa.gov>
        Date:   Fri Jun 13 22:48:17 2008 -0400
      
          Fix "warning: unused variable `s'".
      2070891c
    • Ulrich Sibiller's avatar
      XKB: Remove a bunch of mad ifdefs · 4962c5a8
      Ulrich Sibiller authored
        commit 534fc5140b039a8c98ab715d0a6740d513b41209
        Author: Daniel Stone <daniel@fooishbar.org>
        Date:   Sun Feb 3 23:30:22 2008 +1100
      
          XKB: Remove a bunch of mad ifdefs
      
          We have SEEK_SET and size_t, seriously.  Also use DebugF instead of
          ifdef DEBUG, and ditch a couple of random bits that were never used.
      4962c5a8
    • Ulrich Sibiller's avatar
      xkb: remove oldState from XkbHandleActions. · 56dcc8a4
      Ulrich Sibiller authored
      Fixes this cppcheck finding:
      [nx-X11/programs/Xserver/xkb/xkbActions.c:1306]: (error) Uninitialized variable: oldState
      
        commit 35a4b8e7f4526a92d44cb16a783f21030cd1f6df
        Author: Peter Hutterer <peter.hutterer@who-t.net>
        Date:   Tue May 5 16:51:59 2009 +1000
      
          xkb: remove oldState from XkbHandleActions.
      
          I really don't know what the purpose of this variable is or was, aside from
          potentially clobbering up our key state since there's a path where it may be
          used uninitialised.
      
          Also, this means that xkbi->prev_state is now accessible from the DIX with
          meaningful data.
      Signed-off-by: 's avatarPeter Hutterer <peter.hutterer@who-t.net>
      56dcc8a4
    • Ulrich Sibiller's avatar
      mi/miexpose.c: add missing free() · c8520ac0
      Ulrich Sibiller authored
      c8520ac0
    • Ulrich Sibiller's avatar
      compext/Png.c: Nullify after free · 956caeb8
      Ulrich Sibiller authored
      956caeb8
    • Ulrich Sibiller's avatar
      e440e722
    • Ulrich Sibiller's avatar
      compext/Png.c: late image_index allocation · d4882419
      Ulrich Sibiller authored
      Move allocation of image_index close before first_use. This way we do
      not need to free it if previous step fail. And we cannot forget that
      free() call.
      
      While at it replace malloc+memset by calloc.
      d4882419
    • Ulrich Sibiller's avatar
      NXdixfonts.c: fix index out of bounds · b4d3dc5b
      Ulrich Sibiller authored
      b4d3dc5b
    • Ulrich Sibiller's avatar
      Keyboard.c: rearrange code to make cppcheck happy · fd7e1f98
      Ulrich Sibiller authored
      Otherwise it will (falsely) report "Memory pointed to by 'sessionpath' is freed twice."
      fd7e1f98
    • Ulrich Sibiller's avatar
      os/access.c: add missing } · 3c046997
      Ulrich Sibiller authored
      3c046997
    • Ulrich Sibiller's avatar
      NXpicture.c: code simplification · 528e1e4e
      Ulrich Sibiller authored
      528e1e4e
    • Ulrich Sibiller's avatar
      bb08043a
    • Ulrich Sibiller's avatar
      Screen.c: fix two memleaks · 213e63ee
      Ulrich Sibiller authored
      While at it create and use the freeDepths() helper function.
      213e63ee
    • Ulrich Sibiller's avatar
      NXrender: fix another memleak · e63d9de4
      Ulrich Sibiller authored
      e63d9de4
    • Ulrich Sibiller's avatar
      render: Propagate allocation failure from createSourcePicture() · 78eff73e
      Ulrich Sibiller authored
        commit 211d4c2d353b5e379716484055a3f58235ea65f4
        Author: Chris Wilson <chris@chris-wilson.co.uk>
        Date:   Wed Dec 14 15:55:22 2011 +0000
      
          render: Propagate allocation failure from createSourcePicture()
      
          All the callers were already checking for failure, except that
          createSourcePicture() itself was failing to check whether it
          successfully allocated the Picture.
      
          [ajax: Rebase, fix line wrap of preceding line]
      Signed-off-by: 's avatarChris Wilson <chris@chris-wilson.co.uk>
      Reviewed-by: 's avatarJeremy Huddleston <jeremyhu@apple.com>
      78eff73e
    • Ulrich Sibiller's avatar
      fb: fix memory leak in fbOverlayFinishScreenInit · 9f9b790f
      Ulrich Sibiller authored
        commit 2aa935bc5cc1e2d5365a97b8c5bb3d33eb5fc758
        Author: Tiago Vignatti <tiago.vignatti@nokia.com>
        Date:   Fri Mar 25 22:10:55 2011 +0200
      
          fb: fix memory leak in fbOverlayFinishScreenInit
      Signed-off-by: 's avatarTiago Vignatti <tiago.vignatti@nokia.com>
      Reviewed-by: 's avatarNicolas Peninguy <nico@lostgeeks.org>
      Reviewed-by: 's avatarPeter Hutterer <peter.hutterer@who-t.net>
      9f9b790f
    • Ulrich Sibiller's avatar
      dix/dispatch: fix a small memory leak · f5540257
      Ulrich Sibiller authored
      f5540257
    • Ulrich Sibiller's avatar
      Quarks.c: add missing ) · 6f954bb7
      Ulrich Sibiller authored
      6f954bb7
    • Ulrich Sibiller's avatar
      Keyboard.c: fix three memory leaks · 6da10661
      Ulrich Sibiller authored
      ==12976==ERROR: LeakSanitizer: detected memory leaks
      
      Direct leak of 6 byte(s) in 1 object(s) allocated from:
          #0 0x7f510b3ac810 in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x3a810)
          #1 0x559ca29c5035 in nxagentKeyboardProc /home/uli/work/nx/ArcticaProject/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Keyboard.c:866
          #2 0x7a29bff07  (<unknown module>)
      
      Direct leak of 1 byte(s) in 1 object(s) allocated from:
          #0 0x7f510b3ac810 in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x3a810)
          #1 0x559ca29c509a in nxagentKeyboardProc /home/uli/work/nx/ArcticaProject/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Keyboard.c:870
          #2 0x7a29bff07  (<unknown module>)
      
      Direct leak of 1 byte(s) in 1 object(s) allocated from:
          #0 0x7f510b3ac810 in strdup (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x3a810)
          #1 0x559ca29c507f in nxagentKeyboardProc /home/uli/work/nx/ArcticaProject/nx-libs/nx-X11/programs/Xserver/hw/nxagent/Keyboard.c:869
          #2 0x7a29bff07  (<unknown module>)
      
      SUMMARY: AddressSanitizer: 8 byte(s) leaked in 3 allocation(s).
      6da10661
    • Ulrich Sibiller's avatar
      glyph.c: fix a read beyond end of heap buffer · 234be024
      Ulrich Sibiller authored
      If compiled with -fsanitize=address this showed up when running startlxde:
      
      ==11551==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60d000018fbc at pc 0x7f270a9ed57b bp 0x7fff30ef3050 sp 0x7fff30ef2800
      READ of size 204 at 0x60d000018fbc thread T0
          #0 0x7f270a9ed57a  (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xb857a)
          #1 0x559dafcd5c93 in FindGlyphRef ../../render/glyph.c:179
          #2 0x559dafcd705d in AddGlyph /work/nx-libs/nx-X11/programs/Xserver/hw/nxagent/NXglyph.c:71
          #3 0x559dafccc0ff in ProcRenderAddGlyphs ../../mi/../render/render.c:1186
          #4 0x559dafcbd5a5 in ProcRenderDispatch /work/nx-libs/nx-X11/programs/Xserver/hw/nxagent/NXrender.c:1689
          #5 0x559dafcbc4ea in Dispatch /work/nx-libs/nx-X11/programs/Xserver/hw/nxagent/NXdispatch.c:476
          #6 0x559dafc4e9b0 in main /work/nx-libs/nx-X11/programs/Xserver/dix/main.c:353
          #7 0x7f2708e1d09a in __libc_start_main ../csu/libc-start.c:308
          #8 0x559dafc4f5d9 in _start (/work/nx-libs/nx-X11/programs/Xserver/nxagent+0x6e5d9)
      
      0x60d000018fbc is located 0 bytes to the right of 140-byte region [0x60d000018f30,0x60d000018fbc)
      allocated by thread T0 here:
          #0 0x7f270aa1e330 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0xe9330)
          #1 0x559dafcd646c in AllocateGlyph ../../render/glyph.c:348
      
      This happens when two glyphs are compared via memcmp and the smaller
      one happens to be identical to the beginning of the bigger one.
      
      Newer render implementations use a sha1 hash instead of memcmp so this
      patch will (hopefully) be obsolete once render gets updated.
      234be024
  2. 18 Jun, 2019 17 commits
    • Ulrich Sibiller's avatar
      Font.c: code simplifications · 8205db42
      Ulrich Sibiller authored
      8205db42
    • Ulrich Sibiller's avatar
      various scope improvements · cb508b26
      Ulrich Sibiller authored
      cb508b26
    • Ulrich Sibiller's avatar
      glxext.c: fix another memory leak · bffdacc4
      Ulrich Sibiller authored
      ==10226== 3,337 bytes in 1 blocks are definitely lost in loss record 295 of 307
      ==10226==    at 0x483577F: malloc (vg_replace_malloc.c:299)
      ==10226==    by 0x6281DB9: strdup (strdup.c:42)
      ==10226==    by 0x2ABA9E: __glXClientInfo (glxcmds.c:2170)
      ==10226==    by 0x17CA3E: __glXDispatch (NXglxext.c:128)
      ==10226==    by 0x16EE77: Dispatch (NXdispatch.c:476)
      ==10226==    by 0x14DCE0: main (main.c:353)
      
      There's no point in trying to free cl->* after memset(0).
      
      This one is a bug that is found identically in xorg upstream and has
      only been fixed during rework of the whole client resource freeing
      stuff. So we fix it in glxext.c.
      bffdacc4
    • Ulrich Sibiller's avatar
      Screen.c: more debug output · b5eb7c76
      Ulrich Sibiller authored
      b5eb7c76
    • Ulrich Sibiller's avatar
      Extension.c: code simplifications · 7e12c9ba
      Ulrich Sibiller authored
      7e12c9ba
    • Ulrich Sibiller's avatar
    • Ulrich Sibiller's avatar
      mi/miinitext.c: fix memleaks: remove (double) glx initialization · 5cb49714
      Ulrich Sibiller authored
      Fix these memory leaks:
      
      ==30021== 128 bytes in 1 blocks are definitely lost in loss record 230 of 302
      ==30021==    at 0x483577F: malloc (vg_replace_malloc.c:299)
      ==30021==    by 0x2EF89C: init_visuals (xf86glx.c:390)
      ==30021==    by 0x2EF89C: __MESA_initVisuals (xf86glx.c:541)
      ==30021==    by 0x17C922: GlxInitVisuals (glxext.c:317)
      ==30021==    by 0x218E73: fbInitVisuals (fbcmap.c:668)
      ==30021==    by 0x20BEB1: fbFinishScreenInit (fbscreen.c:229)
      ==30021==    by 0x20C275: fbScreenInit (fbscreen.c:273)
      ==30021==    by 0x1E0317: nxagentOpenScreen (Screen.c:1357)
      ==30021==    by 0x16D848: AddScreen (dispatch.c:4171)
      ==30021==    by 0x1DB7FF: InitOutput (Init.c:396)
      ==30021==    by 0x14DB12: main (main.c:279)
      ==30021==
      ==30021== 3,072 (192 direct, 2,880 indirect) bytes in 1 blocks are definitely lost in loss record 290 of 302
      ==30021==    at 0x483577F: malloc (vg_replace_malloc.c:299)
      ==30021==    by 0x2CCCC7: _gl_context_modes_create (glcontextmodes.c:364)
      ==30021==    by 0x2EF87C: init_visuals (xf86glx.c:381)
      ==30021==    by 0x2EF87C: __MESA_initVisuals (xf86glx.c:541)
      ==30021==    by 0x17C922: GlxInitVisuals (glxext.c:317)
      ==30021==    by 0x218E73: fbInitVisuals (fbcmap.c:668)
      ==30021==    by 0x20BEB1: fbFinishScreenInit (fbscreen.c:229)
      ==30021==    by 0x20C275: fbScreenInit (fbscreen.c:273)
      ==30021==    by 0x1E0317: nxagentOpenScreen (Screen.c:1357)
      ==30021==    by 0x16D848: AddScreen (dispatch.c:4171)
      ==30021==    by 0x1DB7FF: InitOutput (Init.c:396)
      ==30021==    by 0x14DB12: main (main.c:279)
      
      The problem here is that GlxInitVisuals is called twice. First via
      fbScreenInit and then again via nxagentInitGlxExtension. We remove the
      first one to ensure the code in nxagenOpenScreen works as initially
      intended.
      
      There's an xorg upstream patch that does the same
      (7d74690536b64f7b8e8036507ab7790807349c50), but it also cleans up
      other stuff we do not even have in out source (yet?).
      5cb49714
    • Ulrich Sibiller's avatar
      Screen.c: fix another memory leak · 75644222
      Ulrich Sibiller authored
      ==12280== 0 bytes in 5 blocks are definitely lost in loss record 1 of 304
      ==12280==    at 0x483577F: malloc (vg_replace_malloc.c:299)
      ==12280==    by 0x2EFC29: init_visuals (xf86glx.c:489)
      ==12280==    by 0x2EFC29: __MESA_initVisuals (xf86glx.c:540)
      ==12280==    by 0x17C902: GlxInitVisuals (glxext.c:317)
      ==12280==    by 0x218C03: fbInitVisuals (fbcmap.c:668)
      ==12280==    by 0x20BC41: fbFinishScreenInit (fbscreen.c:229)
      ==12280==    by 0x20C005: fbScreenInit (fbscreen.c:273)
      ==12280==    by 0x1E024C: nxagentOpenScreen (Screen.c:1356)
      ==12280==    by 0x16D828: AddScreen (dispatch.c:4171)
      ==12280==    by 0x1DB7DF: InitOutput (Init.c:396)
      ==12280==    by 0x14DB12: main (main.c:279)
      ==12280==
      ==12280== 64 bytes in 2 blocks are definitely lost in loss record 223 of 304
      ==12280==    at 0x483577F: malloc (vg_replace_malloc.c:299)
      ==12280==    by 0x2EFA05: init_visuals (xf86glx.c:489)
      ==12280==    by 0x2EFA05: __MESA_initVisuals (xf86glx.c:540)
      ==12280==    by 0x17C902: GlxInitVisuals (glxext.c:317)
      ==12280==    by 0x218C03: fbInitVisuals (fbcmap.c:668)
      ==12280==    by 0x20BC41: fbFinishScreenInit (fbscreen.c:229)
      ==12280==    by 0x20C005: fbScreenInit (fbscreen.c:273)
      ==12280==    by 0x1E024C: nxagentOpenScreen (Screen.c:1356)
      ==12280==    by 0x16D828: AddScreen (dispatch.c:4171)
      ==12280==    by 0x1DB7DF: InitOutput (Init.c:396)
      ==12280==    by 0x14DB12: main (main.c:279)
      75644222
    • Ulrich Sibiller's avatar
      Fix memleaks: Free devPrivates of devices on shutdown · 4dd1f3cb
      Ulrich Sibiller authored
      Fixes these two memory leaks identified by valgrind:
      
      ==28336== 32 (8 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 180 of 308
      ==28336==    at 0x48356AF: malloc (vg_replace_malloc.c:298)
      ==28336==    by 0x4837DE7: realloc (vg_replace_malloc.c:826)
      ==28336==    by 0x1AE322: AllocateDevicePrivate (privates.c:439)
      ==28336==    by 0x27527B: XkbSetExtension (xkbActions.c:72)
      ==28336==    by 0x198E9B: _RegisterPointerDevice (devices.c:361)
      ==28336==    by 0x1DBA35: InitInput (Init.c:440)
      ==28336==    by 0x14DBD6: main (main.c:303)
      ==28336==
      ==28336== 32 (8 direct, 24 indirect) bytes in 1 blocks are definitely lost in loss record 181 of 308
      ==28336==    at 0x48356AF: malloc (vg_replace_malloc.c:298)
      ==28336==    by 0x4837DE7: realloc (vg_replace_malloc.c:826)
      ==28336==    by 0x1AE322: AllocateDevicePrivate (privates.c:439)
      ==28336==    by 0x27527B: XkbSetExtension (xkbActions.c:72)
      ==28336==    by 0x198F1B: _RegisterKeyboardDevice (devices.c:384)
      ==28336==    by 0x1DBA3D: InitInput (Init.c:441)
      ==28336==    by 0x14DBD6: main (main.c:303)
      4dd1f3cb
    • Ulrich Sibiller's avatar
      CloseDevice: call XkbRemoveResourceClient before freeing key class struct · ca741177
      Ulrich Sibiller authored
      This patch is not necessary at the current code level. But when xkb
      code introduced the dev->key check Xorg upstream missed that. So we
      backport it now to skip that trap when updating xkb code.
      
        Author: Alan Coopersmith <alan.coopersmith@sun.com>
        Date:   Mon Jan 4 18:21:54 2010 -0800
      
          CloseDevice: call XkbRemoveResourceClient before freeing key class struct
      
          XkbRemoveResourceClient() returns immediately if dev->key is NULL.
          CloseDevice calls XkbRemoveResourceClient until it removes all resources.
      
          If we free dev->key and NULL it before XkbRemoveResourceClient, then
          infinite loop ensues, and the server appears to hang on exit or crash.
      Signed-off-by: 's avatarAlan Coopersmith <alan.coopersmith@sun.com>
      Reviewed-by: 's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Reviewed-by: 's avatarDaniel Stone <daniel@fooishbar.org>
      Signed-off-by: 's avatarKeith Packard <keithp@keithp.com>
      Backported-to-NX-by: 's avatarUlrich Sibiller <uli42@gmx.de>
      ca741177
    • Ulrich Sibiller's avatar
      Keyboard.c: nullify freed pointers · 340de78e
      Ulrich Sibiller authored
      While trying to properly free memory allocated by XKB I accidently
      called nxagentFreeKeyboardDeviceData twice and noticed it would cause
      a segfault here. As the other pointers are also nullified after
      being freed let's just do it here, too.
      340de78e
    • Ulrich Sibiller's avatar
      Screen.c: Fix: make sure RRCloseScreen is being called · 3b06ad51
      Ulrich Sibiller authored
      Fixes ArcticaProject/nx-libs#598
      
      In nxagentOpenScreen we first initialized the RRExtension for the
      screen and then replaced pScreen->CloseScreen by
      nxagentCloseScreen. This resulted in RandR's RRCloseScreen (and any
      other CloseScreen procedure installed by extensions) being no longer
      called.
      
      Moving RandR init after configuring pScreen->CloseScreen ensures the
      correct calling cascade:
      
      RRCloseScreen -> nxagentCloseScreen ->fbCloseScreen (called explicitly
      by nxagentCloseScreen).
      
      Which in turn will fix this memory leak:
      
      ==9688== 328 (312 direct, 16 indirect) bytes in 1 blocks are definitely lost in loss record 271 of 319
      ==9688==    at 0x4837B65: calloc (vg_replace_malloc.c:752)
      ==9688==    by 0x4ED2C6: RRScreenInit (randr.c:329)
      ==9688==    by 0x1F2B18: nxagentInitRandRExtension (Extensions.c:122)
      ==9688==    by 0x1DEAFF: nxagentOpenScreen (Screen.c:1409)
      ==9688==    by 0x16D7F8: AddScreen (dispatch.c:4257)
      ==9688==    by 0x1DA0CF: InitOutput (Init.c:397)
      ==9688==    by 0x14DCC2: main (main.c:280)
      3b06ad51
    • Ulrich Sibiller's avatar
      Screen.c: correctly free stuff in nxagentCloseScreen · 0f8dbbab
      Ulrich Sibiller authored
      fixes a memory leak:
      
      ==19074== 2 bytes in 1 blocks are definitely lost in loss record 8 of 313
      ==19074==    at 0x483577F: malloc (vg_replace_malloc.c:299)
      ==19074==    by 0x1FD83D: fbAllocatePrivates (fballpriv.c:79)
      ==19074==    by 0x20A666: fbSetupScreen (fbscreen.c:110)
      ==19074==    by 0x20A666: fbScreenInit (fbscreen.c:300)
      ==19074==    by 0x1DEA4C: nxagentOpenScreen (Screen.c:1356)
      ==19074==    by 0x16D7F8: AddScreen (dispatch.c:4257)
      ==19074==    by 0x1DA0CF: InitOutput (Init.c:397)
      ==19074==    by 0x14DCC2: main (main.c:280)
      0f8dbbab
    • Ulrich Sibiller's avatar
      xkb: initialize tsyms · 308824ba
      Ulrich Sibiller authored
      Backport of this commit:
      
        commit b2167015043a458e9cf93b827b43eb5b7c552ce9
        Author: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
        Date:   Sat Nov 4 23:06:27 2017 +0100
      
          xkb: initialize tsyms
      
          This fixes some “Conditional jump depends on uninitialized value(s)”
          errors spotted by valgrind.
      Reviewed-by: 's avatarEric Engestrom <eric.engestrom@imgtec.com>
      Signed-off-by: 's avatarGiuseppe Bilotta <giuseppe.bilotta@gmail.com>
      308824ba
    • Ulrich Sibiller's avatar
      Rootless.c: improve TEST/WARN/DEBUG outout · 6d00a387
      Ulrich Sibiller authored
      by adding [] around values as almost everywhere
      6d00a387
    • Ulrich Sibiller's avatar
      Pixmap.c: fix comment phrasing/spelling · 2b25eb3d
      Ulrich Sibiller authored
      2b25eb3d
    • Ulrich Sibiller's avatar
      Window.c: add missing comment about nxagentConfiguredWindowList · 1bfafc12
      Ulrich Sibiller authored
      was in inital version of 6ce9fb5f but got lost
      during some rebasing/cherry-picking preceeding the pull request.
      1bfafc12