sanitycheck.cgi 34.1 KB
Newer Older
1
#!/usr/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Matthew Tuck <matty@chariot.net.au>
23
#                 Max Kanat-Alexander <mkanat@bugzilla.org>
24
#                 Marc Schumann <wurblzap@gmail.com>
25
#                 Frédéric Buclin <LpSolit@gmail.com>
26

27
use strict;
28

29
use lib qw(. lib);
30

31
use Bugzilla;
32
use Bugzilla::Bug;
33
use Bugzilla::Constants;
34
use Bugzilla::Error;
35 36
use Bugzilla::Hook;
use Bugzilla::Util;
37
use Bugzilla::Status;
38

39 40 41
###########################################################################
# General subs
###########################################################################
42

43 44 45 46
sub get_string {
    my ($san_tag, $vars) = @_;
    $vars->{'san_tag'} = $san_tag;
    return get_text('sanitycheck', $vars);
47 48
}

49 50
sub Status {
    my ($san_tag, $vars, $alert) = @_;
51 52 53 54 55 56 57 58 59 60 61 62 63
    my $cgi = Bugzilla->cgi;
    return if (!$alert && Bugzilla->usage_mode == USAGE_MODE_CMDLINE && !$cgi->param('verbose'));

    if (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
        my $output = $cgi->param('output') || '';
        my $linebreak = $alert ? "\nALERT: " : "\n";
        $cgi->param('error_found', 1) if $alert;
        $cgi->param('output', $output . $linebreak . get_string($san_tag, $vars));
    }
    else {
        my $start_tag = $alert ? '<p class="alert">' : '<p>';
        print $start_tag . get_string($san_tag, $vars) . "</p>\n";
    }
64 65
}

66 67 68
###########################################################################
# Start
###########################################################################
69

70
my $user = Bugzilla->login(LOGIN_REQUIRED);
71

72
my $cgi = Bugzilla->cgi;
73
my $dbh = Bugzilla->dbh;
74 75 76 77 78 79 80 81 82
# If the result of the sanity check is sent per email, then we have to
# take the user prefs into account rather than querying the web browser.
my $template;
if (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
    $template = Bugzilla->template_inner($user->settings->{'lang'}->{'value'});
}
else {
    $template = Bugzilla->template;
}
83 84
my $vars = {};

85
print $cgi->header() unless Bugzilla->usage_mode == USAGE_MODE_CMDLINE;
86

87 88 89
# Make sure the user is authorized to access sanitycheck.cgi.
# As this script can now alter the group_control_map table, we no longer
# let users with editbugs privs run it anymore.
90
$user->in_group("editcomponents")
91
  || ThrowUserError("auth_failure", {group  => "editcomponents",
92 93
                                     action => "run",
                                     object => "sanity_check"});
94

95 96 97 98
unless (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
    $template->process('admin/sanitycheck/list.html.tmpl', $vars)
      || ThrowTemplateError($template->error());
}
99

100 101 102 103
###########################################################################
# Create missing group_control_map entries
###########################################################################

104 105
if ($cgi->param('createmissinggroupcontrolmapentries')) {
    Status('group_control_map_entries_creation');
106 107 108 109

    my $na    = CONTROLMAPNA;
    my $shown = CONTROLMAPSHOWN;
    my $insertsth = $dbh->prepare(
110 111 112 113
        qq{INSERT INTO group_control_map
                       (group_id, product_id, membercontrol, othercontrol)
                VALUES (?, ?, $shown, $na)});

114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138
    my $updatesth = $dbh->prepare(qq{UPDATE group_control_map
                                        SET membercontrol = $shown
                                      WHERE group_id   = ?
                                        AND product_id = ?});
    my $counter = 0;

    # Find all group/product combinations used for bugs but not set up
    # correctly in group_control_map
    my $invalid_combinations = $dbh->selectall_arrayref(
        qq{    SELECT bugs.product_id,
                      bgm.group_id,
                      gcm.membercontrol,
                      groups.name,
                      products.name
                 FROM bugs
           INNER JOIN bug_group_map AS bgm
                   ON bugs.bug_id = bgm.bug_id
           INNER JOIN groups
                   ON bgm.group_id = groups.id
           INNER JOIN products
                   ON bugs.product_id = products.id
            LEFT JOIN group_control_map AS gcm
                   ON bugs.product_id = gcm.product_id
                  AND    bgm.group_id = gcm.group_id
                WHERE COALESCE(gcm.membercontrol, $na) = $na
139 140
          } . $dbh->sql_group_by('bugs.product_id, bgm.group_id',
                                 'gcm.membercontrol, groups.name, products.name'));
141 142 143 144 145 146 147

    foreach (@$invalid_combinations) {
        my ($product_id, $group_id, $currentmembercontrol,
            $group_name, $product_name) = @$_;

        $counter++;
        if (defined($currentmembercontrol)) {
148 149
            Status('group_control_map_entries_update',
                   {group_name => $group_name, product_name => $product_name});
150 151 152
            $updatesth->execute($group_id, $product_id);
        }
        else {
153 154
            Status('group_control_map_entries_generation',
                   {group_name => $group_name, product_name => $product_name});
155 156 157 158
            $insertsth->execute($group_id, $product_id);
        }
    }

159
    Status('group_control_map_entries_repaired', {counter => $counter});
160 161
}

162 163 164 165
###########################################################################
# Fix missing creation date
###########################################################################

166 167
if ($cgi->param('repair_creation_date')) {
    Status('bug_creation_date_start');
168 169 170 171 172 173 174 175

    my $bug_ids = $dbh->selectcol_arrayref('SELECT bug_id FROM bugs
                                            WHERE creation_ts IS NULL');

    my $sth_UpdateDate = $dbh->prepare('UPDATE bugs SET creation_ts = ?
                                        WHERE bug_id = ?');

    # All bugs have an entry in the 'longdescs' table when they are created,
176
    # even if no comment is required.
177 178 179 180 181 182 183 184
    my $sth_getDate = $dbh->prepare('SELECT MIN(bug_when) FROM longdescs
                                     WHERE bug_id = ?');

    foreach my $bugid (@$bug_ids) {
        $sth_getDate->execute($bugid);
        my $date = $sth_getDate->fetchrow_array;
        $sth_UpdateDate->execute($date, $bugid);
    }
185
    Status('bug_creation_date_fixed', {bug_count => scalar(@$bug_ids)});
186 187
}

188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203
###########################################################################
# Fix everconfirmed
###########################################################################

if ($cgi->param('repair_everconfirmed')) {
    Status('everconfirmed_start');

    my @confirmed_open_states = grep {$_ ne 'UNCONFIRMED'} BUG_STATE_OPEN;
    my $confirmed_open_states = join(', ', map {$dbh->quote($_)} @confirmed_open_states);

    $dbh->do("UPDATE bugs SET everconfirmed = 0 WHERE bug_status = 'UNCONFIRMED'");
    $dbh->do("UPDATE bugs SET everconfirmed = 1 WHERE bug_status IN ($confirmed_open_states)");

    Status('everconfirmed_end');
}

204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223
###########################################################################
# Fix entries in Bugs full_text
###########################################################################

if ($cgi->param('repair_bugs_fulltext')) {
    Status('bugs_fulltext_start');

    my $bug_ids = $dbh->selectcol_arrayref('SELECT bugs.bug_id
                                            FROM bugs
                                            LEFT JOIN bugs_fulltext
                                            ON bugs_fulltext.bug_id = bugs.bug_id
                                            WHERE bugs_fulltext.bug_id IS NULL');

   foreach my $bugid (@$bug_ids) {
       Bugzilla::Bug->new($bugid)->_sync_fulltext('new_bug');
   }

   Status('bugs_fulltext_fixed', {bug_count => scalar(@$bug_ids)});
}

224 225 226 227
###########################################################################
# Send unsent mail
###########################################################################

228
if ($cgi->param('rescanallBugMail')) {
229 230
    require Bugzilla::BugMail;

231
    Status('send_bugmail_start');
232
    my $time = $dbh->sql_interval(30, 'MINUTE');
233

234 235 236 237 238 239 240
    my $list = $dbh->selectcol_arrayref(qq{
                                        SELECT bug_id
                                          FROM bugs 
                                         WHERE (lastdiffed IS NULL
                                                OR lastdiffed < delta_ts)
                                           AND delta_ts < now() - $time
                                      ORDER BY bug_id});
241

242 243
    Status('send_bugmail_status', {bug_count => scalar(@$list)});

244 245 246 247 248 249 250
    # We cannot simply look at the bugs_activity table to find who did the
    # last change in a given bug, as e.g. adding a comment doesn't add any
    # entry to this table. And some other changes may be private
    # (such as time-related changes or private attachments or comments)
    # and so choosing this user as being the last one having done a change
    # for the bug may be problematic. So the best we can do at this point
    # is to choose the currently logged in user for email notification.
251
    $vars->{'changer'} = Bugzilla->user;
252

253
    foreach my $bugid (@$list) {
254
        Bugzilla::BugMail::Send($bugid, $vars);
255 256
    }

257
    Status('send_bugmail_end') if scalar(@$list);
258

259 260 261 262
    unless (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
        $template->process('global/footer.html.tmpl', $vars)
          || ThrowTemplateError($template->error());
    }
263 264 265
    exit;
}

266 267 268 269
###########################################################################
# Remove all references to deleted bugs
###########################################################################

270 271
if ($cgi->param('remove_invalid_bug_references')) {
    Status('bug_reference_deletion_start');
272

273
    $dbh->bz_start_transaction();
274

275 276
    foreach my $pair ('attachments/', 'bug_group_map/', 'bugs_activity/',
                      'bugs_fulltext/', 'cc/',
277 278
                      'dependencies/blocked', 'dependencies/dependson',
                      'duplicates/dupe', 'duplicates/dupe_of',
279
                      'flags/', 'keywords/', 'longdescs/') {
280 281 282 283 284 285 286 287 288 289 290 291 292 293

        my ($table, $field) = split('/', $pair);
        $field ||= "bug_id";

        my $bug_ids =
          $dbh->selectcol_arrayref("SELECT $table.$field FROM $table
                                    LEFT JOIN bugs ON $table.$field = bugs.bug_id
                                    WHERE bugs.bug_id IS NULL");

        if (scalar(@$bug_ids)) {
            $dbh->do("DELETE FROM $table WHERE $field IN (" . join(',', @$bug_ids) . ")");
        }
    }

294
    $dbh->bz_commit_transaction();
295
    Status('bug_reference_deletion_end');
296 297
}

298 299 300 301
###########################################################################
# Remove all references to deleted attachments
###########################################################################

302 303
if ($cgi->param('remove_invalid_attach_references')) {
    Status('attachment_reference_deletion_start');
304

305
    $dbh->bz_start_transaction();
306 307 308 309 310 311 312 313 314 315 316 317 318

    my $attach_ids =
        $dbh->selectcol_arrayref('SELECT attach_data.id
                                    FROM attach_data
                               LEFT JOIN attachments
                                      ON attachments.attach_id = attach_data.id
                                   WHERE attachments.attach_id IS NULL');

    if (scalar(@$attach_ids)) {
        $dbh->do('DELETE FROM attach_data WHERE id IN (' .
                 join(',', @$attach_ids) . ')');
    }

319
    $dbh->bz_commit_transaction();
320
    Status('attachment_reference_deletion_end');
321
}
322

323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352
###########################################################################
# Remove all references to deleted users or groups from whines
###########################################################################

if ($cgi->param('remove_old_whine_targets')) {
    Status('whines_obsolete_target_deletion_start');

    $dbh->bz_start_transaction();

    foreach my $target (['groups', 'id', MAILTO_GROUP],
                        ['profiles', 'userid', MAILTO_USER])
    {
        my ($table, $col, $type) = @$target;
        my $old_ids =
          $dbh->selectcol_arrayref("SELECT DISTINCT mailto
                                      FROM whine_schedules
                                 LEFT JOIN $table
                                        ON $table.$col = whine_schedules.mailto
                                     WHERE mailto_type = $type AND $table.$col IS NULL");

        if (scalar(@$old_ids)) {
            $dbh->do("DELETE FROM whine_schedules
                       WHERE mailto_type = $type AND mailto IN (" .
                       join(',', @$old_ids) . ")");
        }
    }
    $dbh->bz_commit_transaction();
    Status('whines_obsolete_target_deletion_end');
}

353 354 355 356
###########################################################################
# Repair hook
###########################################################################

357
Bugzilla::Hook::process('sanitycheck_repair', { status => \&Status });
358 359 360 361

###########################################################################
# Checks
###########################################################################
362
Status('checks_start');
363

364 365 366 367
###########################################################################
# Perform referential (cross) checks
###########################################################################

368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383
# This checks that a simple foreign key has a valid primary key value.  NULL
# references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name.
#   the second value is the foreign key field name.
#   the third value is optional and represents a field on the foreign key
#     table to display when the check fails.
#   the fourth value is optional and is a list reference to values that
#     are excluded from checking.
#
# FIXME: The excluded values parameter should go away - the QA contact
#        fields should use NULL instead - see bug #109474.
384
#        The same goes for series; no bug for that yet.
385

386 387 388
sub CrossCheck {
    my $table = shift @_;
    my $field = shift @_;
389
    my $dbh = Bugzilla->dbh;
390

391
    Status('cross_check_to', {table => $table, field => $field});
392 393 394 395 396 397 398 399

    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield, $keyname, $exceptions) = @$ref;

        $exceptions ||= [];
        my %exceptions = map { $_ => 1 } @$exceptions;

400 401
        Status('cross_check_from', {table => $refertable, field => $referfield});

402 403 404 405 406 407 408
        my $query = qq{SELECT DISTINCT $refertable.$referfield} .
            ($keyname ? qq{, $refertable.$keyname } : q{}) .
                     qq{ FROM $refertable
                    LEFT JOIN $table
                           ON $refertable.$referfield = $table.$field
                        WHERE $table.$field IS NULL
                          AND $refertable.$referfield IS NOT NULL};
409

410 411
        my $sth = $dbh->prepare($query);
        $sth->execute;
412

413
        my $has_bad_references = 0;
414 415 416

        while (my ($value, $key) = $sth->fetchrow_array) {
            next if $exceptions{$value};
417 418 419
            Status('cross_check_alert', {value => $value, table => $refertable,
                                         field => $referfield, keyname => $keyname,
                                         key => $key}, 'alert');
420
            $has_bad_references = 1;
421
        }
422 423
        # References to non existent bugs can be safely removed, bug 288461
        if ($table eq 'bugs' && $has_bad_references) {
424
            Status('cross_check_bug_has_references');
425 426 427
        }
        # References to non existent attachments can be safely removed.
        if ($table eq 'attachments' && $has_bad_references) {
428
            Status('cross_check_attachment_has_references');
429
        }
430 431 432
    }
}

433 434 435
CrossCheck('classifications', 'id',
           ['products', 'classification_id']);

436 437 438
CrossCheck("keyworddefs", "id",
           ["keywords", "keywordid"]);

439
CrossCheck("fielddefs", "id",
440 441
           ["bugs_activity", "fieldid"],
           ['profiles_activity', 'fieldid']);
442

443
CrossCheck("flagtypes", "id",
444 445 446
           ["flags", "type_id"],
           ["flagexclusions", "type_id"],
           ["flaginclusions", "type_id"]);
447 448 449

CrossCheck("bugs", "bug_id",
           ["bugs_activity", "bug_id"],
450
           ["bug_group_map", "bug_id"],
451
           ["bugs_fulltext", "bug_id"],
452 453 454 455 456
           ["attachments", "bug_id"],
           ["cc", "bug_id"],
           ["longdescs", "bug_id"],
           ["dependencies", "blocked"],
           ["dependencies", "dependson"],
457
           ['flags', 'bug_id'],
458 459 460
           ["keywords", "bug_id"],
           ["duplicates", "dupe_of", "dupe"],
           ["duplicates", "dupe", "dupe_of"]);
461

462 463
CrossCheck("groups", "id",
           ["bug_group_map", "group_id"],
464
           ['category_group_map', 'group_id'],
465 466
           ["group_group_map", "grantor_id"],
           ["group_group_map", "member_id"],
467
           ["group_control_map", "group_id"],
468
           ["namedquery_group_map", "group_id"],
469 470 471
           ["user_group_map", "group_id"],
           ["flagtypes", "grant_group_id"],
           ["flagtypes", "request_group_id"]);
472

473 474 475 476 477
CrossCheck("namedqueries", "id",
           ["namedqueries_link_in_footer", "namedquery_id"],
           ["namedquery_group_map", "namedquery_id"],
          );

478
CrossCheck("profiles", "userid",
479 480
           ['profiles_activity', 'userid'],
           ['profiles_activity', 'who'],
481 482
           ['email_setting', 'user_id'],
           ['profile_setting', 'user_id'],
483 484
           ["bugs", "reporter", "bug_id"],
           ["bugs", "assigned_to", "bug_id"],
485
           ["bugs", "qa_contact", "bug_id"],
486
           ["attachments", "submitter_id", "bug_id"],
487 488
           ['flags', 'setter_id', 'bug_id'],
           ['flags', 'requestee_id', 'bug_id'],
489 490
           ["bugs_activity", "who", "bug_id"],
           ["cc", "who", "bug_id"],
491
           ['quips', 'userid'],
492
           ["longdescs", "who", "bug_id"],
493
           ["logincookies", "userid"],
494
           ["namedqueries", "userid"],
495
           ["namedqueries_link_in_footer", "user_id"],
496
           ['series', 'creator', 'series_id'],
497 498
           ["watch", "watcher"],
           ["watch", "watched"],
499
           ['whine_events', 'owner_userid'],
500
           ["tokens", "userid"],
501
           ["user_group_map", "user_id"],
502
           ["components", "initialowner", "name"],
503 504
           ["components", "initialqacontact", "name"],
           ["component_cc", "user_id"]);
505

506 507 508 509 510
CrossCheck("products", "id",
           ["bugs", "product_id", "bug_id"],
           ["components", "product_id", "name"],
           ["milestones", "product_id", "value"],
           ["versions", "product_id", "value"],
511
           ["group_control_map", "product_id"],
512 513
           ["flaginclusions", "product_id", "type_id"],
           ["flagexclusions", "product_id", "type_id"]);
514

515
CrossCheck("components", "id",
516 517 518
           ["component_cc", "component_id"],
           ["flagexclusions", "component_id", "type_id"],
           ["flaginclusions", "component_id", "type_id"]);
519

520
# Check the former enum types -mkanat@bugzilla.org
521
CrossCheck("bug_status", "value",
522
            ["bugs", "bug_status", "bug_id"]);
523 524

CrossCheck("resolution", "value",
525
            ["bugs", "resolution", "bug_id"]);
526 527

CrossCheck("bug_severity", "value",
528
            ["bugs", "bug_severity", "bug_id"]);
529 530

CrossCheck("op_sys", "value",
531
            ["bugs", "op_sys", "bug_id"]);
532 533

CrossCheck("priority", "value",
534
            ["bugs", "priority", "bug_id"]);
535 536

CrossCheck("rep_platform", "value",
537
            ["bugs", "rep_platform", "bug_id"]);
538

539 540 541 542
CrossCheck('series', 'series_id',
           ['series_data', 'series_id']);

CrossCheck('series_categories', 'id',
543 544 545
           ['series', 'category'],
           ["category_group_map", "category_id"],
           ["series", "subcategory"]);
546 547 548 549 550

CrossCheck('whine_events', 'id',
           ['whine_queries', 'eventid'],
           ['whine_schedules', 'eventid']);

551
CrossCheck('attachments', 'attach_id',
552 553
           ['attach_data', 'id'],
           ['bugs_activity', 'attach_id']);
554

555 556 557 558
CrossCheck('bug_status', 'id',
           ['status_workflow', 'old_status'],
           ['status_workflow', 'new_status']);

559
###########################################################################
560
# Perform double field referential (cross) checks
561
###########################################################################
562
 
563 564 565 566 567 568 569 570 571 572 573 574 575 576
# This checks that a compound two-field foreign key has a valid primary key
# value.  NULL references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key first field name.
# The third parameter is the primary key second field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name
#   the second value is the foreign key first field name.
#   the third value is the foreign key second field name.
#   the fourth value is optional and represents a field on the foreign key
#     table to display when the check fails

577 578 579 580
sub DoubleCrossCheck {
    my $table = shift @_;
    my $field1 = shift @_;
    my $field2 = shift @_;
581
    my $dbh = Bugzilla->dbh;
582 583 584 585

    Status('double_cross_check_to',
           {table => $table, field1 => $field1, field2 => $field2});

586 587 588
    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield1, $referfield2, $keyname) = @$ref;
589 590 591

        Status('double_cross_check_from',
               {table => $refertable, field1 => $referfield1, field2 =>$referfield2});
592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607

        my $d_cross_check = $dbh->selectall_arrayref(qq{
                        SELECT DISTINCT $refertable.$referfield1, 
                                        $refertable.$referfield2 } .
                       ($keyname ? qq{, $refertable.$keyname } : q{}) .
                      qq{ FROM $refertable
                     LEFT JOIN $table
                            ON $refertable.$referfield1 = $table.$field1
                           AND $refertable.$referfield2 = $table.$field2 
                         WHERE $table.$field1 IS NULL 
                           AND $table.$field2 IS NULL 
                           AND $refertable.$referfield1 IS NOT NULL 
                           AND $refertable.$referfield2 IS NOT NULL});

        foreach my $check (@$d_cross_check) {
            my ($value1, $value2, $key) = @$check;
608 609 610 611 612
            Status('double_cross_check_alert',
                   {value1 => $value1, value2 => $value2,
                    table => $refertable,
                    field1 => $referfield1, field2 => $referfield2,
                    keyname => $keyname, key => $key}, 'alert');
613
        }
614 615 616
    }
}

617 618 619 620
DoubleCrossCheck('attachments', 'bug_id', 'attach_id',
                 ['flags', 'bug_id', 'attach_id'],
                 ['bugs_activity', 'bug_id', 'attach_id']);

621
DoubleCrossCheck("components", "product_id", "id",
622 623 624
                 ["bugs", "product_id", "component_id", "bug_id"],
                 ['flagexclusions', 'product_id', 'component_id'],
                 ['flaginclusions', 'product_id', 'component_id']);
625

626 627 628 629 630 631
DoubleCrossCheck("versions", "product_id", "value",
                 ["bugs", "product_id", "version", "bug_id"]);
 
DoubleCrossCheck("milestones", "product_id", "value",
                 ["bugs", "product_id", "target_milestone", "bug_id"],
                 ["products", "id", "defaultmilestone", "name"]);
632

633 634 635
###########################################################################
# Perform login checks
###########################################################################
636 637

Status('profile_login_start');
638

639 640
my $sth = $dbh->prepare(q{SELECT userid, login_name FROM profiles});
$sth->execute;
641

642
while (my ($id, $email) = $sth->fetchrow_array) {
643
    validate_email_syntax($email)
644
      || Status('profile_login_alert', {id => $id, email => $email}, 'alert');
645
}
646

647
###########################################################################
648
# Perform keyword checks
649
###########################################################################
650

651
sub check_keywords {
652
    my $dbh = Bugzilla->dbh;
653
    my $cgi = Bugzilla->cgi;
654

655
    Status('keyword_check_start');
656

657 658 659
    my %keywordids;
    my $keywords = $dbh->selectall_arrayref(q{SELECT id, name
                                                FROM keyworddefs});
660

661 662 663
    foreach (@$keywords) {
        my ($id, $name) = @$_;
        if ($keywordids{$id}) {
664
            Status('keyword_check_alert', {id => $id}, 'alert');
665 666 667
        }
        $keywordids{$id} = 1;
        if ($name =~ /[\s,]/) {
668
            Status('keyword_check_invalid_name', {id => $id}, 'alert');
669 670
        }
    }
671

672 673 674 675 676 677 678 679
    my $sth = $dbh->prepare(q{SELECT bug_id, keywordid
                                FROM keywords
                            ORDER BY bug_id, keywordid});
    $sth->execute;
    my $lastid;
    my $lastk;
    while (my ($id, $k) = $sth->fetchrow_array) {
        if (!$keywordids{$k}) {
680
            Status('keyword_check_invalid_id', {id => $k}, 'alert');
681
        }
682
        if (defined $lastid && $id eq $lastid && $k eq $lastk) {
683
            Status('keyword_check_duplicated_ids', {id => $id}, 'alert');
684
        }
685 686
        $lastid = $id;
        $lastk = $k;
687
    }
688
}
689

690 691 692 693
###########################################################################
# Check for flags being in incorrect products and components
###########################################################################

694
Status('flag_check_start');
695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722

my $invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
     LEFT JOIN flaginclusions AS i
            ON flags.type_id = i.type_id
           AND (bugs.product_id = i.product_id OR i.product_id IS NULL)
           AND (bugs.component_id = i.component_id OR i.component_id IS NULL)
         WHERE i.type_id IS NULL');

my @invalid_flags = @$invalid_flags;

$invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
    INNER JOIN flagexclusions AS e
            ON flags.type_id = e.type_id
         WHERE (bugs.product_id = e.product_id OR e.product_id IS NULL)
           AND (bugs.component_id = e.component_id OR e.component_id IS NULL)');

push(@invalid_flags, @$invalid_flags);

if (scalar(@invalid_flags)) {
    if ($cgi->param('remove_invalid_flags')) {
723
        Status('flag_deletion_start');
724 725 726
        my @flag_ids = map {$_->[0]} @invalid_flags;
        # Silently delete these flags, with no notification to requesters/setters.
        $dbh->do('DELETE FROM flags WHERE id IN (' . join(',', @flag_ids) .')');
727
        Status('flag_deletion_end');
728 729 730 731
    }
    else {
        foreach my $flag (@$invalid_flags) {
            my ($flag_id, $bug_id, $attach_id) = @$flag;
732 733 734
            Status('flag_alert',
                   {flag_id => $flag_id, attach_id => $attach_id, bug_id => $bug_id},
                   'alert');
735
        }
736
        Status('flag_fix');
737 738 739
    }
}

740
###########################################################################
741
# General bug checks
742 743
###########################################################################

744
sub BugCheck {
745
    my ($middlesql, $errortext, $repairparam, $repairtext) = @_;
746
    my $dbh = Bugzilla->dbh;
747 748 749 750
 
    my $badbugs = $dbh->selectcol_arrayref(qq{SELECT DISTINCT bugs.bug_id
                                                FROM $middlesql 
                                            ORDER BY bugs.bug_id});
751

752
    if (scalar(@$badbugs)) {
753 754 755 756
        Status('bug_check_alert',
               {errortext => get_string($errortext), badbugs => $badbugs},
               'alert');

757
        if ($repairparam) {
758 759 760
            $repairtext ||= 'repair_bugs';
            Status('bug_check_repair',
                   {param => $repairparam, text => get_string($repairtext)});
761
        }
762
    }
763 764
}

765
Status('bug_check_creation_date');
766

767 768
BugCheck("bugs WHERE creation_ts IS NULL", 'bug_check_creation_date_error_text',
         'repair_creation_date', 'bug_check_creation_date_repair_text');
769

770 771 772 773 774 775
Status('bug_check_bugs_fulltext');

BugCheck("bugs LEFT JOIN bugs_fulltext ON bugs_fulltext.bug_id = bugs.bug_id " .
         "WHERE bugs_fulltext.bug_id IS NULL", 'bug_check_bugs_fulltext_error_text',
         'repair_bugs_fulltext', 'bug_check_bugs_fulltext_repair_text');

776
Status('bug_check_res_dupl');
777

778
BugCheck("bugs INNER JOIN duplicates ON bugs.bug_id = duplicates.dupe " .
779
         "WHERE bugs.resolution != 'DUPLICATE'", 'bug_check_res_dupl_error_text');
780

781 782
BugCheck("bugs LEFT JOIN duplicates ON bugs.bug_id = duplicates.dupe WHERE " .
         "bugs.resolution = 'DUPLICATE' AND " .
783
         "duplicates.dupe IS NULL", 'bug_check_res_dupl_error_text2');
784

785
Status('bug_check_status_res');
786

787
my @open_states = map($dbh->quote($_), BUG_STATE_OPEN);
788 789
my $open_states = join(', ', @open_states);

790
BugCheck("bugs WHERE bug_status IN ($open_states) AND resolution != ''",
791
         'bug_check_status_res_error_text');
792
BugCheck("bugs WHERE bug_status NOT IN ($open_states) AND resolution = ''",
793
         'bug_check_status_res_error_text2');
794

795
Status('bug_check_status_everconfirmed');
796

797
BugCheck("bugs WHERE bug_status = 'UNCONFIRMED' AND everconfirmed = 1",
798
         'bug_check_status_everconfirmed_error_text', 'repair_everconfirmed');
799 800 801 802 803

my @confirmed_open_states = grep {$_ ne 'UNCONFIRMED'} BUG_STATE_OPEN;
my $confirmed_open_states = join(', ', map {$dbh->quote($_)} @confirmed_open_states);

BugCheck("bugs WHERE bug_status IN ($confirmed_open_states) AND everconfirmed = 0",
804
         'bug_check_status_everconfirmed_error_text2', 'repair_everconfirmed');
805

806 807 808 809 810 811
###########################################################################
# Control Values
###########################################################################

# Checks for values that are invalid OR
# not among the 9 valid combinations
812
Status('bug_check_control_values');
813 814
my $groups = join(", ", (CONTROLMAPNA, CONTROLMAPSHOWN, CONTROLMAPDEFAULT,
CONTROLMAPMANDATORY));
815
my $query = qq{
816 817 818 819 820 821 822 823
     SELECT COUNT(product_id) 
       FROM group_control_map 
      WHERE membercontrol NOT IN( $groups )
         OR othercontrol NOT IN( $groups )
         OR ((membercontrol != othercontrol)
             AND (membercontrol != } . CONTROLMAPSHOWN . q{)
             AND ((membercontrol != } . CONTROLMAPDEFAULT . q{)
                  OR (othercontrol = } . CONTROLMAPSHOWN . q{)))};
824

825 826 827 828
my $entries = $dbh->selectrow_array($query);
Status('bug_check_control_values_alert', {entries => $entries}, 'alert') if $entries;

Status('bug_check_control_values_violation');
829
BugCheck("bugs
830 831 832 833
         INNER JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
          LEFT JOIN group_control_map
            ON bugs.product_id = group_control_map.product_id
834
           AND bug_group_map.group_id = group_control_map.group_id
835
         WHERE ((group_control_map.membercontrol = " . CONTROLMAPNA . ")
836
         OR (group_control_map.membercontrol IS NULL))",
837
         'bug_check_control_values_error_text',
838
         'createmissinggroupcontrolmapentries',
839
         'bug_check_control_values_repair_text');
840

841
BugCheck("bugs
842
         INNER JOIN group_control_map
843
            ON bugs.product_id = group_control_map.product_id
844 845 846 847 848
         INNER JOIN groups
            ON group_control_map.group_id = groups.id
          LEFT JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
           AND group_control_map.group_id = bug_group_map.group_id
849
         WHERE group_control_map.membercontrol = " . CONTROLMAPMANDATORY . "
850 851
           AND bug_group_map.group_id IS NULL
           AND groups.isactive != 0",
852
         'bug_check_control_values_error_text2');
853

854 855 856 857
###########################################################################
# Unsent mail
###########################################################################

858
Status('unsent_bugmail_check');
859

860 861 862 863 864 865 866
my $time = $dbh->sql_interval(30, 'MINUTE');
my $badbugs = $dbh->selectcol_arrayref(qq{
                    SELECT bug_id 
                      FROM bugs 
                     WHERE (lastdiffed IS NULL OR lastdiffed < delta_ts)
                       AND delta_ts < now() - $time
                  ORDER BY bug_id});
867 868


869
if (scalar(@$badbugs > 0)) {
870 871
    Status('unsent_bugmail_alert', {badbugs => $badbugs}, 'alert');
    Status('unsent_bugmail_fix');
872 873
}

874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897
###########################################################################
# Whines
###########################################################################

Status('whines_obsolete_target_start');

my $display_repair_whines_link = 0;
foreach my $target (['groups', 'id', MAILTO_GROUP],
                    ['profiles', 'userid', MAILTO_USER])
{
    my ($table, $col, $type) = @$target;
    my $old = $dbh->selectall_arrayref("SELECT whine_schedules.id, mailto
                                          FROM whine_schedules
                                     LEFT JOIN $table
                                            ON $table.$col = whine_schedules.mailto
                                         WHERE mailto_type = $type AND $table.$col IS NULL");

    if (scalar(@$old)) {
        Status('whines_obsolete_target_alert', {schedules => $old, type => $type}, 'alert');
        $display_repair_whines_link = 1;
    }
}
Status('whines_obsolete_target_fix') if $display_repair_whines_link;

898 899 900 901
###########################################################################
# Check hook
###########################################################################

902
Bugzilla::Hook::process('sanitycheck_check', { status => \&Status });
903

904 905 906
###########################################################################
# End
###########################################################################
907

908 909
Status('checks_completed');

910 911 912 913
unless (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
    $template->process('global/footer.html.tmpl', $vars)
      || ThrowTemplateError($template->error());
}