- 01 Nov, 2009 3 commits
-
-
Max Kellermann authored
The old code tried to recover, but what's the point of that? If a directory is duplicate, something is wrong with the database file.
-
Max Kellermann authored
-
Max Kellermann authored
It's legal to pass decoder=NULL to decoder_read(). Add a check.
-
- 31 Oct, 2009 7 commits
-
-
Max Kellermann authored
Allocate a decoder_control object where needed, and pass it around. This will allow more than one decoder thread one day.
-
Max Kellermann authored
Conflicts: NEWS configure.ac src/decoder/ffmpeg_plugin.c src/update.c
-
Max Kellermann authored
-
Max Kellermann authored
Simply use "return" instead of g_thread_exit().
-
Max Kellermann authored
When the songs of two albums are in the same directory, all songs of an album should be right next to each others.
-
Max Kellermann authored
Moved some code to tag_get_value_checked(), to eliminate several NULL checks.
-
Max Kellermann authored
Use GMutex/GCond instead of the notify library. Manually lock the player_control object before accessing the protected attributes. Use the GCond object to notify the player thread and the main thread.
-
- 30 Oct, 2009 1 commit
-
-
Max Kellermann authored
Right after seeking and song change, the elapsed_time shows old information, because the output thread didn't finish a full chunk yet. This patch re-adds a second elapsed_time variable, and keeps track of a fallback value, in case the output thread can't provide a reliable value.
-
- 29 Oct, 2009 9 commits
-
-
Max Kellermann authored
Return false when there was no chunk in the pipe. If the function returns true, then audio_output_task() will not wait for a notify from the player thread. This fixes a race condition.
-
Max Kellermann authored
Don't set the error in play_chunk(); do all the error handling in the caller. The errored_song attribute isn't set anymore; it doesn't make sense for PLAYER_ERROR_AUDIO.
-
Max Kellermann authored
Call a version of audio_output_close() which doesn't lock recursively.
-
Viliam Mateicka authored
-
Max Kellermann authored
Always keep the audio_output object locked within the output thread, unless a plugin method is called. This fixes several race conditions.
-
Max Kellermann authored
drain() is the opposite of cancel(): it waits until all data in the buffer has finished playing. Instead of implicitly draining in the close() method like the ALSA plugin has been doing it forever, let the output thread decide whether to drain or to cancel.
-
Max Kellermann authored
The recovery is for nothing if we get CLOSE afterwards. Let's not recover in the cancel() method, and let the next play() call sort it out.
-
Max Kellermann authored
Don't call filter_close() right after ao_close().
-
Max Kellermann authored
This variable was uninitialized and led to crashes.
-
- 28 Oct, 2009 2 commits
-
-
Max Kellermann authored
libavformat gives us the song artist in the "author" field. Since we use av_metadata_conv(), we don't need to check for "artist".
-
Max Kellermann authored
Convert the metadata with the libavformat function av_metadata_conv(). This ensures that canonical tag names are provided by libavformat, and we can remove the "artist" vs "author" workaround.
-
- 27 Oct, 2009 2 commits
-
-
Max Kellermann authored
When you disable the "follow_outside_symlinks" or the "follow_inside_symlinks" setting, the next update should remove the now-ignored files from the database.
-
Alam Arias authored
-
- 26 Oct, 2009 2 commits
-
-
Viliam Mateicka authored
-
Viliam Mateicka authored
-
- 24 Oct, 2009 2 commits
-
-
Viliam Mateicka authored
-
Viliam Mateicka authored
-
- 23 Oct, 2009 7 commits
-
-
Max Kellermann authored
Don't connect to JACK before MPD has daemonized.
-
Max Kellermann authored
Don't connect to PulseAudio before MPD has daemonized.
-
Max Kellermann authored
With these methods, an output plugin can allocate some global resources only if it is actually enabled. The method enable() is called after daemonization, which allows for more sophisticated resource allocation during that method.
-
Max Kellermann authored
Don't let the mixer plugin "override" the libpulse callbacks. Instead, add a "mixer" attribute to the pulse_output struct, and call the mixer on all interesting events.
-
Max Kellermann authored
A mixer is useful enough if it can be read. Setting it may be found unavailable at runtime.
-
Max Kellermann authored
If the method get_volume() returns -1 and no error object is set, then the volume is currently unavailable, but the mixer should not be closed immediately.
-
Max Kellermann authored
It's possible to have a mixer implementation which does not explicitly need the methods open() and close().
-
- 22 Oct, 2009 5 commits
-
-
Max Kellermann authored
Moved the check from pulse_mixer_open() to pulse_mixer_update().
-
Max Kellermann authored
-
Max Kellermann authored
Don't clutter the top directory with *.o files.
-
Max Kellermann authored
There's no point in clearing the audio format before exiting.
-
Max Kellermann authored
This way, the function call in the main() function does not need another pair of #ifdef/#endif.
-