There was only one (commented) section using it.

This better reflects its purpose: Tell listeners we are ready.

They belong there...

Make them defines. Also determine the screen depth dynamically.

We either use a solid black or a white background and no backround
pixmap. So nxagentRootTileWindow is always empty and we can drop all
stuff around it.

remove nxagentSplashCount, too, since it is no longer checked anywhere.

nobody was checking it.

The splash window is only shown in x2go mode. In nxagent mode the
splash window was also shown, but empty (and thus invisible). And the
code waited for the splash window to disappear. Fix this by skipping
_all_ the splash stuff in nxagent mode.

Before there was no way of getting a white background despite having
the approriate code.

Backport of this commit:

  commit cb0a565d2b2cf8823abbd77b4426cc2237731dc1
  Author: Daniel Stone <daniel@fooishbar.org>
  Date:   Fri Aug 18 17:04:48 2006 +0300

    dix: add whiteroot flag
    Add a -wr option to use a white root window, and use a BackPixel rather
    than BackPixmap for both white and black root windows.

Fixes ArcticaProject/nx-libs#832

Fixes ArcticaProject/nx-libs#733

Attributes GH PR #828: https://github.com/ArcticaProject/nx-libs/pull/828

no more need to pass down a struct, we now only pass the milliseconds
and let the function do the rest.

Attributes GH PR #823: https://github.com/ArcticaProject/nx-libs/pull/823

The effect of this was that special keystrokes where detected and
passed to the nxagent. E.g. pressing ctrl-alt-f for Fullscreen also
produced an "f" in the current input window inside the nxagent.

Attributes GH PR #822: https://github.com/ArcticaProject/nx-libs/pull/822

With the removal of the Ipaq code there's no path anymore to open the
onscreen keyboard. Also nxkbd is not available and we do not have
tested that feature with any onscreen keyboard yet. So there's no
point in integrating that code.

Fixes ArcticaProject/nx-libs#405

Did we ever provide a binary?

Attributes GH PR #821: https://github.com/ArcticaProject/nx-libs/pull/821

This is a bit weird, I'd expect far more places where the compiler
could complain about Window vs Window64... But it does not.

Screen.c:306:32: warning: passing argument 3 of ‘XQueryTree’ from incompatible pointer type [-Wincompatible-pointer-types]
   if (XQueryTree(d, candidate, &root, &parent, &children, &num_children))
                                ^~~~~
In file included from Screen.c:60:
Agent.h:85:25: note: expected ‘Window64 *’ {aka ‘long unsigned int *’} but argument is of type ‘Window *’ {aka ‘unsigned int *’}
 #define Window          Window64
../../../../exports/include/nx-X11/Xlib.h:3041:5: note: in expansion of macro ‘Window’
     Window*  /* root_return */,

This fixes problems with kwin and compiz when using the
switch-all-screens keystroke. The fullscreen would appear shortly and
then vanish again.

Fixes ArcticaProject/nx-libs#458

Attributes GH PR #820: https://github.com/ArcticaProject/nx-libs/pull/820

Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

Signed-off-by: Mario Trangoni <mjtrangoni@gmail.com>

Attributes GH PR #818: https://github.com/ArcticaProject/nx-libs/pull/818

We can only free the xkbDevicePrivate because we do not know the
details of any other (possible) extension. So let's limit to that one
private for now and call the new xkbFreePrivates from dix (where such
a function is completely missing).

Attributes GH PR #815: https://github.com/ArcticaProject/nx-libs/pull/815

there's more work to do...

The whole nx-X11/extras dir is no longer checked since we only have
Mesa there and we do not want to check that mess...

All the exceptions in static-analysis-suppressions have been manually
checked.

[nx-X11/programs/Xserver/record/set.c:361]: (warning) Possible null pointer dereference: stackIntervals

stackIntervals is only NULL if nIntervals is 0, too. In that case
memcpy will do nothing and so it is ok to pass NULL as source. But it
is ugly nevertheless...