- 19 Oct, 2016 40 commits
-
-
Andreas Wettstein authored
Currently, only non-modifier keys (actually, keysyms) can be part of a compose sequence, and they are matched against the defined compose sequences at the time the key is pressed. The patch allows to use modifier keys an well, but matches them on key release, and only if no other key has been pressed after the modifier. Releasing a non-matched modifier during an ongoing compose sequence only aborts the sequence if any modifier release would have matched. In particular, if no compose sequences with modifiers are specified, the compose mechanism works exactly as without this patch. Even if modifiers are part of a compose sequence, they are not filtered. This is because modifiers affect the keyboard state no matter what we do here and, therefore, filtering them only could confuse clients. The purpose is this extension to the compose mechanism is to allow to make better use of keys in convenient reach for touch typing. Signed-off-by:
Andreas Wettstein <wettstein509@solnet.ch> Signed-off-by:
James Cloos <cloos@jhcloos.com> Backported-to-NX-by:
Ulrich Sibiller <uli42@gmx.de>
-
Samuel Thibault authored
Braille patterns should also be usable in Compose. This combines the implementation of braille chords and compose tree: only emit the braille pattern if it can not be found in the compose tree, if any. Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Backported-to-NX-by:
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Backported-to-NX-by:
-
Alan Coopersmith authored
Fixes warning: "Xrm.c", line 1094: warning: storage class after type is obsolescent Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Backported-to-NX-by:
-
Keith Packard authored
Wait for all other threads to release the user-level lock when acquiring it. This ensures that only one thread at a time holds the user-level lock, necessary as it is a nesting lock and a single variable is used to determine when the lock is nesting and when it is contended. Signed-off-by:
Keith Packard <keithp@keithp.com> Reviewed-by:
Jamey Sharp <jamey@minilop.net> Backported-to-NX-by:
-
Marko Myllynen authored
https://bugs.freedesktop.org/show_bug.cgi?id=19687Signed-off-by:
Marko Myllynen <myllynen@redhat.com> Reviewed-by:
Matt Dew <marcoz@osource.org> Signed-off-by:
-
Ryan Pavlik authored
Use pthreads (provided by the pthreads-win32 compatability library which implements them using native Win32 threading) on MinGW Reviewed-by:
Jon TURNEY <jon.turney@dronecode.org.uk> Backported-to-NX-by:
-
Kusanagi Kouichi authored
https://bugs.freedesktop.org/show_bug.cgi?id=9160Signed-off-by:
Kusanagi Kouichi <slash@ac.auone-net.jp> Signed-off-by:
-
Alan Coopersmith authored
Silences parfait warning of a potential memory leak: Memory leak of pointer 'dst' allocated with malloc(length) at line 160 of FSWrap.c in function 'copy_string_list'. 'dst' allocated at line 145 with malloc(length). dst leaks when count <= 0 at line 154. Signed-off-by: -
Alan Coopersmith authored
Signed-off-by:
-
Peter Hutterer authored
Signed-off-by:
-
Choe Hwanjin authored
NEED_SYNC_REPLY flag should be in Xim not in Xic. Because the focused Xic can be changed before sending sync reply. After focused Xic changed, the new Xic doesn't have NEED_SYNC_REPLY flag enabled, so libX11 doesn't send XIM_SYNC_REPLY packet. This patch adds sync reply flag to Xim and removes sync reply from Xic. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=7869Signed-off-by:
Choe Hwanjin <choe.hwanjin@gmail.com> Reviewed-by:
Jeremy Huddleston <jeremyhu@apple.com> Backported-to-NX-by:
-
Jeremy Huddleston authored
XKBGeom.c:191:25: warning: Access to field 'x1' results in a dereference of a null pointer (loaded from variable 'rbounds') _XkbCheckBounds(bounds,rbounds->x1,rbounds->y1); ^~~~~~~ Found-by: clang static analyzer Signed-off-by: -
Jeremy Huddleston authored
XKBGeom.c:118:27: warning: Assigned value is always the same as the existing value for (key=row->keys,pos=k=0;k<row->num_keys;k++,key++) { ~~~^~~~ XKBGeom.c:115:5: warning: Value stored to 'pos' is never read pos= 0; ^ ~ Found-by: clang static analyzer Signed-off-by: -
Alan Coopersmith authored
Was triggered by defined(__sparcv9) so only built on Solaris SPARC 64-bit. Inconsistent with all other platforms, and a bit overcomplicated. Should anyone need to continue using that path, simply build with a #define POSTLOCALELIBDIR "sparcv9" to get the same result. Fixes Solaris bug 7038737: sparcv9 Xlib looking in wrong path for i18n loadable modules Signed-off-by:
Daniel Stone <daniel@fooishbar.org> Backported-to-NX-by:
-
Alan Coopersmith authored
Signed-off-by:
-
Alan Coopersmith authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Reviewed-by:
-
Ander Conselvan de Oliveira authored
pScreenData is replaced when building per visual intensity tables. If malloc failed the old value of pScreenData (stored also in pScreenDefaultData) was being leaked. Also, property_return wasn't free'd in that case. Signed-off-by:
-
Ander Conselvan de Oliveira authored
Due to what looks like a copy & paste error, pScreenData->pBlueTbl would be accessed after being free'd. Signed-off-by:
-
Ander Conselvan de Oliveira authored
If list_count is 0, dst would be allocated and leaked. Signed-off-by:
-
Ander Conselvan de Oliveira authored
Bitmap file data is read looping through the lines in the input file. If there is extra data after the bitmap, these lines will be processed and if this data represents another bitmap it will replace the one read before causing the memory allocated for bits to leak. This changes the code to stop processing the file once a bitmap was read. Signed-off-by:
-
Harshula Jayasuriya authored
Add #define XK_SINHALA so that the Sinhala keysyms can be used by the lk xkb keymap. Signed-off-by:
Harshula Jayasuriya <harshula@gmail.com> Reviewed-by:
-
Erkki Seppälä authored
Cannot reach dead statement "return NULL;" Check for the NULLness of prop->name and prop->value instead of name and value, which was checked earlier anyway. Decided against using strdup due to curious memory allocation functions and the rest of the xkb not using it either. Signed-off-by:
Erkki Seppälä <erkki.seppala@vincit.fi> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com> Backported-to-NX-by:
-
Erkki Seppälä authored
Using uninitialized value "p->modifiers" Small fix by using Xcalloc instead of Xmalloc Signed-off-by:
-
Alan Coopersmith authored
Error: Memory leak (CWE 401) Memory leak of pointer 's' allocated with XCreateRegion() at line 387 of /export/alanc/X.Org/sx86-gcc/lib/libX11/nx-X11/lib/X11/Region.c in function 'XShrinkRegion'. 's' allocated at line 387 with XCreateRegion(). s leaks when s != 0 at line 387. Error: Memory leak (CWE 401) Memory leak of pointer 'tra' allocated with XCreateRegion() at line 1452 of /export/alanc/X.Org/sx86-gcc/lib/libX11/nx-X11/lib/X11/Region.c in function 'XXorRegion'. 'tra' allocated at line 1451 with XCreateRegion(). tra leaks when tra != 0 at line 1451. [ This bug was found by the Parfait 0.3.6 bug checking tool. For more information see http://labs.oracle.com/projects/parfait/ ] Signed-off-by: -
Erkki Seppälä authored
Properly handle the return value of XGetWindowProperty by considering if after the loop as well. Using freed pointer "prop_ret" There were numerous things wrong in how this function interacted with XGetWindowProperty. None of the local variables were initialized and remained that way if the call to XGetWindowProperty returned 1 (not Succeed). That doesn't result in after_ret being initialized in which case if it happens to be 0, the loop was exited. In that case format_ret and nitems_ret were uninitialized and the function might return with success (but with uninitialized pointer in prop_ret) or XcmsFailure. As the buffer enlarging code was called only when XGetWindowProperty failed (returned not Success), after_ret would not have been initialized. It would have been initialized only if the XGetWindowProperty has returned Success earlier, but in that case the code fragment would not have been reached. This patch alters the function to return XcmsFailure if the call to XGetWindowProperty fails. Reviewed-by:
Rami Ylimäki <rami.ylimaki@vincit.fi> Signed-off-by:
-
Ander Conselvan de Oliveira authored
property_return was free'd before and in the case the conditional is true, the call to XcmsGetProperty failed which means that property_return wasn't set so there is no need to free it again. Double free of pointer "property_return" in call to "free" Reviewed-by:
-
Alan Coopersmith authored
We can simplify the fstat failure case now that the GetFileSize macro has been expanded inline. Signed-off-by:
Julien Cristau <jcristau@debian.org> Backported-to-NX-by:
-
Alan Coopersmith authored
Removes XrmI.h header that only contained this single macro Signed-off-by:
-
Erkki Seppälä authored
Possible overrun of 8192 byte fixed size buffer "buffer" by copying "ext->name" without length checking Reviewed-by:
-
Erkki Seppälä authored
The situation is already handled before this code. Cannot reach dead expression "0U" inside statement "if (1U + (target_dir ? strl..." Reviewed-by:
-
Ander Conselvan de Oliveira authored
info_list->watch_data was being reallocated, but the return value of the reallocation was stored only into a local variable. This might cause some funky behavior and crashes. Variable "wd_array" goes out of scope Value "wd_array" is overwritten in "wd_array = (XPointer*)realloc((char*)info_list->watch_data, (((dpy->watcher_count + 1) * 4U == 0U) ? 1U : ((dpy->watcher_count + 1) * 4U)))" Reviewed-by:
-
Ander Conselvan de Oliveira authored
The rest of the code uses goto's to free memory allocated later and prevent memory leaks, but there were several paths were property_return was free'd just before a goto. Reviewed-by:
-
Ander Conselvan de Oliveira authored
property_return was not free'd if the allocation of pRedTbl failed. Reviewed-by:
-
Erkki Seppälä authored
The NEWTABLE macro missed freeing its allocated memory on subsequent memory allocation errors. Added call to Xfree. Variable "table" goes out of scope Reviewed-by:
-
Erkki Seppälä authored
Fixed memory leak by adding Xfree for image Variable "image" goes out of scope Reviewed-by:
-
Erkki Seppälä authored
Using uninitialized value "new" Reviewed-by:
-
Erkki Seppälä authored
Pointer "pBuf" returned from "fgets(buf, 256, stream)" is never used Reviewed-by:
-
Alan Coopersmith authored
Instead of copying the value returned by get_prop_name and then releasing it, directly use the return value of get_prop_name, which allocates memory for the name. If get_prop_name returns NULL, continue on to XFreeFont to release the font before returning the NULL via the normal function return. Reviewed-by:
-
