- 19 Oct, 2016 40 commits
-
-
Ander Conselvan de Oliveira authored
Fixed by zero'ing conv on allocation with Xcalloc. Then close_converter works properly. Using uninitialized value "conv->state" in call to function "close_converter" Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by:
Erkki Seppälä <erkki.seppala@vincit.fi> Signed-off-by:
Ander Conselvan de Oliveira <ander.conselvan-de-oliveira@nokia.com> Signed-off-by:
Ulrich Sibiller <uli42@gmx.de>
-
Samuel Thibault authored
_XimLocalMbLookupString can return a braille keysym even if _Xlcwctomb can't convert to the current MB charset. _XimLocalUtf8LookupString needs to set the braille keysym and status too. Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Backported-to-NX-by:
-
Samuel Thibault authored
Braille chords management needs key release events. We need to explicitly request then, else GTK would not pass them throught XFilterEvent and braille wouldn't work. Signed-off-by:
-
Erkki Seppälä authored
Variable "map" goes out of scope Release modifiermap before returning. Reordered code to call XGetModifierMapping after the first return from the function. Signed-off-by:
Dirk Wallenstein <halsmit@t-online.de> Backported-to-NX-by:
-
Alan Coopersmith authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
name_ptr and detail_ptr weren't free'd in some cases before returning False. Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
While at it, remove unneeded check for NULL before Xfree. Signed-off-by:
-
Jeremy Huddleston authored
Found by clang static analysis Signed-off-by:
Jeremy Huddleston <jeremyhu@apple.com> Backported-to-NX-by:
-
Yann Droneaud authored
As stated in man page (XOpenIM) and Xlib documentation (chapter 13.5.3), XGetIMValues() and XSetImValues() "returns the name of the first argument that could not be obtained." But currently, err = XGetIMValues(im, "invalid", &arg, NULL); returns &arg instead of "invalid". This patch fixes https://bugs.freedesktop.org/show_bug.cgi?id=12897Signed-off-by:
Yann Droneaud <yann@droneaud.fr> Reviewed-by:
-
Yann Droneaud authored
In case of error, XSetICValues() must return the first argument that failed to be set. But in some error paths, it returns False, which is converted to NULL, so the function returns OK in case of error. Signed-off-by:
-
Xue Wei authored
Fixes pasting more than 1024 bytes into xterm, as described in https://bugs.freedesktop.org/show_bug.cgi?id=25209Signed-off-by:
-
Alan Coopersmith authored
Signed-off-by:
-
Andreas Wettstein authored
Currently, only non-modifier keys (actually, keysyms) can be part of a compose sequence, and they are matched against the defined compose sequences at the time the key is pressed. The patch allows to use modifier keys an well, but matches them on key release, and only if no other key has been pressed after the modifier. Releasing a non-matched modifier during an ongoing compose sequence only aborts the sequence if any modifier release would have matched. In particular, if no compose sequences with modifiers are specified, the compose mechanism works exactly as without this patch. Even if modifiers are part of a compose sequence, they are not filtered. This is because modifiers affect the keyboard state no matter what we do here and, therefore, filtering them only could confuse clients. The purpose is this extension to the compose mechanism is to allow to make better use of keys in convenient reach for touch typing. Signed-off-by:
Andreas Wettstein <wettstein509@solnet.ch> Signed-off-by:
James Cloos <cloos@jhcloos.com> Backported-to-NX-by:
-
Samuel Thibault authored
Braille patterns should also be usable in Compose. This combines the implementation of braille chords and compose tree: only emit the braille pattern if it can not be found in the compose tree, if any. Signed-off-by:
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Backported-to-NX-by:
-
Alan Coopersmith authored
Fixes warning: "Xrm.c", line 1094: warning: storage class after type is obsolescent Signed-off-by:
-
Keith Packard authored
Wait for all other threads to release the user-level lock when acquiring it. This ensures that only one thread at a time holds the user-level lock, necessary as it is a nesting lock and a single variable is used to determine when the lock is nesting and when it is contended. Signed-off-by:
Keith Packard <keithp@keithp.com> Reviewed-by:
Jamey Sharp <jamey@minilop.net> Backported-to-NX-by:
-
Marko Myllynen authored
https://bugs.freedesktop.org/show_bug.cgi?id=19687Signed-off-by:
Marko Myllynen <myllynen@redhat.com> Reviewed-by:
Matt Dew <marcoz@osource.org> Signed-off-by:
-
Ryan Pavlik authored
Use pthreads (provided by the pthreads-win32 compatability library which implements them using native Win32 threading) on MinGW Reviewed-by:
Jon TURNEY <jon.turney@dronecode.org.uk> Backported-to-NX-by:
-
Kusanagi Kouichi authored
https://bugs.freedesktop.org/show_bug.cgi?id=9160Signed-off-by:
Kusanagi Kouichi <slash@ac.auone-net.jp> Signed-off-by:
-
Alan Coopersmith authored
Silences parfait warning of a potential memory leak: Memory leak of pointer 'dst' allocated with malloc(length) at line 160 of FSWrap.c in function 'copy_string_list'. 'dst' allocated at line 145 with malloc(length). dst leaks when count <= 0 at line 154. Signed-off-by: -
Alan Coopersmith authored
Signed-off-by:
-
Peter Hutterer authored
Signed-off-by:
-
Choe Hwanjin authored
NEED_SYNC_REPLY flag should be in Xim not in Xic. Because the focused Xic can be changed before sending sync reply. After focused Xic changed, the new Xic doesn't have NEED_SYNC_REPLY flag enabled, so libX11 doesn't send XIM_SYNC_REPLY packet. This patch adds sync reply flag to Xim and removes sync reply from Xic. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=7869Signed-off-by:
Choe Hwanjin <choe.hwanjin@gmail.com> Reviewed-by:
-
Jeremy Huddleston authored
XKBGeom.c:191:25: warning: Access to field 'x1' results in a dereference of a null pointer (loaded from variable 'rbounds') _XkbCheckBounds(bounds,rbounds->x1,rbounds->y1); ^~~~~~~ Found-by: clang static analyzer Signed-off-by: -
Jeremy Huddleston authored
XKBGeom.c:118:27: warning: Assigned value is always the same as the existing value for (key=row->keys,pos=k=0;k<row->num_keys;k++,key++) { ~~~^~~~ XKBGeom.c:115:5: warning: Value stored to 'pos' is never read pos= 0; ^ ~ Found-by: clang static analyzer Signed-off-by: -
Alan Coopersmith authored
Was triggered by defined(__sparcv9) so only built on Solaris SPARC 64-bit. Inconsistent with all other platforms, and a bit overcomplicated. Should anyone need to continue using that path, simply build with a #define POSTLOCALELIBDIR "sparcv9" to get the same result. Fixes Solaris bug 7038737: sparcv9 Xlib looking in wrong path for i18n loadable modules Signed-off-by:
Daniel Stone <daniel@fooishbar.org> Backported-to-NX-by:
-
Alan Coopersmith authored
Signed-off-by:
-
Alan Coopersmith authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
Signed-off-by:
-
Ander Conselvan de Oliveira authored
pScreenData is replaced when building per visual intensity tables. If malloc failed the old value of pScreenData (stored also in pScreenDefaultData) was being leaked. Also, property_return wasn't free'd in that case. Signed-off-by:
-
Ander Conselvan de Oliveira authored
Due to what looks like a copy & paste error, pScreenData->pBlueTbl would be accessed after being free'd. Signed-off-by:
-
Ander Conselvan de Oliveira authored
If list_count is 0, dst would be allocated and leaked. Signed-off-by:
-
Ander Conselvan de Oliveira authored
Bitmap file data is read looping through the lines in the input file. If there is extra data after the bitmap, these lines will be processed and if this data represents another bitmap it will replace the one read before causing the memory allocated for bits to leak. This changes the code to stop processing the file once a bitmap was read. Signed-off-by:
-
